qiniu /
php-sdk
| Conditions | 13 |
| Paths | 40 |
| Total Lines | 48 |
| Code Lines | 33 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 16 |
| CRAP Score | 38.0748 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 100 | public function __construct($code, $duration, array $headers = array(), $body = null, $error = null) |
||
| 101 | { |
||
| 102 | $this->statusCode = $code; |
||
| 103 | $this->duration = $duration; |
||
| 104 | 102 | $this->headers = array(); |
|
|
Deprecated Code
introduced
by
|
|||
| 105 | $this->body = $body; |
||
| 106 | 90 | $this->error = $error; |
|
| 107 | 90 | $this->jsonData = null; |
|
| 108 | 24 | ||
| 109 | 24 | if ($error !== null) { |
|
| 110 | 24 | return; |
|
| 111 | 24 | } |
|
| 112 | 24 | ||
| 113 | 90 | foreach ($headers as $k => $vs) { |
|
| 114 | 90 | if (is_array($vs)) { |
|
| 115 | $this->headers[$k] = $vs[count($vs) - 1]; |
||
| 116 | } else { |
||
| 117 | $this->headers[$k] = $vs; |
||
| 118 | } |
||
| 119 | } |
||
| 120 | 102 | $this->normalizedHeaders = new Header($headers); |
|
| 121 | |||
| 122 | if ($body === null) { |
||
| 123 | 102 | if ($code >= 400) { |
|
| 124 | $this->error = self::$statusTexts[$code]; |
||
| 125 | } |
||
| 126 | 75 | return; |
|
| 127 | } |
||
| 128 | 75 | if (self::isJson($this->normalizedHeaders)) { |
|
| 129 | try { |
||
| 130 | $jsonData = self::bodyJson($body); |
||
| 131 | 90 | if ($code >= 400) { |
|
| 132 | $this->error = $body; |
||
| 133 | 90 | if ($jsonData['error'] !== null) { |
|
| 134 | $this->error = $jsonData['error']; |
||
| 135 | } |
||
| 136 | } |
||
| 137 | $this->jsonData = $jsonData; |
||
| 138 | } catch (\InvalidArgumentException $e) { |
||
| 139 | $this->error = $body; |
||
| 140 | if ($code >= 200 && $code < 300) { |
||
| 141 | $this->error = $e->getMessage(); |
||
| 142 | } |
||
| 143 | } |
||
| 144 | } elseif ($code >= 400) { |
||
| 145 | $this->error = $body; |
||
| 146 | } |
||
| 147 | return; |
||
| 148 | 6 | } |
|
| 240 |
Loading history...
