RetryDomainsMiddleware::send() - Code Metrics - Inspection of "add http client middleware and getting region host..." - qiniu/php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#408)

unknown

created 2023-05-22 07:17 UTC

RetryDomainsMiddleware::send() A

↳ Parent: RetryDomainsMiddleware

Complexity

Conditions	5
Paths	7

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	14
nc	7
nop	2
dl	0
loc	26
rs	9.4888
c	1
b	0
f	0

<?php
namespace Qiniu\Http\Middleware;

use Qiniu\Http\Request;
use Qiniu\Http\Response;

class RetryDomainsMiddleware implements Middleware
{
    /**
     * @var array<string> backup domains.
     */
    private $backupDomains;

    /**
     * @var numeric max retry times for each backup domains.
filter:
    dependency_paths: ["lib/*"]
     */
    private $maxRetryTimes;

    /**
     * @param array<string> $backupDomains
     * @param numeric $maxRetryTimes
     */
    public function __construct($backupDomains, $maxRetryTimes = 2)
    {
        $this->backupDomains = $backupDomains;
        $this->maxRetryTimes = $maxRetryTimes;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * @param Request $request
     * @param callable(Request): Response $next
     * @return Response
     */
    public function send($request, $next)
    {
        $response = null;
        $urlComponents = parse_url($request->url);

        foreach (array_merge(array($urlComponents["host"]), $this->backupDomains) as $backupDomain) {
            $urlComponents["host"] = $backupDomain;
            $request->url = \Qiniu\unparse_url($urlComponents);
            $retriedTimes = 0;

            while ($retriedTimes < $this->maxRetryTimes) {
                $response = $next($request);

                $retriedTimes += 1;

                if ($response->ok()) {
                    return $response;
                }
            }
        }

        if (!$response) {
            $response = $next($request);
        }

        return $response;
    }
}


1			<?php
2			namespace Qiniu\Http\Middleware;
3
4			use Qiniu\Http\Request;
5			use Qiniu\Http\Response;
6
7			class RetryDomainsMiddleware implements Middleware
8			{
9			/**
10			* @var array<string> backup domains.
11			*/
12			private $backupDomains;
13
14			/**
15			* @var numeric max retry times for each backup domains.
			0 ignored issues – show Bug introduced 2023-05-22 07:38 UTC by Report Bug Copy Issue Report The type `Qiniu\Http\Middleware\numeric` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
16			*/
17			private $maxRetryTimes;
18
19			/**
20			* @param array<string> $backupDomains
21			* @param numeric $maxRetryTimes
22			*/
23			public function __construct($backupDomains, $maxRetryTimes = 2)
24			{
25			$this->backupDomains = $backupDomains;
26			$this->maxRetryTimes = $maxRetryTimes;
			0 ignored issues – show Documentation Bug introduced 2023-05-22 07:38 UTC by Report Bug Copy Issue Report It seems like `$maxRetryTimes` can also be of type `integer`. However, the property `$maxRetryTimes` is declared as type `Qiniu\Http\Middleware\numeric`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
27			}
28
29			/**
30			* @param Request $request
31			* @param callable(Request): Response $next
32			* @return Response
33			*/
34			public function send($request, $next)
35			{
36			$response = null;
37			$urlComponents = parse_url($request->url);
38
39			foreach (array_merge(array($urlComponents["host"]), $this->backupDomains) as $backupDomain) {
40			$urlComponents["host"] = $backupDomain;
41			$request->url = \Qiniu\unparse_url($urlComponents);
42			$retriedTimes = 0;
43
44			while ($retriedTimes < $this->maxRetryTimes) {
45			$response = $next($request);
46
47			$retriedTimes += 1;
48
49			if ($response->ok()) {
50			return $response;
51			}
52			}
53			}
54
55			if (!$response) {
56			$response = $next($request);
57			}
58
59			return $response;
60			}
61			}
62

qiniu / php-sdk

Pull Request — master (#408)

RetryDomainsMiddleware::send() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like