Complex classes like BucketManager often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use BucketManager, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
15 | final class BucketManager |
||
16 | { |
||
17 | private $auth; |
||
18 | private $config; |
||
19 | |||
20 | 42 | public function __construct(Auth $auth, Config $config = null) |
|
29 | |||
30 | /** |
||
31 | * 获取指定账号下所有的空间名。 |
||
32 | * |
||
33 | * @return string[] 包含所有空间名 |
||
34 | */ |
||
35 | 3 | public function buckets($shared = true) |
|
43 | |||
44 | /** |
||
45 | * 获取指定空间绑定的所有的域名 |
||
46 | * |
||
47 | * @return string[] 包含所有空间域名 |
||
48 | */ |
||
49 | public function domains($bucket) |
||
53 | |||
54 | /** |
||
55 | * 获取空间绑定的域名列表 |
||
56 | * @return string[] 包含空间绑定的所有域名 |
||
57 | */ |
||
58 | |||
59 | /** |
||
60 | * 列取空间的文件列表 |
||
61 | * |
||
62 | * @param $bucket 空间名 |
||
63 | * @param $prefix 列举前缀 |
||
64 | * @param $marker 列举标识符 |
||
65 | * @param $limit 单次列举个数限制 |
||
66 | * @param $delimiter 指定目录分隔符 |
||
67 | * |
||
68 | * @return array 包含文件信息的数组,类似:[ |
||
69 | * { |
||
70 | * "hash" => "<Hash string>", |
||
71 | * "key" => "<Key string>", |
||
72 | * "fsize" => "<file size>", |
||
73 | * "putTime" => "<file modify time>" |
||
74 | * }, |
||
75 | * ... |
||
76 | * ] |
||
77 | * @link http://developer.qiniu.com/docs/v6/api/reference/rs/list.html |
||
78 | */ |
||
79 | 3 | public function listFiles($bucket, $prefix = null, $marker = null, $limit = 1000, $delimiter = null) |
|
89 | |||
90 | /** |
||
91 | * 获取资源的元信息,但不返回文件内容 |
||
92 | * |
||
93 | * @param $bucket 待获取信息资源所在的空间 |
||
94 | * @param $key 待获取资源的文件名 |
||
95 | * |
||
96 | * @return array 包含文件信息的数组,类似: |
||
97 | * [ |
||
98 | * "hash" => "<Hash string>", |
||
99 | * "key" => "<Key string>", |
||
100 | * "fsize" => <file size>, |
||
101 | * "putTime" => "<file modify time>" |
||
102 | * "fileType" => <file type> |
||
103 | * ] |
||
104 | * |
||
105 | * @link http://developer.qiniu.com/docs/v6/api/reference/rs/stat.html |
||
106 | */ |
||
107 | 3 | public function stat($bucket, $key) |
|
112 | |||
113 | /** |
||
114 | * 删除指定资源 |
||
115 | * |
||
116 | * @param $bucket 待删除资源所在的空间 |
||
117 | * @param $key 待删除资源的文件名 |
||
118 | * |
||
119 | * @return mixed 成功返回NULL,失败返回对象Qiniu\Http\Error |
||
120 | * @link http://developer.qiniu.com/docs/v6/api/reference/rs/delete.html |
||
121 | */ |
||
122 | 6 | public function delete($bucket, $key) |
|
128 | |||
129 | |||
130 | /** |
||
131 | * 给资源进行重命名,本质为move操作。 |
||
132 | * |
||
133 | * @param $bucket 待操作资源所在空间 |
||
134 | * @param $oldname 待操作资源文件名 |
||
135 | * @param $newname 目标资源文件名 |
||
136 | * |
||
137 | * @return mixed 成功返回NULL,失败返回对象Qiniu\Http\Error |
||
138 | */ |
||
139 | 3 | public function rename($bucket, $oldname, $newname) |
|
143 | |||
144 | /** |
||
145 | * 给资源进行重命名,本质为move操作。 |
||
146 | * |
||
147 | * @param $from_bucket 待操作资源所在空间 |
||
148 | * @param $from_key 待操作资源文件名 |
||
149 | * @param $to_bucket 目标资源空间名 |
||
150 | * @param $to_key 目标资源文件名 |
||
151 | * |
||
152 | * @return mixed 成功返回NULL,失败返回对象Qiniu\Http\Error |
||
153 | * @link http://developer.qiniu.com/docs/v6/api/reference/rs/copy.html |
||
154 | */ |
||
155 | 12 | public function copy($from_bucket, $from_key, $to_bucket, $to_key, $force = false) |
|
156 | { |
||
157 | 12 | $from = \Qiniu\entry($from_bucket, $from_key); |
|
158 | 12 | $to = \Qiniu\entry($to_bucket, $to_key); |
|
159 | 12 | $path = '/copy/' . $from . '/' . $to; |
|
160 | 12 | if ($force === true) { |
|
161 | $path .= '/force/true'; |
||
162 | } |
||
163 | 12 | list(, $error) = $this->rsPost($path); |
|
164 | 12 | return $error; |
|
165 | } |
||
166 | |||
167 | /** |
||
168 | * 将资源从一个空间到另一个空间 |
||
169 | * |
||
170 | * @param $from_bucket 待操作资源所在空间 |
||
171 | * @param $from_key 待操作资源文件名 |
||
172 | * @param $to_bucket 目标资源空间名 |
||
173 | * @param $to_key 目标资源文件名 |
||
174 | * |
||
175 | * @return mixed 成功返回NULL,失败返回对象Qiniu\Http\Error |
||
176 | * @link http://developer.qiniu.com/docs/v6/api/reference/rs/move.html |
||
177 | */ |
||
178 | 3 | public function move($from_bucket, $from_key, $to_bucket, $to_key, $force = false) |
|
189 | |||
190 | /** |
||
191 | * 将资源从一个空间到另一个空间 |
||
192 | * |
||
193 | * @param $reqBody 待操作资源所在空间 |
||
194 | * @param $from_key 待操作资源文件名 |
||
195 | * @param $to_bucket 目标资源空间名 |
||
196 | * @param $to_key 目标资源文件名 |
||
197 | * |
||
198 | * @return mixed 成功返回NULL,失败返回对象Qiniu\Http\Error |
||
199 | * @link https://developer.qiniu.com/dora/manual/4258/video-pulp |
||
200 | */ |
||
201 | public function pulpVideo($reqBody, $ops, $vid, $params = null) |
||
213 | |||
214 | /** |
||
215 | * 主动修改指定资源的文件类型 |
||
216 | * |
||
217 | * @param $bucket 待操作资源所在空间 |
||
218 | * @param $key 待操作资源文件名 |
||
219 | * @param $mime 待操作文件目标mimeType |
||
220 | * |
||
221 | * @return mixed 成功返回NULL,失败返回对象Qiniu\Http\Error |
||
222 | * @link http://developer.qiniu.com/docs/v6/api/reference/rs/chgm.html |
||
223 | */ |
||
224 | 3 | public function changeMime($bucket, $key, $mime) |
|
232 | |||
233 | |||
234 | /** |
||
235 | * 修改指定资源的存储类型 |
||
236 | * |
||
237 | * @param $bucket 待操作资源所在空间 |
||
238 | * @param $key 待操作资源文件名 |
||
239 | * @param $fileType 待操作文件目标文件类型 |
||
240 | * |
||
241 | * @return mixed 成功返回NULL,失败返回对象Qiniu\Http\Error |
||
242 | * @link https://developer.qiniu.com/kodo/api/3710/modify-the-file-type |
||
243 | */ |
||
244 | public function changeType($bucket, $key, $fileType) |
||
251 | |||
252 | /** |
||
253 | * 修改文件的存储状态,即禁用状态和启用状态间的的互相转换 |
||
254 | * |
||
255 | * @param $bucket 待操作资源所在空间 |
||
256 | * @param $key 待操作资源文件名 |
||
257 | * @param $status 待操作文件目标文件类型 |
||
258 | * |
||
259 | * @return mixed 成功返回NULL,失败返回对象Qiniu\Http\Error |
||
260 | * @link https://developer.qiniu.com/kodo/api/4173/modify-the-file-status |
||
261 | */ |
||
262 | public function changeStatus($bucket, $key, $status) |
||
269 | |||
270 | /** |
||
271 | * 从指定URL抓取资源,并将该资源存储到指定空间中 |
||
272 | * |
||
273 | * @param $url 指定的URL |
||
274 | * @param $bucket 目标资源空间 |
||
275 | * @param $key 目标资源文件名 |
||
276 | * |
||
277 | * @return array 包含已拉取的文件信息。 |
||
278 | * 成功时: [ |
||
279 | * [ |
||
280 | * "hash" => "<Hash string>", |
||
281 | * "key" => "<Key string>" |
||
282 | * ], |
||
283 | * null |
||
284 | * ] |
||
285 | * |
||
286 | * 失败时: [ |
||
287 | * null, |
||
288 | * Qiniu/Http/Error |
||
289 | * ] |
||
290 | * @link http://developer.qiniu.com/docs/v6/api/reference/rs/fetch.html |
||
291 | */ |
||
292 | 3 | public function fetch($url, $bucket, $key = null) |
|
305 | |||
306 | /** |
||
307 | * 从镜像源站抓取资源到空间中,如果空间中已经存在,则覆盖该资源 |
||
308 | * |
||
309 | * @param $bucket 待获取资源所在的空间 |
||
310 | * @param $key 代获取资源文件名 |
||
311 | * |
||
312 | * @return mixed 成功返回NULL,失败返回对象Qiniu\Http\Error |
||
313 | * @link http://developer.qiniu.com/docs/v6/api/reference/rs/prefetch.html |
||
314 | */ |
||
315 | 3 | public function prefetch($bucket, $key) |
|
327 | |||
328 | /** |
||
329 | * 在单次请求中进行多个资源管理操作 |
||
330 | * |
||
331 | * @param $operations 资源管理操作数组 |
||
332 | * |
||
333 | * @return array 每个资源的处理情况,结果类似: |
||
334 | * [ |
||
335 | * { "code" => <HttpCode int>, "data" => <Data> }, |
||
336 | * { "code" => <HttpCode int> }, |
||
337 | * { "code" => <HttpCode int> }, |
||
338 | * { "code" => <HttpCode int> }, |
||
339 | * { "code" => <HttpCode int>, "data" => { "error": "<ErrorMessage string>" } }, |
||
340 | * ... |
||
341 | * ] |
||
342 | * @link http://developer.qiniu.com/docs/v6/api/reference/rs/batch.html |
||
343 | */ |
||
344 | 12 | public function batch($operations) |
|
349 | |||
350 | /** |
||
351 | * 设置文件的生命周期 |
||
352 | * |
||
353 | * @param $bucket 设置文件生命周期文件所在的空间 |
||
354 | * @param $key 设置文件生命周期文件的文件名 |
||
355 | * @param $days 设置该文件多少天后删除,当$days设置为0时表示取消该文件的生命周期 |
||
356 | * |
||
357 | * @return Mixed |
||
358 | * @link https://developer.qiniu.com/kodo/api/update-file-lifecycle |
||
359 | */ |
||
360 | 3 | public function deleteAfterDays($bucket, $key, $days) |
|
367 | |||
368 | 3 | private function getRsfHost() |
|
376 | |||
377 | 33 | private function getRsHost() |
|
385 | |||
386 | private function getArHost() |
||
394 | |||
395 | private function getApiHost() |
||
403 | |||
404 | 27 | private function rsPost($path, $body = null) |
|
409 | |||
410 | private function apiGet($path) |
||
415 | |||
416 | 6 | private function rsGet($path) |
|
421 | |||
422 | private function arPost($path, $body = null) |
||
427 | |||
428 | 9 | private function get($url) |
|
437 | |||
438 | 27 | private function post($url, $body) |
|
448 | |||
449 | private function pluPost($url, $method, $body) |
||
461 | |||
462 | 3 | public static function buildBatchCopy($source_bucket, $key_pairs, $target_bucket, $force) |
|
466 | |||
467 | |||
468 | 3 | public static function buildBatchRename($bucket, $key_pairs, $force) |
|
472 | |||
473 | |||
474 | 6 | public static function buildBatchMove($source_bucket, $key_pairs, $target_bucket, $force) |
|
478 | |||
479 | |||
480 | public static function buildBatchDelete($bucket, $keys) |
||
484 | |||
485 | |||
486 | 3 | public static function buildBatchStat($bucket, $keys) |
|
490 | |||
491 | public static function buildBatchDeleteAfterDays($bucket, $key_day_pairs) |
||
499 | |||
500 | public static function buildBatchChangeMime($bucket, $key_mime_pairs) |
||
508 | |||
509 | public static function buildBatchChangeType($bucket, $key_type_pairs) |
||
517 | |||
518 | 3 | private static function oneKeyBatch($operation, $bucket, $keys) |
|
526 | |||
527 | 9 | private static function twoKeyBatch($operation, $source_bucket, $key_pairs, $target_bucket, $force) |
|
544 | } |
||
545 |
When comparing two booleans, it is generally considered safer to use the strict comparison operator.