Qiniu\Http\Middleware\RetryDomainsMiddleware

Complexity

Total Complexity

9

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	shouldRetry()	0	7	3
A	__construct()	0	5	1
A	send()	0	26	5

<?php
namespace Qiniu\Http\Middleware;

use Qiniu\Http\Request;
use Qiniu\Http\Response;

class RetryDomainsMiddleware implements Middleware
{
    /**
     * @var array<string> backup domains.
     */
    private $backupDomains;

    /**
     * @var numeric max retry times for each backup domains.

The type Qiniu\Http\Middleware\numeric was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    private $maxRetryTimes;

    /**
     * @var callable args response and request; returns bool; If true will retry with backup domains.
     */
    private $retryCondition;

    /**
     * @param array<string> $backupDomains
     * @param numeric $maxRetryTimes
     */
    public function __construct($backupDomains, $maxRetryTimes = 2, $retryCondition = null)
    {
        $this->backupDomains = $backupDomains;
        $this->maxRetryTimes = $maxRetryTimes;

It seems like $maxRetryTimes can also be of type integer. However, the property $maxRetryTimes is declared as type Qiniu\Http\Middleware\numeric. Maybe add an additional type check?

        $this->retryCondition = $retryCondition;
    }

    private function shouldRetry($resp, $req)
    {
        if (is_callable($this->retryCondition)) {
            return call_user_func($this->retryCondition, $resp, $req);
        }

        return !$resp || $resp->needRetry();
    }

    /**
     * @param Request $request
     * @param callable(Request): Response $next
     * @return Response
     */
    public function send($request, $next)
    {
        $response = null;
        $urlComponents = parse_url($request->url);

        foreach (array_merge(array($urlComponents["host"]), $this->backupDomains) as $backupDomain) {
            $urlComponents["host"] = $backupDomain;
            $request->url = \Qiniu\unparse_url($urlComponents);
            $retriedTimes = 0;

            while ($retriedTimes < $this->maxRetryTimes) {
                $response = $next($request);

                $retriedTimes += 1;

                if (!$this->shouldRetry($response, $request)) {
                    return $response;
                }
            }
        }

        if (!$response) {
            $response = $next($request);
        }

        return $response;
    }
}