qiniu /
php-sdk
| Total Complexity | 83 |
| Total Lines | 391 |
| Duplicated Lines | 0 % |
| Coverage | 84.15% |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like ResumeUploader often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ResumeUploader, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 16 | final class ResumeUploader |
||
| 17 | { |
||
| 18 | private $upToken; |
||
| 19 | private $key; |
||
| 20 | private $inputStream; |
||
| 21 | private $size; |
||
| 22 | private $params; |
||
| 23 | private $mime; |
||
| 24 | private $contexts; |
||
| 25 | private $finishedEtags; |
||
| 26 | private $host; |
||
| 27 | private $bucket; |
||
| 28 | private $currentUrl; |
||
| 29 | private $config; |
||
| 30 | private $resumeRecordFile; |
||
| 31 | private $version; |
||
| 32 | private $partSize; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * 上传二进制流到七牛 |
||
| 36 | * |
||
| 37 | * @param string $upToken 上传凭证 |
||
| 38 | * @param string $key 上传文件名 |
||
| 39 | * @param string $inputStream 上传二进制流 |
||
| 40 | 6 | * @param string $size 上传流的大小 |
|
| 41 | * @param string $params 自定义变量 |
||
| 42 | * @param string $mime 上传数据的mimeType |
||
| 43 | * @param string $config |
||
| 44 | * @param string $resumeRecordFile 断点续传的已上传的部分信息记录文件 |
||
| 45 | * @param string $version 分片上传版本 目前支持v1/v2版本 默认v1 |
||
| 46 | * @param string $partSize 分片上传v2字段 默认大小为4MB 分片大小范围为1 MB - 1 GB |
||
| 47 | * |
||
| 48 | * @link http://developer.qiniu.com/docs/v6/api/overview/up/response/vars.html#xvar |
||
| 49 | */ |
||
| 50 | 6 | public function __construct( |
|
| 87 | 6 | } |
|
| 88 | 6 | ||
| 89 | 6 | /** |
|
| 90 | 3 | * 上传操作 |
|
| 91 | 3 | */ |
|
| 92 | public function upload($fname) |
||
| 93 | { |
||
| 94 | $uploaded = 0; |
||
| 95 | 3 | if ($this->version == 'v2') { |
|
| 96 | 3 | $partNumber = 1; |
|
| 97 | 3 | $encodedObjectName = $this->key? \Qiniu\base64_urlSafeEncode($this->key) : '~'; |
|
| 98 | 6 | }; |
|
| 99 | 3 | // get upload record from resumeRecordFile |
|
| 100 | 3 | if ($this->resumeRecordFile != null) { |
|
|
Bug
introduced
by
|
|||
| 101 | 3 | $blkputRets = null; |
|
| 102 | if (file_exists($this->resumeRecordFile)) { |
||
| 103 | 6 | $stream = fopen($this->resumeRecordFile, 'r'); |
|
| 104 | if ($stream) { |
||
| 105 | $streamLen = filesize($this->resumeRecordFile); |
||
| 106 | 6 | if ($streamLen > 0) { |
|
| 107 | 6 | $contents = fread($stream, $streamLen); |
|
| 108 | 6 | fclose($stream); |
|
| 109 | 6 | if ($contents) { |
|
| 110 | $blkputRets = json_decode($contents, true); |
||
| 111 | if ($blkputRets === null) { |
||
| 112 | error_log("resumeFile contents decode error"); |
||
| 113 | } |
||
| 114 | } else { |
||
| 115 | 6 | error_log("read resumeFile failed"); |
|
| 116 | } |
||
| 117 | 6 | } else { |
|
| 118 | 6 | error_log("resumeFile is empty"); |
|
| 119 | } |
||
| 120 | } else { |
||
| 121 | 6 | error_log("resumeFile open failed"); |
|
| 122 | } |
||
| 123 | 6 | } else { |
|
| 124 | 6 | error_log("resumeFile not exists"); |
|
| 125 | 6 | } |
|
| 126 | 6 | ||
| 127 | 6 | if ($blkputRets) { |
|
| 128 | 6 | if ($this->version == 'v1') { |
|
| 129 | 6 | if (isset($blkputRets['contexts']) && isset($blkputRets['uploaded']) && |
|
| 130 | is_array($blkputRets['contexts']) && is_int($blkputRets['uploaded'])) { |
||
| 131 | $this->contexts = $blkputRets['contexts']; |
||
| 132 | $uploaded = $blkputRets['uploaded']; |
||
| 133 | } |
||
| 134 | } elseif ($this->version == 'v2') { |
||
| 135 | 6 | if (isset($blkputRets["etags"]) && isset($blkputRets["uploadId"]) && |
|
| 136 | isset($blkputRets["expiredAt"]) && $blkputRets["expiredAt"] > time() |
||
| 137 | && $blkputRets["uploaded"] > 0 && is_array($blkputRets["etags"]) && |
||
| 138 | is_string($blkputRets["uploadId"]) && is_int($blkputRets["expiredAt"])) { |
||
| 139 | $this->finishedEtags['etags'] = $blkputRets["etags"]; |
||
| 140 | $this->finishedEtags["uploadId"] = $blkputRets["uploadId"]; |
||
| 141 | 6 | $this->finishedEtags["expiredAt"] = $blkputRets["expiredAt"]; |
|
| 142 | $this->finishedEtags["uploaded"] = $blkputRets["uploaded"]; |
||
| 143 | 6 | $uploaded = $blkputRets["uploaded"]; |
|
| 144 | 6 | $partNumber = count($this->finishedEtags["etags"]) + 1; |
|
| 145 | 6 | } else { |
|
| 146 | 6 | $this->makeInitReq($encodedObjectName); |
|
| 147 | } |
||
| 148 | } else { |
||
| 149 | 6 | throw new \Exception("only support v1/v2 now!"); |
|
| 150 | } |
||
| 151 | } else { |
||
| 152 | 6 | if ($this->version == 'v2') { |
|
| 153 | $this->makeInitReq($encodedObjectName); |
||
| 154 | } |
||
| 155 | 6 | } |
|
| 156 | } else { |
||
| 157 | 6 | // init a Multipart Upload task if choose v2 |
|
| 158 | 6 | if ($this->version == 'v2') { |
|
| 159 | 6 | $this->makeInitReq($encodedObjectName); |
|
| 160 | } |
||
| 161 | } |
||
| 162 | 6 | ||
| 163 | while ($uploaded < $this->size) { |
||
| 164 | 6 | $blockSize = $this->blockSize($uploaded); |
|
| 165 | 6 | $data = fread($this->inputStream, $blockSize); |
|
| 166 | if ($data === false) { |
||
| 167 | 6 | throw new \Exception("file read failed", 1); |
|
| 168 | } |
||
| 169 | if ($this->version == 'v1') { |
||
| 170 | $crc = \Qiniu\crc32_data($data); |
||
| 171 | $response = $this->makeBlock($data, $blockSize); |
||
| 172 | } else { |
||
| 173 | $md5 = md5($data); |
||
| 174 | $response = $this->uploadPart( |
||
| 175 | $data, |
||
| 176 | $partNumber, |
||
| 177 | $this->finishedEtags["uploadId"], |
||
| 178 | $encodedObjectName, |
||
| 179 | $md5 |
||
| 180 | ); |
||
| 181 | } |
||
| 182 | |||
| 183 | $ret = null; |
||
| 184 | if ($response->ok() && $response->json() != null) { |
||
| 185 | $ret = $response->json(); |
||
| 186 | } |
||
| 187 | if ($response->statusCode < 0) { |
||
| 188 | list($accessKey, $bucket, $err) = \Qiniu\explodeUpToken($this->upToken); |
||
| 189 | if ($err != null) { |
||
| 190 | return array(null, $err); |
||
| 191 | } |
||
| 192 | $upHostBackup = $this->config->getUpBackupHost($accessKey, $bucket); |
||
| 193 | $this->host = $upHostBackup; |
||
| 194 | } |
||
| 195 | |||
| 196 | if ($this->version == 'v1') { |
||
| 197 | if ($response->needRetry() || !isset($ret['crc32']) || $crc != $ret['crc32']) { |
||
| 198 | $response = $this->makeBlock($data, $blockSize); |
||
| 199 | $ret = $response->json(); |
||
| 200 | } |
||
| 201 | |||
| 202 | if (!$response->ok() || !isset($ret['crc32']) || $crc != $ret['crc32']) { |
||
| 203 | return array(null, new Error($this->currentUrl, $response)); |
||
| 204 | } |
||
| 205 | array_push($this->contexts, $ret['ctx']); |
||
| 206 | } else { |
||
| 207 | if ($response->needRetry() || !isset($ret['md5']) || $md5 != $ret['md5']) { |
||
| 208 | $response = $this->uploadPart( |
||
| 209 | $data, |
||
| 210 | $partNumber, |
||
| 211 | $this->finishedEtags["uploadId"], |
||
| 212 | $encodedObjectName, |
||
| 213 | $md5 |
||
| 214 | ); |
||
| 215 | $ret = $response->json(); |
||
| 216 | } |
||
| 217 | |||
| 218 | if (!$response->ok() || !isset($ret['md5']) || $md5 != $ret['md5']) { |
||
| 219 | return array(null, new Error($this->currentUrl, $response)); |
||
| 220 | } |
||
| 221 | $blockStatus = array('etag' => $ret['etag'], 'partNumber' => $partNumber); |
||
| 222 | array_push($this->finishedEtags['etags'], $blockStatus); |
||
| 223 | $partNumber += 1; |
||
| 224 | } |
||
| 225 | |||
| 226 | $uploaded += $blockSize; |
||
| 227 | if ($this->version == 'v2') { |
||
| 228 | $this->finishedEtags['uploaded'] = $uploaded; |
||
| 229 | } |
||
| 230 | |||
| 231 | if ($this->resumeRecordFile !== null) { |
||
| 232 | if ($this->version == 'v1') { |
||
| 233 | $recordData = array( |
||
| 234 | 'contexts' => $this->contexts, |
||
| 235 | 'uploaded' => $uploaded |
||
| 236 | ); |
||
| 237 | $recordData = json_encode($recordData); |
||
| 238 | } else { |
||
| 239 | $recordData = json_encode($this->finishedEtags); |
||
| 240 | } |
||
| 241 | if ($recordData) { |
||
| 242 | $isWritten = file_put_contents($this->resumeRecordFile, $recordData); |
||
| 243 | if ($isWritten === false) { |
||
| 244 | error_log("write resumeRecordFile failed"); |
||
| 245 | } |
||
| 246 | } else { |
||
| 247 | error_log('resumeRecordData encode failed'); |
||
| 248 | } |
||
| 249 | } |
||
| 250 | } |
||
| 251 | if ($this->version == 'v1') { |
||
| 252 | return $this->makeFile($fname); |
||
| 253 | } else { |
||
| 254 | return $this->completeParts($fname, $this->finishedEtags['uploadId'], $encodedObjectName); |
||
| 255 | } |
||
| 256 | } |
||
| 257 | |||
| 258 | /** |
||
| 259 | * 创建块 |
||
| 260 | */ |
||
| 261 | private function makeBlock($block, $blockSize) |
||
| 265 | } |
||
| 266 | |||
| 267 | private function fileUrl($fname) |
||
| 268 | { |
||
| 269 | $url = $this->host . '/mkfile/' . $this->size; |
||
| 270 | $url .= '/mimeType/' . \Qiniu\base64_urlSafeEncode($this->mime); |
||
| 271 | if ($this->key != null) { |
||
| 272 | $url .= '/key/' . \Qiniu\base64_urlSafeEncode($this->key); |
||
| 273 | } |
||
| 274 | $url .= '/fname/' . \Qiniu\base64_urlSafeEncode($fname); |
||
| 275 | if (!empty($this->params)) { |
||
| 276 | foreach ($this->params as $key => $value) { |
||
| 277 | $val = \Qiniu\base64_urlSafeEncode($value); |
||
| 278 | $url .= "/$key/$val"; |
||
| 279 | } |
||
| 280 | } |
||
| 281 | return $url; |
||
| 282 | } |
||
| 283 | |||
| 284 | /** |
||
| 285 | * 创建文件 |
||
| 286 | */ |
||
| 287 | private function makeFile($fname) |
||
| 299 | } |
||
| 300 | |||
| 301 | private function post($url, $data) |
||
| 302 | { |
||
| 303 | $this->currentUrl = $url; |
||
| 304 | $headers = array('Authorization' => 'UpToken ' . $this->upToken); |
||
| 305 | return Client::post($url, $data, $headers); |
||
| 306 | } |
||
| 307 | |||
| 308 | private function blockSize($uploaded) |
||
| 309 | { |
||
| 310 | if ($this->size < $uploaded + $this->partSize) { |
||
| 311 | return $this->size - $uploaded; |
||
| 312 | } |
||
| 313 | return $this->partSize; |
||
| 314 | } |
||
| 315 | |||
| 316 | private function makeInitReq($encodedObjectName) |
||
| 321 | } |
||
| 322 | |||
| 323 | /** |
||
| 324 | * 初始化上传任务 |
||
| 325 | */ |
||
| 326 | private function initReq($encodedObjectName) |
||
| 327 | { |
||
| 328 | $url = $this->host.'/buckets/'.$this->bucket.'/objects/'.$encodedObjectName.'/uploads'; |
||
| 329 | $headers = array( |
||
| 330 | 'Authorization' => 'UpToken ' . $this->upToken, |
||
| 331 | 'Content-Type' => 'application/json' |
||
| 332 | ); |
||
| 333 | $response = $this->postWithHeaders($url, null, $headers); |
||
| 334 | return $response->json(); |
||
| 335 | } |
||
| 336 | |||
| 337 | /** |
||
| 338 | * 分块上传v2 |
||
| 339 | */ |
||
| 340 | private function uploadPart($block, $partNumber, $uploadId, $encodedObjectName, $md5) |
||
| 351 | } |
||
| 352 | |||
| 353 | private function completeParts($fname, $uploadId, $encodedObjectName) |
||
| 395 | } |
||
| 396 | |||
| 397 | private function put($url, $data, $headers) |
||
| 401 | } |
||
| 402 | |||
| 403 | private function postWithHeaders($url, $data, $headers) |
||
| 409 |
Loading history...
