RequestOptions::__construct() - Code Metrics - Inspection of "Merge pull request #387 from qiniu/features/upload..." - qiniu/php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 57033f...9d0e59 )

unknown

created 2022-08-17 08:28 UTC

RequestOptions::__construct() A

↳ Parent: RequestOptions

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	1
eloc	4
nc	1
nop	4
dl	0
loc	10
rs	10
c	1
b	0
f	1

<?php

namespace Qiniu\Http;

final class RequestOptions
{

    /**
     * @var int|null
     * http 请求的超时时间，单位：秒，默认：0，不超时
     */
    public $connection_timeout;

    /**
     * @var int|null
     * http 请求的超时时间，单位：毫秒，默认：0，不超时
     */
    public $connection_timeout_ms;

    /**
     * @var int|null
     * http 请求的超时时间，单位：秒，默认：0，不超时
     */
    public $timeout;


    /**
     * @var int|null
     * http 请求的超时时间，单位：毫秒，默认：0，不超时
     */
    public $timeout_ms;

    public function __construct(
        $connection_timeout = null,
        $connection_timeout_ms = null,
        $timeout = null,
        $timeout_ms = null
    ) {
        $this->connection_timeout = $connection_timeout;
        $this->connection_timeout_ms = $connection_timeout_ms;
        $this->timeout = $timeout;
        $this->timeout_ms = $timeout_ms;
    }

    public function getCurlOpt()
    {
        $result = array();
        if ($this->connection_timeout != null) {

            $result[CURLOPT_CONNECTTIMEOUT] = $this->connection_timeout;
        }
        if ($this->connection_timeout_ms != null) {

            $result[CURLOPT_CONNECTTIMEOUT_MS] = $this->connection_timeout_ms;
        }
        if ($this->timeout != null) {

            $result[CURLOPT_TIMEOUT] = $this->timeout;
        }
        if ($this->timeout_ms != null) {

            $result[CURLOPT_TIMEOUT_MS] = $this->timeout_ms;
        }
        return $result;
    }
}


1			<?php
2
3			namespace Qiniu\Http;
4
5			final class RequestOptions
6			{
7
8			/**
9			* @var int\|null
10			* http 请求的超时时间，单位：秒，默认：0，不超时
11			*/
12			public $connection_timeout;
13
14			/**
15			* @var int\|null
16			* http 请求的超时时间，单位：毫秒，默认：0，不超时
17			*/
18			public $connection_timeout_ms;
19
20			/**
21			* @var int\|null
22			* http 请求的超时时间，单位：秒，默认：0，不超时
23			*/
24			public $timeout;
25
26
27			/**
28			* @var int\|null
29			* http 请求的超时时间，单位：毫秒，默认：0，不超时
30			*/
31			public $timeout_ms;
32
33			public function __construct(
34			$connection_timeout = null,
35			$connection_timeout_ms = null,
36			$timeout = null,
37			$timeout_ms = null
38			) {
39			$this->connection_timeout = $connection_timeout;
40			$this->connection_timeout_ms = $connection_timeout_ms;
41			$this->timeout = $timeout;
42			$this->timeout_ms = $timeout_ms;
43			}
44
45			public function getCurlOpt()
46			{
47			$result = array();
48			if ($this->connection_timeout != null) {
			0 ignored issues – show Bug Best Practice introduced 2022-07-07 03:00 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$this->connection_timeout` of type `integer\|null` against `null`; this is ambiguous if the integer can be zero. Consider using a strict comparison `!==` instead. Loading history...
49			$result[CURLOPT_CONNECTTIMEOUT] = $this->connection_timeout;
50			}
51			if ($this->connection_timeout_ms != null) {
			0 ignored issues – show Bug Best Practice introduced 2022-07-07 03:00 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$this->connection_timeout_ms` of type `integer\|null` against `null`; this is ambiguous if the integer can be zero. Consider using a strict comparison `!==` instead. Loading history...
52			$result[CURLOPT_CONNECTTIMEOUT_MS] = $this->connection_timeout_ms;
53			}
54			if ($this->timeout != null) {
			0 ignored issues – show Bug Best Practice introduced 2022-07-07 03:00 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$this->timeout` of type `integer\|null` against `null`; this is ambiguous if the integer can be zero. Consider using a strict comparison `!==` instead. Loading history...
55			$result[CURLOPT_TIMEOUT] = $this->timeout;
56			}
57			if ($this->timeout_ms != null) {
			0 ignored issues – show Bug Best Practice introduced 2022-07-07 03:00 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$this->timeout_ms` of type `integer\|null` against `null`; this is ambiguous if the integer can be zero. Consider using a strict comparison `!==` instead. Loading history...
58			$result[CURLOPT_TIMEOUT_MS] = $this->timeout_ms;
59			}
60			return $result;
61			}
62			}
63

qiniu / php-sdk

Push — master ( 57033f...9d0e59 )

RequestOptions::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like