Qiniu\Http\RequestOptions::getCurlOpt()

Complexity

Conditions	5
Paths	16

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function getCurlOpt()
    {
        $result = array();
        if ($this->connection_timeout != null) {

It seems like you are loosely comparing $this->connection_timeout of type integer|null against null; this is ambiguous if the integer can be zero. Consider using a strict comparison !== instead.

            $result[CURLOPT_CONNECTTIMEOUT] = $this->connection_timeout;
        }
        if ($this->connection_timeout_ms != null) {

It seems like you are loosely comparing $this->connection_timeout_ms of type integer|null against null; this is ambiguous if the integer can be zero. Consider using a strict comparison !== instead.

            $result[CURLOPT_CONNECTTIMEOUT_MS] = $this->connection_timeout_ms;
        }
        if ($this->timeout != null) {

It seems like you are loosely comparing $this->timeout of type integer|null against null; this is ambiguous if the integer can be zero. Consider using a strict comparison !== instead.

            $result[CURLOPT_TIMEOUT] = $this->timeout;
        }
        if ($this->timeout_ms != null) {

It seems like you are loosely comparing $this->timeout_ms of type integer|null against null; this is ambiguous if the integer can be zero. Consider using a strict comparison !== instead.

            $result[CURLOPT_TIMEOUT_MS] = $this->timeout_ms;
        }
        return $result;
    }