RequestOptions::__construct() - Code Metrics - Inspection of "Merge pull request #413 from qiniu/chore/improve-c..." - qiniu/php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6277d2...6a6da4 )

unknown

created 2023-06-21 10:45 UTC

RequestOptions::__construct() A

↳ Parent: RequestOptions

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	1
eloc	5
nc	1
nop	5
dl	0
loc	12
rs	10
c	1
b	0
f	1

<?php

namespace Qiniu\Http;

use Qiniu\Http\Middleware\Middleware;

final class RequestOptions
{

    /**
     * @var int|null
     * http 请求的超时时间，单位：秒，默认：0，不超时
     */
    public $connection_timeout;

    /**
     * @var int|null
     * http 请求的超时时间，单位：毫秒，默认：0，不超时
     */
    public $connection_timeout_ms;

    /**
     * @var int|null
     * http 请求的超时时间，单位：秒，默认：0，不超时
     */
    public $timeout;


    /**
     * @var int|null
     * http 请求的超时时间，单位：毫秒，默认：0，不超时
     */
    public $timeout_ms;

    /**
     * @var array<Middleware>
     */
    public $middlewares;

    public function __construct(
        $connection_timeout = null,
        $connection_timeout_ms = null,
        $timeout = null,
        $timeout_ms = null,
        $middlewares = array()
    ) {
        $this->connection_timeout = $connection_timeout;
        $this->connection_timeout_ms = $connection_timeout_ms;
        $this->timeout = $timeout;
        $this->timeout_ms = $timeout_ms;
        $this->middlewares = $middlewares;
    }

    public function getCurlOpt()
    {
        $result = array();
        if ($this->connection_timeout != null) {

            $result[CURLOPT_CONNECTTIMEOUT] = $this->connection_timeout;
        }
        if ($this->connection_timeout_ms != null) {

            $result[CURLOPT_CONNECTTIMEOUT_MS] = $this->connection_timeout_ms;
        }
        if ($this->timeout != null) {

            $result[CURLOPT_TIMEOUT] = $this->timeout;
        }
        if ($this->timeout_ms != null) {

            $result[CURLOPT_TIMEOUT_MS] = $this->timeout_ms;
        }
        return $result;
    }
}


1			<?php
2
3			namespace Qiniu\Http;
4
5			use Qiniu\Http\Middleware\Middleware;
6
7			final class RequestOptions
8			{
9
10			/**
11			* @var int\|null
12			* http 请求的超时时间，单位：秒，默认：0，不超时
13			*/
14			public $connection_timeout;
15
16			/**
17			* @var int\|null
18			* http 请求的超时时间，单位：毫秒，默认：0，不超时
19			*/
20			public $connection_timeout_ms;
21
22			/**
23			* @var int\|null
24			* http 请求的超时时间，单位：秒，默认：0，不超时
25			*/
26			public $timeout;
27
28
29			/**
30			* @var int\|null
31			* http 请求的超时时间，单位：毫秒，默认：0，不超时
32			*/
33			public $timeout_ms;
34
35			/**
36			* @var array<Middleware>
37			*/
38			public $middlewares;
39
40			public function __construct(
41			$connection_timeout = null,
42			$connection_timeout_ms = null,
43			$timeout = null,
44			$timeout_ms = null,
45			$middlewares = array()
46			) {
47			$this->connection_timeout = $connection_timeout;
48			$this->connection_timeout_ms = $connection_timeout_ms;
49			$this->timeout = $timeout;
50			$this->timeout_ms = $timeout_ms;
51			$this->middlewares = $middlewares;
52			}
53
54			public function getCurlOpt()
55			{
56			$result = array();
57			if ($this->connection_timeout != null) {
			0 ignored issues – show Bug Best Practice introduced 2022-07-07 03:00 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$this->connection_timeout` of type `integer\|null` against `null`; this is ambiguous if the integer can be zero. Consider using a strict comparison `!==` instead. Loading history...
58			$result[CURLOPT_CONNECTTIMEOUT] = $this->connection_timeout;
59			}
60			if ($this->connection_timeout_ms != null) {
			0 ignored issues – show Bug Best Practice introduced 2022-07-07 03:00 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$this->connection_timeout_ms` of type `integer\|null` against `null`; this is ambiguous if the integer can be zero. Consider using a strict comparison `!==` instead. Loading history...
61			$result[CURLOPT_CONNECTTIMEOUT_MS] = $this->connection_timeout_ms;
62			}
63			if ($this->timeout != null) {
			0 ignored issues – show Bug Best Practice introduced 2022-07-07 03:00 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$this->timeout` of type `integer\|null` against `null`; this is ambiguous if the integer can be zero. Consider using a strict comparison `!==` instead. Loading history...
64			$result[CURLOPT_TIMEOUT] = $this->timeout;
65			}
66			if ($this->timeout_ms != null) {
			0 ignored issues – show Bug Best Practice introduced 2022-07-07 03:00 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$this->timeout_ms` of type `integer\|null` against `null`; this is ambiguous if the integer can be zero. Consider using a strict comparison `!==` instead. Loading history...
67			$result[CURLOPT_TIMEOUT_MS] = $this->timeout_ms;
68			}
69			return $result;
70			}
71			}
72

qiniu / php-sdk

Push — master ( 6277d2...6a6da4 )

RequestOptions::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like