Qiniu\Storage\UploadManager::putFile()

Complexity

Conditions	5
Paths	8

Size

Total Lines	55
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	24
CRAP Score	5.5069

Importance

Changes	3
Bugs	1	Features	0

<?php
    public function putFile(
        $upToken,
        $key,
        $filePath,
        $params = null,
        $mime = 'application/octet-stream',
        $checkCrc = false,

The parameter $checkCrc is not used and could be removed.

        $resumeRecordFile = null,
        $version = 'v1',
        $partSize = config::BLOCK_SIZE,
        $reqOpt = null
    ) {
        $reqOpt = $reqOpt === null ? $this->reqOpt : $reqOpt;

        $file = fopen($filePath, 'rb');
        if ($file === false) {
            throw new \Exception("file can not open", 1);
        }
        $params = self::trimParams($params);
        $stat = fstat($file);
        $size = $stat['size'];
        if ($size <= Config::BLOCK_SIZE) {
            $data = fread($file, $size);
            fclose($file);
            if ($data === false) {
                throw new \Exception("file can not read", 1);
            }
            return FormUploader::put(
                $upToken,
                $key,
                $data,
                $this->config,
                $params,

It seems like $params can also be of type array and array; however, parameter $params of Qiniu\Storage\FormUploader::put() does only seem to accept string, maybe add an additional type check?

                $mime,
                basename($filePath),
                $reqOpt
            );
        }

        $up = new ResumeUploader(
            $upToken,
            $key,
            $file,
            $size,
            $params,
            $mime,
            $this->config,
            $resumeRecordFile,
            $version,
            $partSize,
            $reqOpt
        );
        $ret = $up->upload(basename($filePath));
        fclose($file);
        return $ret;
    }