TestParticle.setUp() - Code Metrics - Inspection of "[In progress] Feature/add grouping opt" - qbahn/grortir - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#43)

by Wojtek

created 2016-08-23 21:19 UTC

TestParticle.setUp() B

↳ Parent: TestParticle

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	17
rs	8.5454
cc	5

from unittest import TestCase
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
from unittest.mock import Mock

import numpy as np
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from grortir.main.pso.particle import Particle
from grortir.main.pso.position_updater import PositionUpdater
from grortir.main.pso.velocity_calculator import VelocityCalculator


class TestParticle(TestCase):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def setUp(self):
        self.particle_mock = Mock()
        self.stages = [Mock(), Mock()]
        self.position_updaters = {stage: Mock() for stage in self.stages}
        self.velocity_calculators = {stage: Mock() for stage in self.stages}
        for i in range(len(self.stages)):
            stage = self.stages[i]
            self.velocity_calculators[
                stage].calculate_initial_velocity.return_value = 0.01 * (i + 1)
        self.particle_mock.stages = self.stages
        self.particle_mock.position_updaters = self.position_updaters
        self.particle_mock.velocity_calculators = self.velocity_calculators
        self.particle_mock.current_velocities = {}
        self.particle_mock.current_quality = {stage: 100 for stage in
                                              self.stages}
        self.process = Mock()
        self.particle_mock.process = self.process

    def test_get_the_overall_quality_po(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        particle_mock = Mock()
        particle_mock.current_quality = {'a': 2, 'b': 3, 'c': -3.1234}
        result = Particle.get_the_overall_quality(particle_mock)
        self.assertEqual(result, 3)

    def test___init__(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        particle = Particle(self.stages, self.process)
        self.assertIsNotNone(particle)
        self.assertEqual(particle.best_quality, np.inf)

    def test__set_initial_positons(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        Particle._set_initial_positions(self.particle_mock)
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
        for stage in self.stages:
            self.position_updaters[
                stage].set_initial_control_params.assert_any_call()

    def test__set_initial_velocities(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        Particle._set_initial_velocities(self.particle_mock)
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
        i = 0
        for stage in self.stages:
            self.assertEqual(self.particle_mock.current_velocities[stage],
                             0.01 * (i + 1))
            i += 1

    def test_initialize(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        Particle.initialize(self.particle_mock)
        for stage in self.stages:
            self.assertEqual(self.particle_mock.position_updaters[stage].stage,
                             stage)
            self.assertIsInstance(self.particle_mock.position_updaters[stage],
                                  PositionUpdater)
            self.assertEqual(
                self.particle_mock.velocity_calculators[stage].stage,
                stage)
            self.assertIsInstance(
                self.particle_mock.velocity_calculators[stage],
                VelocityCalculator)
        self.particle_mock._set_initial_positions.assart_any_call()
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
        self.particle_mock._set_initial_velocities.assart_any_call()
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

    def test_update_values(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        Particle.update_values(self.particle_mock)
        self.particle_mock.update_input_vectors.assert_any_call()
        self.particle_mock.calculate_current_quality.assert_any_call()
        self.particle_mock._update_best_position.assert_any_call()
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent


Pull Request — master (#43)

TestParticle.setUp() B

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing init.py files

1			from unittest import TestCase
			0 ignored issues – show Coding Style introduced 2016-07-16 00:25 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			from unittest.mock import Mock
3
4			import numpy as np
			0 ignored issues – show Configuration introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report The import `numpy` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
5
6			from grortir.main.pso.particle import Particle
7			from grortir.main.pso.position_updater import PositionUpdater
8			from grortir.main.pso.velocity_calculator import VelocityCalculator
9
10
11			class TestParticle(TestCase):
			0 ignored issues – show Coding Style introduced 2016-07-16 00:25 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
12			def setUp(self):
13			self.particle_mock = Mock()
14			self.stages = [Mock(), Mock()]
15			self.position_updaters = {stage: Mock() for stage in self.stages}
16			self.velocity_calculators = {stage: Mock() for stage in self.stages}
17			for i in range(len(self.stages)):
18			stage = self.stages[i]
19			self.velocity_calculators[
20			stage].calculate_initial_velocity.return_value = 0.01 * (i + 1)
21			self.particle_mock.stages = self.stages
22			self.particle_mock.position_updaters = self.position_updaters
23			self.particle_mock.velocity_calculators = self.velocity_calculators
24			self.particle_mock.current_velocities = {}
25			self.particle_mock.current_quality = {stage: 100 for stage in
26			self.stages}
27			self.process = Mock()
28			self.particle_mock.process = self.process
29
30			def test_get_the_overall_quality_po(self):
			0 ignored issues – show Coding Style introduced 2016-07-16 00:25 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
31			particle_mock = Mock()
32			particle_mock.current_quality = {'a': 2, 'b': 3, 'c': -3.1234}
33			result = Particle.get_the_overall_quality(particle_mock)
34			self.assertEqual(result, 3)
35
36			def test___init__(self):
			0 ignored issues – show Coding Style introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
37			particle = Particle(self.stages, self.process)
38			self.assertIsNotNone(particle)
39			self.assertEqual(particle.best_quality, np.inf)
40
41			def test__set_initial_positons(self):
			0 ignored issues – show Coding Style introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
42			Particle._set_initial_positions(self.particle_mock)
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report It seems like `_set_initial_positions` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
43			for stage in self.stages:
44			self.position_updaters[
45			stage].set_initial_control_params.assert_any_call()
46
47			def test__set_initial_velocities(self):
			0 ignored issues – show Coding Style introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
48			Particle._set_initial_velocities(self.particle_mock)
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report It seems like `_set_initial_velocities` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
49			i = 0
50			for stage in self.stages:
51			self.assertEqual(self.particle_mock.current_velocities[stage],
52			0.01 * (i + 1))
53			i += 1
54
55			def test_initialize(self):
			0 ignored issues – show Coding Style introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
56			Particle.initialize(self.particle_mock)
57			for stage in self.stages:
58			self.assertEqual(self.particle_mock.position_updaters[stage].stage,
59			stage)
60			self.assertIsInstance(self.particle_mock.position_updaters[stage],
61			PositionUpdater)
62			self.assertEqual(
63			self.particle_mock.velocity_calculators[stage].stage,
64			stage)
65			self.assertIsInstance(
66			self.particle_mock.velocity_calculators[stage],
67			VelocityCalculator)
68			self.particle_mock._set_initial_positions.assart_any_call()
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report It seems like `_set_initial_positions` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
69			self.particle_mock._set_initial_velocities.assart_any_call()
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report It seems like `_set_initial_velocities` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
70
71			def test_update_values(self):
			0 ignored issues – show Coding Style introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
72			Particle.update_values(self.particle_mock)
73			self.particle_mock.update_input_vectors.assert_any_call()
74			self.particle_mock.calculate_current_quality.assert_any_call()
75			self.particle_mock._update_best_position.assert_any_call()
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report It seems like `_update_best_position` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
76

qbahn / grortir

Pull Request — master (#43)

TestParticle.setUp() B

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files