PositionUpdater._fix_coordinates() - Code Metrics - Inspection of "[In progress] Feature/add grouping opt" - qbahn/grortir - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#43)

by Wojtek

created 2016-08-23 21:30 UTC

PositionUpdater._fix_coordinates() A

↳ Parent: PositionUpdater

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	4.5923

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	4
c	1
b	0
f	1
dl	0
loc	6
ccs	4
cts	6
cp	0.6667
crap	4.5923
rs	9.2

"""Contain mechanism for changing position."""

import numpy as np
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3


class PositionUpdater:
    """Class responsible for moving objects.

        Attributes:
            stage (AbstractStage): Stage in which we are going to move.
    """
    def __init__(self, stage):
        self.stage = stage
        self.lower_bounds = np.asarray(self.stage.lower_bounds)
        self.upper_bounds = np.asarray(self.stage.upper_bounds)

    def set_initial_control_params(self):
        """Set initial positions."""
        random = np.random.rand(len(self.stage.control_params))
        delta = self.upper_bounds - self.lower_bounds
        control_params = self.lower_bounds + random * delta
        self.stage.control_params = control_params.tolist()

    def update_position(self, velocity):
        """Update positions."""
        self.stage.control_params = self.stage.control_params + velocity
        self._fix_coordinates()

    def _fix_coordinates(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        for i in range(len(self.stage.control_params)):
            if self.stage.control_params[i] > self.stage.upper_bounds[i]:
                self.stage.control_params[i] = self.stage.upper_bounds[i]
            elif self.stage.control_params[i] < self.stage.lower_bounds[i]:
                self.stage.control_params[i] = self.stage.lower_bounds[i]


Pull Request — master (#43)

PositionUpdater._fix_coordinates() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing Dependencies

2. Missing init.py files

1		"""Contain mechanism for changing position."""
2
3	1	import numpy as np
		0 ignored issues – show Configuration introduced 2016-07-16 00:25 UTC by Report Bug Copy Issue Report The import `numpy` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
4
5
6	1	class PositionUpdater:
7		"""Class responsible for moving objects.
8
9		Attributes:
10		stage (AbstractStage): Stage in which we are going to move.
11		"""
12	1	def __init__(self, stage):
13	1	self.stage = stage
14	1	self.lower_bounds = np.asarray(self.stage.lower_bounds)
15	1	self.upper_bounds = np.asarray(self.stage.upper_bounds)
16
17	1	def set_initial_control_params(self):
18		"""Set initial positions."""
19	1	random = np.random.rand(len(self.stage.control_params))
20	1	delta = self.upper_bounds - self.lower_bounds
21	1	control_params = self.lower_bounds + random * delta
22	1	self.stage.control_params = control_params.tolist()
23
24	1	def update_position(self, velocity):
25		"""Update positions."""
26	1	self.stage.control_params = self.stage.control_params + velocity
27	1	self._fix_coordinates()
28
29	1	def _fix_coordinates(self):
		0 ignored issues – show Coding Style introduced 2016-07-20 23:10 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
30	1	for i in range(len(self.stage.control_params)):
31	1	if self.stage.control_params[i] > self.stage.upper_bounds[i]:
32		self.stage.control_params[i] = self.stage.upper_bounds[i]
33	1	elif self.stage.control_params[i] < self.stage.lower_bounds[i]:
34		self.stage.control_params[i] = self.stage.lower_bounds[i]
35

qbahn / grortir

Pull Request — master (#43)

PositionUpdater._fix_coordinates() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files