TestSwarm.test_constructor() - Code Metrics - Inspection of "Feature/linear rvt" - qbahn/grortir - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#45)

by Wojtek

created 2016-10-12 21:39 UTC

TestSwarm.test_constructor() A

↳ Parent: TestSwarm

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	5
rs	9.4285
cc	1

from unittest import TestCase
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

import numpy as np
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
import unittest.mock as mo

from grortir.main.pso.swarm import Swarm


class TestSwarm(TestCase):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def setUp(self):
        self.stages = mo.Mock()
        self.process = mo.Mock()
        self.number_of_particles = 40
        self.tested_object = Swarm(self.process, self.stages,
                                   self.number_of_particles)
        self.mock_of_swarm = mo.Mock()
        self.mock_of_particle_1 = mo.Mock()
        self.mock_of_particle_2 = mo.Mock()
        self.mock_of_swarm.particles = [self.mock_of_particle_1,
                                        self.mock_of_particle_2]
        self.mock_of_best_particle = mo.Mock()
        self.mock_of_swarm.best_particle = self.mock_of_best_particle

    def test_constructor(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.assertIsNotNone(self.tested_object)
        self.assertEqual(self.stages, self.tested_object.stages)
        self.assertEqual(self.tested_object.number_of_particles,
                         self.number_of_particles)

    def test_initialize(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        Swarm.initialize(self.mock_of_swarm)
        self.mock_of_particle_1.initialize.assert_any_call()
        self.mock_of_particle_2.initialize.assert_any_call()

    def test_do_single_iteration(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.mock_of_swarm.particles = [self.mock_of_particle_1,
                                        self.mock_of_particle_1]
        expected_calls_particle = [mo.call.update_values(),
                                   mo.call.update_values(),
                                   mo.call.move(), mo.call.move()]
        expected_calls_swarm = [mo.call._update_best_particle(),
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
                                mo.call._update_velocieties()]
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

        Swarm.do_single_iteration(self.mock_of_swarm)

        self.assertListEqual(expected_calls_particle,
                             self.mock_of_particle_1.method_calls)
        self.assertListEqual(expected_calls_swarm,
                             self.mock_of_swarm.method_calls)

    def test__update_best_particle_1(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.mock_of_swarm.best_particle_quality = np.inf
        self.mock_of_particle_1.best_quality = 7
        self.mock_of_particle_2.best_quality = 6

        Swarm._update_best_particle(self.mock_of_swarm)
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

        self.assertEqual(self.mock_of_swarm.best_particle_quality, 6)
        self.assertEqual(self.mock_of_swarm.best_particle,
                         self.mock_of_particle_2)

    def test__update_best_particle_2(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.mock_of_swarm.best_particle_quality = np.inf
        self.mock_of_particle_1.best_quality = 7
        self.mock_of_particle_2.best_quality = 8

        Swarm._update_best_particle(self.mock_of_swarm)
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

        self.assertEqual(self.mock_of_swarm.best_particle_quality, 7)
        self.assertEqual(self.mock_of_swarm.best_particle,
                         self.mock_of_particle_1)

    def test__update_velocieties(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        Swarm._update_velocieties(self.mock_of_swarm)
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
        self.mock_of_particle_1.update_velocities.assert_called_once_with(
            self.mock_of_best_particle)
        self.mock_of_particle_2.update_velocities.assert_called_once_with(
            self.mock_of_best_particle)


1			from unittest import TestCase
			0 ignored issues – show Coding Style introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2
3			import numpy as np
			0 ignored issues – show Configuration introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report The import `numpy` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
4			import unittest.mock as mo
5
6			from grortir.main.pso.swarm import Swarm
7
8
9			class TestSwarm(TestCase):
			0 ignored issues – show Coding Style introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... best-practice introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report Too many instance attributes (8/7) Loading history...
10			def setUp(self):
11			self.stages = mo.Mock()
12			self.process = mo.Mock()
13			self.number_of_particles = 40
14			self.tested_object = Swarm(self.process, self.stages,
15			self.number_of_particles)
16			self.mock_of_swarm = mo.Mock()
17			self.mock_of_particle_1 = mo.Mock()
18			self.mock_of_particle_2 = mo.Mock()
19			self.mock_of_swarm.particles = [self.mock_of_particle_1,
20			self.mock_of_particle_2]
21			self.mock_of_best_particle = mo.Mock()
22			self.mock_of_swarm.best_particle = self.mock_of_best_particle
23
24			def test_constructor(self):
			0 ignored issues – show Coding Style introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
25			self.assertIsNotNone(self.tested_object)
26			self.assertEqual(self.stages, self.tested_object.stages)
27			self.assertEqual(self.tested_object.number_of_particles,
28			self.number_of_particles)
29
30			def test_initialize(self):
			0 ignored issues – show Coding Style introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
31			Swarm.initialize(self.mock_of_swarm)
32			self.mock_of_particle_1.initialize.assert_any_call()
33			self.mock_of_particle_2.initialize.assert_any_call()
34
35			def test_do_single_iteration(self):
			0 ignored issues – show Coding Style introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
36			self.mock_of_swarm.particles = [self.mock_of_particle_1,
37			self.mock_of_particle_1]
38			expected_calls_particle = [mo.call.update_values(),
39			mo.call.update_values(),
40			mo.call.move(), mo.call.move()]
41			expected_calls_swarm = [mo.call._update_best_particle(),
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report It seems like `_update_best_particle` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
42			mo.call._update_velocieties()]
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report It seems like `_update_velocieties` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
43
44			Swarm.do_single_iteration(self.mock_of_swarm)
45
46			self.assertListEqual(expected_calls_particle,
47			self.mock_of_particle_1.method_calls)
48			self.assertListEqual(expected_calls_swarm,
49			self.mock_of_swarm.method_calls)
50
51			def test__update_best_particle_1(self):
			0 ignored issues – show Coding Style introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
52			self.mock_of_swarm.best_particle_quality = np.inf
53			self.mock_of_particle_1.best_quality = 7
54			self.mock_of_particle_2.best_quality = 6
55
56			Swarm._update_best_particle(self.mock_of_swarm)
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report It seems like `_update_best_particle` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
57
58			self.assertEqual(self.mock_of_swarm.best_particle_quality, 6)
59			self.assertEqual(self.mock_of_swarm.best_particle,
60			self.mock_of_particle_2)
61
62			def test__update_best_particle_2(self):
			0 ignored issues – show Coding Style introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
63			self.mock_of_swarm.best_particle_quality = np.inf
64			self.mock_of_particle_1.best_quality = 7
65			self.mock_of_particle_2.best_quality = 8
66
67			Swarm._update_best_particle(self.mock_of_swarm)
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report It seems like `_update_best_particle` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
68
69			self.assertEqual(self.mock_of_swarm.best_particle_quality, 7)
70			self.assertEqual(self.mock_of_swarm.best_particle,
71			self.mock_of_particle_1)
72
73			def test__update_velocieties(self):
			0 ignored issues – show Coding Style introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
74			Swarm._update_velocieties(self.mock_of_swarm)
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-23 22:45 UTC by Report Bug Copy Issue Report It seems like `_update_velocieties` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
75			self.mock_of_particle_1.update_velocities.assert_called_once_with(
76			self.mock_of_best_particle)
77			self.mock_of_particle_2.update_velocities.assert_called_once_with(
78			self.mock_of_best_particle)
79

qbahn / grortir

Pull Request — master (#45)

TestSwarm.test_constructor() A

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files