PositionUpdater._fix_coordinates() - Code Metrics - Inspection of "Feature/linear rvt" - qbahn/grortir - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#45)

by Wojtek

created 2016-10-12 21:39 UTC

PositionUpdater._fix_coordinates() A

↳ Parent: PositionUpdater

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
c	1
b	0
f	0
dl	0
loc	8
rs	9.2
ccs	7
cts	7
cp	1
crap	4

"""Contain mechanism for changing position."""

import numpy as np
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3


class PositionUpdater:
    """Class responsible for moving objects.

        Attributes:
            stage (AbstractStage): Stage in which we are going to move.
            control_params (dict): Control params for stages.
    """

    def __init__(self, control_params):
        self.control_params = control_params

    @staticmethod
    def set_initial_control_params(control_params):
        """Set initial positions."""
        for stage in control_params:
            random = np.random.rand(len(control_params[stage]))
            delta = np.asarray(stage.upper_bounds) - np.asarray(
                stage.lower_bounds)
            new_control_params = np.asarray(stage.lower_bounds) + random * delta
            control_params[stage] = new_control_params.tolist()
        return control_params

    def update_position(self, velocities, control_params):
        """Update positions."""
        for stage in velocities:
            new_control_params = control_params[stage] + velocities[stage]
            control_params[stage] = self._fix_coordinates(stage,
                                                          new_control_params)
        return control_params

    @staticmethod
    def _fix_coordinates(stage, control_params):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        for index, single_param in enumerate(control_params):
            if single_param > stage.upper_bounds[index]:
                control_params[index] = stage.upper_bounds[index]
            elif single_param < stage.lower_bounds[index]:
                control_params[index] = stage.lower_bounds[index]
        return control_params


Pull Request — master (#45)

PositionUpdater._fix_coordinates() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing Dependencies

2. Missing init.py files

1		"""Contain mechanism for changing position."""
2
3	1	import numpy as np
		0 ignored issues – show Configuration introduced 2016-07-16 00:25 UTC by Report Bug Copy Issue Report The import `numpy` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
4
5
6	1	class PositionUpdater:
7		"""Class responsible for moving objects.
8
9		Attributes:
10		stage (AbstractStage): Stage in which we are going to move.
11		control_params (dict): Control params for stages.
12		"""
13
14	1	def __init__(self, control_params):
15	1	self.control_params = control_params
16
17	1	@staticmethod
18		def set_initial_control_params(control_params):
19		"""Set initial positions."""
20	1	for stage in control_params:
21	1	random = np.random.rand(len(control_params[stage]))
22	1	delta = np.asarray(stage.upper_bounds) - np.asarray(
23		stage.lower_bounds)
24	1	new_control_params = np.asarray(stage.lower_bounds) + random * delta
25	1	control_params[stage] = new_control_params.tolist()
26	1	return control_params
27
28	1	def update_position(self, velocities, control_params):
29		"""Update positions."""
30	1	for stage in velocities:
31	1	new_control_params = control_params[stage] + velocities[stage]
32	1	control_params[stage] = self._fix_coordinates(stage,
33		new_control_params)
34	1	return control_params
35
36	1	@staticmethod
37		def _fix_coordinates(stage, control_params):
		0 ignored issues – show Coding Style introduced 2016-10-12 21:41 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
38	1	for index, single_param in enumerate(control_params):
39	1	if single_param > stage.upper_bounds[index]:
40	1	control_params[index] = stage.upper_bounds[index]
41	1	elif single_param < stage.lower_bounds[index]:
42	1	control_params[index] = stage.lower_bounds[index]
43		return control_params
44

qbahn / grortir

Pull Request — master (#45)

PositionUpdater._fix_coordinates() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files