GroupedOptimizer - Code Metrics - Inspection of "[In progress] Feature/add grouping opt" - qbahn/grortir - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#43)

by Wojtek

created 2016-07-25 22:56 UTC

GroupedOptimizer A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	15
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
c	1
b	0
f	0
dl	0
loc	15
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__init__()	0	4	1
A	optimize_process()	0	7	1

"""Basic grouped optimizer."""

from grortir.main.pso.pso_algorithm import PsoAlgorithm
from main.model.core.optimization_status import OptimizationStatus
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3


class Result(object):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def __init__(self, process):
        self.process = process
        self.summary_result = OptimizationStatus.not_started
        self.detailed_result = {}

    def generate(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        for stage in self.process.nodes():
            self.detailed_result[str(stage)] = stage.optimization_status
        for stage in self.process.nodes():
            if stage.optimization_status != OptimizationStatus.success:
                self.summary_result = OptimizationStatus.failed


class GroupedOptimizer:
    """Optimizer is object which optimize process."""

    def __init__(self, process, grouping_strategy):
        self.process = process
        self.grouping_strategy = grouping_strategy
        self.result = Result(self.process)

    def optimize_process(self):
        """Optimize process.
        Returns:
            True if success, False otherwise."""
        pso = PsoAlgorithm(self.process, self.grouping_strategy)
        pso.run()
        self.result.generate()


Pull Request — master (#43)

GroupedOptimizer A

Complexity

Size/Duplication

Importance

2 Methods

1. Missing Dependencies

2. Missing init.py files

1			"""Basic grouped optimizer."""
2
3			from grortir.main.pso.pso_algorithm import PsoAlgorithm
4			from main.model.core.optimization_status import OptimizationStatus
			0 ignored issues – show Bug introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report The name `model` does not seem to exist in module `main`. Loading history... Configuration introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report The import `main.model.core.optimization_status` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
5
6
7			class Result(object):
			0 ignored issues – show Coding Style introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
8			def __init__(self, process):
9			self.process = process
10			self.summary_result = OptimizationStatus.not_started
11			self.detailed_result = {}
12
13			def generate(self):
			0 ignored issues – show Coding Style introduced 2016-07-25 23:05 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
14			for stage in self.process.nodes():
15			self.detailed_result[str(stage)] = stage.optimization_status
16			for stage in self.process.nodes():
17			if stage.optimization_status != OptimizationStatus.success:
18			self.summary_result = OptimizationStatus.failed
19
20
21			class GroupedOptimizer:
22			"""Optimizer is object which optimize process."""
23
24			def __init__(self, process, grouping_strategy):
25			self.process = process
26			self.grouping_strategy = grouping_strategy
27			self.result = Result(self.process)
28
29			def optimize_process(self):
30			"""Optimize process.
31			Returns:
32			True if success, False otherwise."""
33			pso = PsoAlgorithm(self.process, self.grouping_strategy)
34			pso.run()
35			self.result.generate()
36

qbahn / grortir

Pull Request — master (#43)

GroupedOptimizer A

Complexity

Size/Duplication

Importance

2 Methods

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files