CallsRegistry - Code Metrics - Inspection of "Initial test (#49)" - qbahn/grortir - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aa0ea9...358d48 )

by Wojtek

created 2016-10-15 17:39 UTC

CallsRegistry A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	49
rs	10
wmc	6

4 Methods

Rating	Name	Size	Complexity
A	add_call()	14	1
A	get_method_calls()	12	1
A	register_call()	16	3
A	__init__()	3	1

from tests.framework.calls.calls_record import CallRecord
class SomeClass:
    def some_method(self):
        """Do x and return foo."""


# pylint: disable=too-many-arguments



class CallsRegistry:
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def __init__(self):
        self.calls_storage = {}
        self.calls_counter = 0

    def register_call(self, call_record):
        """
        Register call.
        Args:
            call_record (CallRecord): represent call
        """
        self.calls_counter += 1
        if self.calls_storage.get(call_record.entity_name) is None:
            self.calls_storage[call_record.entity_name] = {}
        if self.calls_storage[call_record.entity_name].get(
                call_record.method_name) is None:
            self.calls_storage[call_record.entity_name][
                call_record.method_name] = []
        self.calls_storage[call_record.entity_name][
            call_record.method_name].append({"call": call_record,
                                             "calls_count": self.calls_counter})

    def get_method_calls(self, entity_name, method_name):
        """
        Return calls
        Args:
            entity_name (str): name of entity
            method_name (str): name of method called on entity

        Returns:
            list: list of call objects  (CallRecord)

        """
        return self.calls_storage[entity_name][method_name]

    def add_call(self, entity_name, method_name, input_parms_list, output,
                 count):
        """Add and register call of function.

        Args:
            entity_name (str): name of entity
            method_name (str): name of method
            input_parms_list (list): list of arguments put to function
            output (object):  returned value by method_name
            count (int): number of count
        """
        call_record = CallRecord(entity_name, method_name, input_parms_list,
                                 output, count)
        self.register_call(call_record)


1			from tests.framework.calls.calls_record import CallRecord
			0 ignored issues – show Coding Style introduced 2016-10-15 17:37 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2
3
4			# pylint: disable=too-many-arguments
			0 ignored issues – show introduced 2016-10-15 17:37 UTC by Report Bug Copy Issue Report Locally disabling too-many-arguments (R0913) Loading history...
5
6
7			class CallsRegistry:
			0 ignored issues – show Coding Style introduced 2016-10-15 17:37 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
8			def __init__(self):
9			self.calls_storage = {}
10			self.calls_counter = 0
11
12			def register_call(self, call_record):
13			"""
14			Register call.
15			Args:
16			call_record (CallRecord): represent call
17			"""
18			self.calls_counter += 1
19			if self.calls_storage.get(call_record.entity_name) is None:
20			self.calls_storage[call_record.entity_name] = {}
21			if self.calls_storage[call_record.entity_name].get(
22			call_record.method_name) is None:
23			self.calls_storage[call_record.entity_name][
24			call_record.method_name] = []
25			self.calls_storage[call_record.entity_name][
26			call_record.method_name].append({"call": call_record,
27			"calls_count": self.calls_counter})
28
29			def get_method_calls(self, entity_name, method_name):
30			"""
31			Return calls
32			Args:
33			entity_name (str): name of entity
34			method_name (str): name of method called on entity
35
36			Returns:
37			list: list of call objects (CallRecord)
38
39			"""
40			return self.calls_storage[entity_name][method_name]
41
42			def add_call(self, entity_name, method_name, input_parms_list, output,
43			count):
44			"""Add and register call of function.
45
46			Args:
47			entity_name (str): name of entity
48			method_name (str): name of method
49			input_parms_list (list): list of arguments put to function
50			output (object): returned value by method_name
51			count (int): number of count
52			"""
53			call_record = CallRecord(entity_name, method_name, input_parms_list,
54			output, count)
55			self.register_call(call_record)
56

qbahn / grortir

Push — master ( aa0ea9...358d48 )

CallsRegistry A

Complexity

Size/Duplication

Importance

4 Methods

Duplication Side-by-Side

Filter issues like