grortir.main.model.processes.factories.CallsProcessFactory - Code Metrics - Inspection of "Implement Linear Calls process (in progress)" - qbahn/grortir - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#27)

by Wojtek

created 2016-03-29 22:40 UTC

grortir.main.model.processes.factories.CallsProcessFactory A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Metric	Value
dl	0
loc	29
rs	10
wmc	6

4 Methods

Rating	Name	Size	Complexity
A	_create_stages()	3	2
A	construct_process()	5	1
A	_update_structure()	3	2
A	__init__()	6	1

"""Contains factory class of process with calls stages."""

from main.model.processes.calls_process import CallsProcess
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from main.model.stages.calls_stage import CallsStage
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3


class CallsProcessFactory:
    """Class which produce process with the same type of stages.

    Attributes:
        structure_type (str): represent type of structure
        how_many_nodes (int): how many nodes should be in generated process
        process (CallsProcess): process which will be incrementally build
    """

    def __init__(self, structure_type, how_many_nodes):
        """Constructor."""
        self._stages_to_add = []
        self.structure_type = structure_type
        self.how_many_nodes = how_many_nodes
        self.process = CallsProcess()

    def _update_structure(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        if "linear" == self.structure_type:
            self.process.add_path(self._stages_to_add)

    def _create_stages(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        for i in range(self.how_many_nodes):

            self._stages_to_add += CallsStage()

    def construct_process(self):
        """Construct process."""
        self._create_stages()
        self._update_structure()
        return self.process


Pull Request — master (#27)

grortir.main.model.processes.factories.CallsProcessFactory A

Complexity

Size/Duplication

4 Methods

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1			"""Contains factory class of process with calls stages."""
2
3			from main.model.processes.calls_process import CallsProcess
			0 ignored issues – show Bug introduced 2016-03-29 22:40 UTC by Report Bug Copy Issue Report The name `model` does not seem to exist in module `main`. Loading history... Configuration introduced 2016-03-29 22:40 UTC by Report Bug Copy Issue Report The import `main.model.processes.calls_process` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
4			from main.model.stages.calls_stage import CallsStage
			0 ignored issues – show Bug introduced 2016-03-29 22:40 UTC by Report Bug Copy Issue Report The name `model` does not seem to exist in module `main`. Loading history... Configuration introduced 2016-03-29 22:40 UTC by Report Bug Copy Issue Report The import `main.model.stages.calls_stage` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
5
6
7			class CallsProcessFactory:
8			"""Class which produce process with the same type of stages.
9
10			Attributes:
11			structure_type (str): represent type of structure
12			how_many_nodes (int): how many nodes should be in generated process
13			process (CallsProcess): process which will be incrementally build
14			"""
15
16			def __init__(self, structure_type, how_many_nodes):
17			"""Constructor."""
18			self._stages_to_add = []
19			self.structure_type = structure_type
20			self.how_many_nodes = how_many_nodes
21			self.process = CallsProcess()
22
23			def _update_structure(self):
			0 ignored issues – show Coding Style introduced 2016-03-29 22:40 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
24			if "linear" == self.structure_type:
25			self.process.add_path(self._stages_to_add)
26
27			def _create_stages(self):
			0 ignored issues – show Coding Style introduced 2016-03-29 22:40 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
28			for i in range(self.how_many_nodes):
			0 ignored issues – show Unused Code introduced 2016-03-29 22:40 UTC by Report Bug Copy Issue Report The variable `i` seems to be unused. Loading history...
29			self._stages_to_add += CallsStage()
30
31			def construct_process(self):
32			"""Construct process."""
33			self._create_stages()
34			self._update_structure()
35			return self.process
36

qbahn / grortir

Pull Request — master (#27)

grortir.main.model.processes.factories.CallsProcessFactory A

Complexity

Size/Duplication

4 Methods

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files

2. Missing init.py files