pwweb / localisation

src/Controllers/Tax/RateController.php

<?php

namespace PWWEB\Localisation\Controllers\Tax;

use App\Http\Controllers\Controller;
use Flash;

The type Flash was not found. Maybe you did not declare it correctly or list all dependencies?

use Illuminate\Http\Request;
use PWWEB\Localisation\Enums\Tax\Type;
use PWWEB\Localisation\Repositories\Tax\RateRepository;
use PWWEB\Localisation\Requests\Tax\CreateRateRequest;
use PWWEB\Localisation\Requests\Tax\UpdateRateRequest;

/**
 * PWWEB\Localisation\Controllers\Tax\RateController RateController.
 *
 * The CRUD controller for Rate
 * Class RateController
 *
 * @author    Frank Pillukeit <frank.pillukeit@pw-websolutions.com>
 * @author    Richard Browne <richard.browne@pw-websolutions.com
 * @copyright 2020 pw-websolutions.com
 * @license   http://www.opensource.org/licenses/mit-license.html  MIT License
 */
class RateController extends Controller
{
    /**
     * Repository of rates to be used throughout the controller.
     *
     * @var \PWWEB\Localisation\Repositories\Tax\RateRepository
     */
    private $rateRepository;

    /**
     * Constructor for the Rate controller.
     *
     * @param RateRepository $rateRepo Repository of Rates.
     */
    public function __construct(RateRepository $rateRepo)
    {
        $this->rateRepository = $rateRepo;
    }

    /**
     * Display a listing of the Rate.
     *
     * @param Request $request Index request
     *
     * @return \Illuminate\View\View
     */
    public function index(Request $request)
    {
        $rates = $this->rateRepository->paginate(15);

        return view('localisation::tax.rates.index')
            ->with('rates', $rates);
    }

    /**
     * Show the form for creating a new Rate.
     *
     * @return \Illuminate\View\View
     */
    public function create()
    {
        $types = Type::getAll();

        return view('localisation::tax.rates.create', compact('types'));
    }

    /**
     * Store a newly created Rate in storage.
     *
     * @param CreateRateRequest $request Create Request
     *
     * @return \Illuminate\View\View
     */
    public function store(CreateRateRequest $request)
    {
        $input = $request->all();

        $rate = $this->rateRepository->create($input);

The assignment to $rate is dead and can be removed.

        Flash::success(__('pwweb::localisation.tax.rates.saved'));

        return redirect(route('localisation.tax.rates.index'));

The expression return redirect(route('localisation.tax.rates.index')) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\View\View.

    }

    /**
     * Display the specified Rate.
     *
     * @param int $id ID to show
     *
     * @return \Illuminate\View\View
     */
    public function show($id)
    {
        $rate = $this->rateRepository->find($id);
        $rate->type = Type::make($rate->type);

It seems like $rate->type can also be of type Illuminate\Database\Eloquent\Builder&Illuminate\Database\Eloquent\Relations\Relation and Illuminate\Database\Eloquent\Relations\Relation; however, parameter $value of Spatie\Enum\Enum::make() does only seem to accept integer|string, maybe add an additional type check?

        if (true === empty($rate)) {
            Flash::error(__('pwweb::localisation.tax.rates.not_found'));

            return redirect(route('localisation.tax.rates.index'));

The expression return redirect(route('localisation.tax.rates.index')) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\View\View.

        }

        return view('localisation::tax.rates.show')->with('rate', $rate);
    }

    /**
     * Show the form for editing the specified Rate.
     *
     * @param int $id ID to edit
     *
     * @return \Illuminate\View\View
     */
    public function edit($id)
    {
        $rate = $this->rateRepository->find($id);
        $types = Type::getAll();

        if (true === empty($rate)) {
            Flash::error(__('pwweb::localisation.tax.rates.not_found'));

            return redirect(route('localisation.tax.rates.index'));

The expression return redirect(route('localisation.tax.rates.index')) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\View\View.

        }

        return view('localisation::tax.rates.edit', compact('rate', 'types'));
    }

    /**
     * Update the specified Rate in storage.
     *
     * @param int               $id      ID to update
     * @param UpdateRateRequest $request Edit Request
     *
     * @return \Illuminate\View\View
     */
    public function update($id, UpdateRateRequest $request)
    {
        $rate = $this->rateRepository->find($id);

        if (true === empty($rate)) {
            Flash::error(__('pwweb::localisation.tax.rates.not_found'));

            return redirect(route('localisation.tax.rates.index'));

The expression return redirect(route('localisation.tax.rates.index')) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\View\View.

        }

        $rate = $this->rateRepository->update($request->all(), $id);

The assignment to $rate is dead and can be removed.

        Flash::success(__('pwweb::localisation.tax.rates.updated'));

        return redirect(route('localisation.tax.rates.index'));

The expression return redirect(route('localisation.tax.rates.index')) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\View\View.

    }

    /**
     * Remove the specified Rate from storage.
     *
     * @param int $id ID to destroy
     *
     * @throws \Exception
     *
     * @return \Illuminate\View\View
     */
    public function destroy($id)
    {
        $rate = $this->rateRepository->find($id);

        if (true === empty($rate)) {
            Flash::error(__('pwweb::localisation.tax.rates.not_found'));

            return redirect(route('localisation.tax.rates.index'));

The expression return redirect(route('localisation.tax.rates.index')) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\View\View.

        }

        $this->rateRepository->delete($id);

        Flash::success(__('pwweb::localisation.tax.rates.deleted'));

        return redirect(route('localisation.tax.rates.index'));

The expression return redirect(route('localisation.tax.rates.index')) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\View\View.

    }
}