RollbackGeneratorCommand::handle() - Code Metrics - Inspection of "Merge branch 'develop' ready for v0.3.0-beta" - pwweb/artomator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 9de3df...49c81a )

by Richard

created 2020-04-02 17:08 UTC

RollbackGeneratorCommand::handle() A

↳ Parent: RollbackGeneratorCommand

Complexity

Conditions	4
Paths	6

Size

Total Lines	44
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
eloc	28
c	4
b	0
f	0
dl	0
loc	44
rs	9.472
cc	4
nc	6
nop	0

<?php

namespace PWWEB\Artomator\Commands;

use Illuminate\Console\Command;
use Illuminate\Support\Composer;
use InfyOm\Generator\Commands\RollbackGeneratorCommand as Base;
use InfyOm\Generator\Generators\Scaffold\ViewGenerator;
use PWWEB\Artomator\Common\CommandData;
use PWWEB\Artomator\Generators\GraphQL\GraphQLMutationGenerator;
use PWWEB\Artomator\Generators\GraphQL\GraphQLQueryGenerator;
use PWWEB\Artomator\Generators\GraphQL\GraphQLSubscriptionGenerator;
use PWWEB\Artomator\Generators\GraphQL\GraphQLTypeGenerator;

class RollbackGeneratorCommand extends Base
{
    /**
     * The command Data.
     *
     * @var CommandData
     */
    public $commandData;
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'artomator:rollback';

    /**
     * @var Composer
     */
    public $composer;

    /**
     * Create a new command instance.
     */
    public function __construct()
    {
        parent::__construct();

        $this->composer = app()['composer'];
    }

    /**
     * Execute the command.
     *
     * @return void
     */
    public function handle()
    {
        if (false === in_array($this->argument('type'), [
            CommandData::$COMMAND_TYPE_API,
            CommandData::$COMMAND_TYPE_SCAFFOLD,
            CommandData::$COMMAND_TYPE_API_SCAFFOLD,
            CommandData::$COMMAND_TYPE_GRAPHQL,
            CommandData::$COMMAND_TYPE_GRAPHQL_SCAFFOLD,
        ])) {
            $this->error('invalid rollback type');
        }

        $this->commandData = new CommandData($this, $this->argument('type'));
        $this->commandData->config->mName = $this->commandData->modelName = $this->argument('model');
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        $this->commandData->config->init($this->commandData, ['tableName', 'prefix', 'plural', 'views']);

        $views = $this->commandData->getOption('views');
        if (false === empty($views)) {
            $views = explode(',', $views);
            $viewGenerator = new ViewGenerator($this->commandData);
            $viewGenerator->rollback($views);

            $this->info('Generating autoload files');
            $this->composer->dumpOptimized();

            return;
        }

        $typeGenerator = new GraphQLTypeGenerator($this->commandData);
        $typeGenerator->rollback();

        $queryGenerator = new GraphQLQueryGenerator($this->commandData);
        $queryGenerator->rollback();

        $mutationGenerator = new GraphQLMutationGenerator($this->commandData);
        $mutationGenerator->rollback();

        if (config('pwweb.artomator.options.subscription')) {
            $subscriptionGenerator = new GraphQLSubscriptionGenerator($this->commandData);
            $subscriptionGenerator->rollback();
        }

        parent::handle();
    }
}


1			<?php
2
3			namespace PWWEB\Artomator\Commands;
4
5			use Illuminate\Console\Command;
6			use Illuminate\Support\Composer;
7			use InfyOm\Generator\Commands\RollbackGeneratorCommand as Base;
8			use InfyOm\Generator\Generators\Scaffold\ViewGenerator;
9			use PWWEB\Artomator\Common\CommandData;
10			use PWWEB\Artomator\Generators\GraphQL\GraphQLMutationGenerator;
11			use PWWEB\Artomator\Generators\GraphQL\GraphQLQueryGenerator;
12			use PWWEB\Artomator\Generators\GraphQL\GraphQLSubscriptionGenerator;
13			use PWWEB\Artomator\Generators\GraphQL\GraphQLTypeGenerator;
14
15			class RollbackGeneratorCommand extends Base
16			{
17			/**
18			* The command Data.
19			*
20			* @var CommandData
21			*/
22			public $commandData;
23			/**
24			* The console command name.
25			*
26			* @var string
27			*/
28			protected $name = 'artomator:rollback';
29
30			/**
31			* @var Composer
32			*/
33			public $composer;
34
35			/**
36			* Create a new command instance.
37			*/
38			public function __construct()
39			{
40			parent::__construct();
41
42			$this->composer = app()['composer'];
43			}
44
45			/**
46			* Execute the command.
47			*
48			* @return void
49			*/
50			public function handle()
51			{
52			if (false === in_array($this->argument('type'), [
53			CommandData::$COMMAND_TYPE_API,
54			CommandData::$COMMAND_TYPE_SCAFFOLD,
55			CommandData::$COMMAND_TYPE_API_SCAFFOLD,
56			CommandData::$COMMAND_TYPE_GRAPHQL,
57			CommandData::$COMMAND_TYPE_GRAPHQL_SCAFFOLD,
58			])) {
59			$this->error('invalid rollback type');
60			}
61
62			$this->commandData = new CommandData($this, $this->argument('type'));
63			$this->commandData->config->mName = $this->commandData->modelName = $this->argument('model');
			0 ignored issues – show Documentation Bug introduced 2020-03-29 14:19 UTC by Report Bug Copy Issue Report It seems like `$this->argument('model')` can also be of type `string[]`. However, the property `$modelName` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
64
65			$this->commandData->config->init($this->commandData, ['tableName', 'prefix', 'plural', 'views']);
66
67			$views = $this->commandData->getOption('views');
68			if (false === empty($views)) {
69			$views = explode(',', $views);
70			$viewGenerator = new ViewGenerator($this->commandData);
71			$viewGenerator->rollback($views);
72
73			$this->info('Generating autoload files');
74			$this->composer->dumpOptimized();
75
76			return;
77			}
78
79			$typeGenerator = new GraphQLTypeGenerator($this->commandData);
80			$typeGenerator->rollback();
81
82			$queryGenerator = new GraphQLQueryGenerator($this->commandData);
83			$queryGenerator->rollback();
84
85			$mutationGenerator = new GraphQLMutationGenerator($this->commandData);
86			$mutationGenerator->rollback();
87
88			if (config('pwweb.artomator.options.subscription')) {
89			$subscriptionGenerator = new GraphQLSubscriptionGenerator($this->commandData);
90			$subscriptionGenerator->rollback();
91			}
92
93			parent::handle();
94			}
95			}
96

pwweb / artomator

Push — master ( 9de3df...49c81a )

RollbackGeneratorCommand::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like