Puzzle\QueryBuilder\Queries\Snippets\Having

Complexity

Total Complexity

5

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	having()	0	6	1
A	toString()	0	9	2
A	addCondition()	0	4	1

<?php

declare(strict_types = 1);

namespace Puzzle\QueryBuilder\Queries\Snippets;

use Puzzle\QueryBuilder\Snippet;
use Puzzle\QueryBuilder\Condition;
use Puzzle\QueryBuilder\Conditions;
use Puzzle\QueryBuilder\Traits\EscaperAware;
use Puzzle\QueryBuilder\Escaper;

class Having implements Snippet
{
    use
        EscaperAware;

    private
        $condition;

The visibility should be declared for property $condition.

    public function __construct()
    {
        $this->condition = new Conditions\NullCondition();
    }

    public function having(Condition $condition): self
    {
        $this->addCondition($condition);

        return $this;
    }

    public function toString(): string
    {
        if($this->condition->isEmpty())
        {
            return '';
        }

        return sprintf('HAVING %s', $this->condition->toString($this->escaper));
    }

    private function addCondition(Condition $condition): void
    {
        $this->condition = $this->condition->and($condition);

The method and does not exist on object<Puzzle\QueryBuilder\Conditions\NullCondition>? Since you implemented __call, maybe consider adding a @method annotation.

    }
}