Puzzle\QueryBuilder\Conditions\Between

Complexity

Total Complexity

9

Size/Duplication

Total Lines	53
Duplicated Lines	20.75 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	toString()	0	14	2
A	isEmpty()	0	11	4
A	escapeValue()	11	11	2

<?php

declare(strict_types = 1);

namespace Puzzle\QueryBuilder\Conditions;

use Puzzle\QueryBuilder\Conditions\AbstractCondition;
use Puzzle\QueryBuilder\Escaper;
use Puzzle\QueryBuilder\Type;

class Between extends AbstractCondition
{
    protected
        $column,

It is generally advisable to only define one property per statement.

The visibility should be declared for property $column.

        $start,
        $end;

    public function __construct(Type $column, $start, $end)
    {
        $this->column = $column;
        $this->start = $start;
        $this->end = $end;
    }

    public function toString(Escaper $escaper): string
    {
        if($this->isEmpty())
        {
            return '';
        }

        return sprintf(
            '%s BETWEEN %s AND %s',
            $this->column->getName(),
            $this->escapeValue($this->start, $escaper),
            $this->escapeValue($this->end, $escaper)
        );
    }

    public function isEmpty(): bool
    {
        $columnName = $this->column->getName();

        if(empty($columnName) || empty($this->start) || empty($this->end))
        {
            return true;
        }

        return false;
    }

    private function escapeValue($value, Escaper $escaper)

This method seems to be duplicated in your project.

    {
        $value = $this->column->format($value);

        if($this->column->isEscapeRequired())
        {
            $value = $escaper->escape($value);
        }

        return $value;
    }
}