Puzzle\AMQP\Messages\Bodies\StreamedFile

Complexity

Total Complexity

11

Size/Duplication

Total Lines	81
Duplicated Lines	13.58 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	1
A	ensureFilepathIsValid()	0	7	3
A	inOriginalFormat()	0	4	1
B	asTransported()	11	26	3
A	getContentType()	0	4	1
A	__toString()	0	7	1
A	isChunked()	0	4	1

<?php

namespace Puzzle\AMQP\Messages\Bodies;

use Puzzle\AMQP\Messages\Body;
use Puzzle\AMQP\Messages\Chunks\Chunk;
use Puzzle\AMQP\Messages\Chunks\ChunkedMessageMetadata;
use Puzzle\ValueObjects\Uuid;
use Puzzle\AMQP\Messages\ContentType;
use Puzzle\AMQP\Messages\Chunks\ChunkSize;

class StreamedFile implements Body
{
    private
        $filepath,
        $chunkSize,
        $metadata;

    public function __construct($filepath, ChunkSize $chunkSize = null)
    {
        $this->ensureFilepathIsValid($filepath);

        $this->filepath = $filepath;
        $this->chunkSize = $chunkSize;

        $size = filesize($filepath);
        $nbChunks = (int) ceil($size / $chunkSize->toBytes());

It seems like $chunkSize is not always an object, but can also be of type null. Maybe add an additional type check?

        $this->metadata = new ChunkedMessageMetadata(new Uuid(), $size, $nbChunks, sha1_file($filepath));
    }

    private function ensureFilepathIsValid($filepath)
    {
        if(is_file($filepath) === false || is_readable($filepath) === false)
        {
            throw new \InvalidArgumentException("Cannot read $filepath");
        }
    }

    public function inOriginalFormat()
    {
        return file_get_contents($this->filepath);
    }

    /**
     * @return \Generator|string

Consider making the return type a bit more specific; maybe use \Generator.

     */
    public function asTransported()
    {
        if($this->isChunked() === false)
        {
            return $this->inOriginalFormat();

The return type of return $this->inOriginalFormat(); (string) is incompatible with the return type documented by Puzzle\AMQP\Messages\Bodies\StreamedFile::asTransported of type Generator.

        }

        $offset = 0;
        $playhead = 0;

        $stream = fopen($this->filepath, 'r');

        while(! feof($stream))

This code seems to be duplicated across your project.

        {
            $content = fread($stream, $this->chunkSize->toBytes());
            $playhead++;

            $chunk = new Chunk($playhead, $offset, $content, $this->metadata);
            yield $chunk;

            $offset += $chunk->size();
            unset($chunk, $content);
        }

        fclose($stream);
    }

    public function getContentType()
    {
        return ContentType::BINARY;
    }

    public function __toString()
    {
        return sprintf(
            '<binary stream of %d bytes>',
            filesize($this->filepath)
        );
    }

    public function isChunked()
    {
        return $this->chunkSize instanceof ChunkSize;
    }
}