BodySetter::setStreamedFile() - Code Metrics - Inspection of "refactor(chunks): chunked message must be publishe..." - puzzle-org/amqp - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#42)

by Nicolas

created 2017-10-17 10:19 UTC

BodySetter::setStreamedFile() A

↳ Parent: BodySetter

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	13
ccs	7
cts	7
cp	1
rs	9.4285
cc	1
eloc	7
nc	1
nop	2
crap	1

<?php

namespace Puzzle\AMQP\Messages;

use Puzzle\AMQP\Messages\Bodies\Text;
use Puzzle\AMQP\Messages\Bodies\Json;
use Puzzle\AMQP\Messages\Bodies\Binary;
use Puzzle\AMQP\Messages\Chunks\ChunkSize;
use Puzzle\AMQP\Messages\Bodies\StreamedFile;
use Puzzle\AMQP\Messages\Bodies\StreamedBinary;

trait BodySetter
{
    public function setText($text)
    {
        $this->setBody(new Text($text));

        return $this;
    }

    public function setJson(array $content)
    {
        $this->setBody(new Json($content));

        return $this;
    }

    public function setBinary($content)
    {
        $this->setBody(new Binary($content));

        return $this;
    }

    public function setStreamedFile($filepath, ChunkSize $size = null)
    {
        $this->setBody(new StreamedFile($filepath, $size));

        $this->addHeaders([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            'file' => [
                'path' => dirname($filepath),
                'filename' => basename($filepath),
            ]
        ]);

        return $this;
    }

    public function setStreamedBinary($content, ChunkSize $size)
    {
        $this->setBody(new StreamedBinary($content, $size));

        return $this;
    }

    abstract public function setBody(Body $body);
}


1		<?php
2
3		namespace Puzzle\AMQP\Messages;
4
5		use Puzzle\AMQP\Messages\Bodies\Text;
6		use Puzzle\AMQP\Messages\Bodies\Json;
7		use Puzzle\AMQP\Messages\Bodies\Binary;
8		use Puzzle\AMQP\Messages\Chunks\ChunkSize;
9		use Puzzle\AMQP\Messages\Bodies\StreamedFile;
10		use Puzzle\AMQP\Messages\Bodies\StreamedBinary;
11
12		trait BodySetter
13		{
14	5	public function setText($text)
15		{
16	5	$this->setBody(new Text($text));
17
18	5	return $this;
19		}
20
21	3	public function setJson(array $content)
22		{
23	3	$this->setBody(new Json($content));
24
25	3	return $this;
26		}
27
28	3	public function setBinary($content)
29		{
30	3	$this->setBody(new Binary($content));
31
32	3	return $this;
33		}
34
35	2	public function setStreamedFile($filepath, ChunkSize $size = null)
36		{
37	2	$this->setBody(new StreamedFile($filepath, $size));
38
39	2	$this->addHeaders([
		0 ignored issues – show Bug introduced 2017-09-22 16:36 UTC by Report Bug Copy Issue Report It seems like `addHeaders()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
40		'file' => [
41	2	'path' => dirname($filepath),
42	2	'filename' => basename($filepath),
43		]
44	2	]);
45
46	2	return $this;
47		}
48
49	1	public function setStreamedBinary($content, ChunkSize $size)
50		{
51	1	$this->setBody(new StreamedBinary($content, $size));
52
53	1	return $this;
54		}
55
56		abstract public function setBody(Body $body);
57		}
58

puzzle-org / amqp

Pull Request — master (#42)

BodySetter::setStreamedFile() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like