InMemoryJson::getRoutingKeyFromHeader() - Code Metrics - Inspection of "fix(messages): reading routing key from headers is..." - puzzle-org/amqp - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#7)

by Nicolas

created 2017-03-10 09:55 UTC

InMemoryJson::getRoutingKeyFromHeader() A

↳ Parent: InMemoryJson

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
dl	11
loc	11
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	0

<?php

namespace Puzzle\AMQP\Messages;

use Puzzle\AMQP\ReadableMessage;
use Puzzle\AMQP\WritableMessage;
use Puzzle\AMQP\Collections\MessageHookCollection;

class InMemoryJson extends Json implements ReadableMessage, WritableMessage
{
    public function getRawBody()
    {
        return $this->getFormattedBody();
    }
    
    public function getDecodedBody()
    {
        return $this->body;
    }
    
    public function getAttributes()
    {
        return $this->packAttributes();
    }
    
    public function isLastRetry($retryOccurence = \Puzzle\AMQP\Consumers\Retry::DEFAULT_RETRY_OCCURENCE)
    {
        $retryHeader = $this->getHeader(\Puzzle\AMQP\Consumers\Retry::DEFAULT_RETRY_HEADER);

        
        return (!empty($retryHeader) && (int) $retryHeader === $retryOccurence);
    }
    
    public function applyHooks(MessageHookCollection $messageHookCollection)
    {
        
    }
    
    public function getRoutingKeyFromHeader()

    {
        $headers = $this->getHeaders();
        
        if(! array_key_exists('routing_key', $headers))
        {
            return null;
        }
        
        return $headers['routing_key'];
    }
}


1		<?php
2
3		namespace Puzzle\AMQP\Messages;
4
5		use Puzzle\AMQP\ReadableMessage;
6		use Puzzle\AMQP\WritableMessage;
7		use Puzzle\AMQP\Collections\MessageHookCollection;
8
9		class InMemoryJson extends Json implements ReadableMessage, WritableMessage
10		{
11		public function getRawBody()
12		{
13		return $this->getFormattedBody();
14		}
15
16		public function getDecodedBody()
17		{
18		return $this->body;
19		}
20
21		public function getAttributes()
22		{
23		return $this->packAttributes();
24		}
25
26		public function isLastRetry($retryOccurence = \Puzzle\AMQP\Consumers\Retry::DEFAULT_RETRY_OCCURENCE)
27		{
28		$retryHeader = $this->getHeader(\Puzzle\AMQP\Consumers\Retry::DEFAULT_RETRY_HEADER);
		0 ignored issues – show Bug introduced 2017-03-09 13:53 UTC by Report Bug Copy Issue Report The method `getHeader()` does not exist on `Puzzle\AMQP\Messages\InMemoryJson`. Did you maybe mean `getHeaders()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
29
30		return (!empty($retryHeader) && (int) $retryHeader === $retryOccurence);
31		}
32
33		public function applyHooks(MessageHookCollection $messageHookCollection)
34		{
35
36		}
37
38	View Code Duplication	public function getRoutingKeyFromHeader()
		0 ignored issues – show Duplication introduced 2017-03-09 18:22 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
39		{
40		$headers = $this->getHeaders();
41
42		if(! array_key_exists('routing_key', $headers))
43		{
44		return null;
45		}
46
47		return $headers['routing_key'];
48		}
49		}
50

puzzle-org / amqp

Pull Request — master (#7)

InMemoryJson::getRoutingKeyFromHeader() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like