MessageAdapter::isBinary() - Code Metrics - Inspection of "feat(messages): handle binary messages" - puzzle-org/amqp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

by Nicolas

created 2017-03-13 09:26 UTC

MessageAdapter::isBinary() A

↳ Parent: MessageAdapter

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace Puzzle\AMQP\Workers;

use Psr\Log\InvalidArgumentException;
use Puzzle\AMQP\ReadableMessage;
use Puzzle\AMQP\Collections\MessageHookCollection;
use Puzzle\AMQP\Hooks\MessageHook;
use Puzzle\AMQP\Messages\ContentType;

class MessageAdapter implements ReadableMessage
{
    private
        $message,
class A {
    var $property;
}
        $decodedBody,
        $messageHooks;


    public function __construct(\Swarrot\Broker\Message $message)
    {
        $this->message = $message;
        $this->decodedBody = $this->decodeBody();
    }

    public function getRoutingKey()
    {
        return $this->getAttribute('routing_key');
    }

    public function getContentType()
    {
        return $this->getAttribute('content_type');
    }

    public function getAppId()
    {
        return $this->getAttribute('app_id');
    }

    public function getHeaders()
    {
        return $this->getAttribute('headers');
    }

    public function getDecodedBody()
    {
        return $this->decodedBody;
    }

    private function decodeBody()
    {
        $callable = $this->getFormatterStrategy($this->getContentType());
        $body = $this->getRawBody();

        if($callable instanceof \Closure)
        {
            $body = $callable($body);
        }

        return $body;
    }

    public function getRawBody()
    {
        return $this->message->getBody();
    }

    public function applyHooks(MessageHookCollection $messageHookCollection)
    {
        if(!empty($messageHookCollection))
        {
            foreach($messageHookCollection as $messageHook)
            {
                if($messageHook instanceof MessageHook)
                {
                    $this->decodedBody = $messageHook->process($this->decodedBody);
                }
            }
        }
    }

    public function getFlags()
    {
        throw new \LogicException('Consumed messages have no flags');
    }

    public function getAttribute($attributeName)
    {
        $messageProperties = $this->message->getProperties();
        if(array_key_exists($attributeName, $messageProperties))
        {
            return $messageProperties[$attributeName];
        }

        throw new InvalidArgumentException(sprintf('Property "%s" is unknown or is not a message property', $attributeName));
    }

    private function getFormatterStrategy($contentType)
    {
        $formatterStrategies = array(
            ContentType::JSON => function($body) {
                return json_decode($body, true);
            },
        );

        if(array_key_exists($contentType, $formatterStrategies) === true)
        {
            return $formatterStrategies[$contentType];
        }
    }
    
    public function __toString()
    {
        return json_encode(array(
            'routing_key' => $this->getRoutingKey(),
            'body' => $this->bodyToString(),
            'attributes' => $this->message->getProperties(),
        ));
    }
    
    private function isBinary()
    {
        $this->getContentType() === ContentType::BINARY;
    }

    private function bodyToString()
    {
        if($this->isBinary())
        {
            return sprintf('<binary stream of %d bytes>', strlen($this->getRawBody()));
        }
        
        return $this->getRawBody();
    }

    public function getService()
    {
        return $this->getHeader('service');
    }

    public function getAction()
    {
        return $this->getHeader('action');
    }

    public function getAuthor()
    {
        return $this->getHeader('author');
    }

    private function getHeader($headerName)
    {
        $headers = $this->getHeaders();
        if(array_key_exists($headerName, $headers))
        {
            return $headers[$headerName];
        }

        return null;
    }

    public function getAttributes()
    {
        return $this->message->getProperties();
    }

    public function isLastRetry($retryOccurence = \Puzzle\AMQP\Consumers\Retry::DEFAULT_RETRY_OCCURENCE)
    {
        $retryHeader = $this->getHeader(\Puzzle\AMQP\Consumers\Retry::DEFAULT_RETRY_HEADER);

        return (!empty($retryHeader) && (int) $retryHeader === $retryOccurence);
    }

    public function getRoutingKeyFromHeader()

    {
        $headers = $this->getHeaders();

        if(! array_key_exists('routing_key', $headers))
        {
            return null;
        }

        return $headers['routing_key'];
    }
}


1		<?php
2
3		namespace Puzzle\AMQP\Workers;
4
5		use Psr\Log\InvalidArgumentException;
6		use Puzzle\AMQP\ReadableMessage;
7		use Puzzle\AMQP\Collections\MessageHookCollection;
8		use Puzzle\AMQP\Hooks\MessageHook;
9		use Puzzle\AMQP\Messages\ContentType;
10
11		class MessageAdapter implements ReadableMessage
12		{
13		private
14		$message,
		1 ignored issue – show Coding Style introduced 2017-03-09 13:53 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$message`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
15		$decodedBody,
16		$messageHooks;
		0 ignored issues – show Unused Code introduced 2017-03-09 13:53 UTC by Report Bug Copy Issue Report The property `$messageHooks` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
17
18		public function __construct(\Swarrot\Broker\Message $message)
19		{
20		$this->message = $message;
21		$this->decodedBody = $this->decodeBody();
22		}
23
24		public function getRoutingKey()
25		{
26		return $this->getAttribute('routing_key');
27		}
28
29		public function getContentType()
30		{
31		return $this->getAttribute('content_type');
32		}
33
34		public function getAppId()
35		{
36		return $this->getAttribute('app_id');
37		}
38
39		public function getHeaders()
40		{
41		return $this->getAttribute('headers');
42		}
43
44		public function getDecodedBody()
45		{
46		return $this->decodedBody;
47		}
48
49		private function decodeBody()
50		{
51		$callable = $this->getFormatterStrategy($this->getContentType());
52		$body = $this->getRawBody();
53
54		if($callable instanceof \Closure)
55		{
56		$body = $callable($body);
57		}
58
59		return $body;
60		}
61
62		public function getRawBody()
63		{
64		return $this->message->getBody();
65		}
66
67		public function applyHooks(MessageHookCollection $messageHookCollection)
68		{
69		if(!empty($messageHookCollection))
70		{
71		foreach($messageHookCollection as $messageHook)
72		{
73		if($messageHook instanceof MessageHook)
74		{
75		$this->decodedBody = $messageHook->process($this->decodedBody);
76		}
77		}
78		}
79		}
80
81		public function getFlags()
82		{
83		throw new \LogicException('Consumed messages have no flags');
84		}
85
86		public function getAttribute($attributeName)
87		{
88		$messageProperties = $this->message->getProperties();
89		if(array_key_exists($attributeName, $messageProperties))
90		{
91		return $messageProperties[$attributeName];
92		}
93
94		throw new InvalidArgumentException(sprintf('Property "%s" is unknown or is not a message property', $attributeName));
95		}
96
97		private function getFormatterStrategy($contentType)
98		{
99		$formatterStrategies = array(
100		ContentType::JSON => function($body) {
101		return json_decode($body, true);
102		},
103		);
104
105		if(array_key_exists($contentType, $formatterStrategies) === true)
106		{
107		return $formatterStrategies[$contentType];
108		}
109		}
110
111		public function __toString()
112		{
113		return json_encode(array(
114		'routing_key' => $this->getRoutingKey(),
115		'body' => $this->bodyToString(),
116		'attributes' => $this->message->getProperties(),
117		));
118		}
119
120		private function isBinary()
121		{
122		$this->getContentType() === ContentType::BINARY;
123		}
124
125		private function bodyToString()
126		{
127		if($this->isBinary())
128		{
129		return sprintf('<binary stream of %d bytes>', strlen($this->getRawBody()));
130		}
131
132		return $this->getRawBody();
133		}
134
135		public function getService()
136		{
137		return $this->getHeader('service');
138		}
139
140		public function getAction()
141		{
142		return $this->getHeader('action');
143		}
144
145		public function getAuthor()
146		{
147		return $this->getHeader('author');
148		}
149
150		private function getHeader($headerName)
151		{
152		$headers = $this->getHeaders();
153		if(array_key_exists($headerName, $headers))
154		{
155		return $headers[$headerName];
156		}
157
158		return null;
159		}
160
161		public function getAttributes()
162		{
163		return $this->message->getProperties();
164		}
165
166		public function isLastRetry($retryOccurence = \Puzzle\AMQP\Consumers\Retry::DEFAULT_RETRY_OCCURENCE)
167		{
168		$retryHeader = $this->getHeader(\Puzzle\AMQP\Consumers\Retry::DEFAULT_RETRY_HEADER);
169
170		return (!empty($retryHeader) && (int) $retryHeader === $retryOccurence);
171		}
172
173	View Code Duplication	public function getRoutingKeyFromHeader()
		0 ignored issues – show Duplication introduced 2017-03-09 18:22 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
174		{
175		$headers = $this->getHeaders();
176
177		if(! array_key_exists('routing_key', $headers))
178		{
179		return null;
180		}
181
182		return $headers['routing_key'];
183		}
184		}
185

puzzle-org / amqp

Pull Request — master (#9)

MessageAdapter::isBinary() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like