StreamedFile::__toString() - Code Metrics - Inspection of "refactor(chunks): chunked message must be publishe..." - puzzle-org/amqp - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#42)

by Nicolas

created 2017-10-16 10:35 UTC

StreamedFile::__toString() A

↳ Parent: StreamedFile

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	0
cts	7
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	0
crap	2

<?php

namespace Puzzle\AMQP\Messages\Bodies;

use Puzzle\AMQP\Messages\Body;
use Puzzle\AMQP\Messages\Chunks\Chunk;
use Puzzle\AMQP\Messages\Chunks\ChunkedMessageMetadata;
use Puzzle\ValueObjects\Uuid;
use Puzzle\AMQP\Messages\ContentType;
use Puzzle\AMQP\Messages\Chunks\ChunkSize;

class StreamedFile implements Body
{
    private
        $filepath,
        $chunkSize,
        $metadata;

    public function __construct($filepath, ChunkSize $chunkSize = null)
    {
        $this->ensureFilepathIsValid($filepath);

        $this->filepath = $filepath;
        $this->chunkSize = $chunkSize;

        $size = filesize($filepath);
        $nbChunks = (int) ceil($size / $chunkSize->toBytes());
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}

        $this->metadata = new ChunkedMessageMetadata(new Uuid(), $size, $nbChunks, sha1_file($filepath));
    }

    private function ensureFilepathIsValid($filepath)
    {
        if(is_file($filepath) === false || is_readable($filepath) === false)
        {
            throw new \InvalidArgumentException("Cannot read $filepath");
        }
    }

    public function inOriginalFormat()
    {
        return file_get_contents($this->filepath);
    }

    /**
     * @return \Generator|string

     */
    public function asTransported()
    {
        if($this->isChunked() === false)
        {
            return $this->inOriginalFormat();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $offset = 0;
        $playhead = 0;

        $stream = fopen($this->filepath, 'r');

        while(! feof($stream))

        {
            $content = fread($stream, $this->chunkSize->toBytes());
            $playhead++;

            $chunk = new Chunk($playhead, $offset, $content, $this->metadata);
            yield $chunk;

            $offset += $chunk->size();
            unset($chunk, $content);
        }

        fclose($stream);
    }

    public function getContentType()
    {
        return ContentType::BINARY;
    }

    public function __toString()
    {
        return sprintf(
            '<binary stream of %d bytes>',
            filesize($this->filepath)
        );
    }

    public function isChunked()
    {
        return $this->chunkSize instanceof ChunkSize;
    }
}


1		<?php
2
3		namespace Puzzle\AMQP\Messages\Bodies;
4
5		use Puzzle\AMQP\Messages\Body;
6		use Puzzle\AMQP\Messages\Chunks\Chunk;
7		use Puzzle\AMQP\Messages\Chunks\ChunkedMessageMetadata;
8		use Puzzle\ValueObjects\Uuid;
9		use Puzzle\AMQP\Messages\ContentType;
10		use Puzzle\AMQP\Messages\Chunks\ChunkSize;
11
12		class StreamedFile implements Body
13		{
14		private
15		$filepath,
16		$chunkSize,
17		$metadata;
18
19		public function __construct($filepath, ChunkSize $chunkSize = null)
20		{
21		$this->ensureFilepathIsValid($filepath);
22
23		$this->filepath = $filepath;
24		$this->chunkSize = $chunkSize;
25
26		$size = filesize($filepath);
27		$nbChunks = (int) ceil($size / $chunkSize->toBytes());
		0 ignored issues – show Bug introduced 2017-10-16 10:42 UTC by Report Bug Copy Issue Report It seems like `$chunkSize` is not always an object, but can also be of type `null`. Maybe add an additional type check? If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: function someFunction(A $objectMaybe = null) { if ($objectMaybe instanceof A) { $objectMaybe->doSomething(); } } Loading history...
28
29		$this->metadata = new ChunkedMessageMetadata(new Uuid(), $size, $nbChunks, sha1_file($filepath));
30		}
31
32		private function ensureFilepathIsValid($filepath)
33		{
34		if(is_file($filepath) === false \|\| is_readable($filepath) === false)
35		{
36		throw new \InvalidArgumentException("Cannot read $filepath");
37		}
38		}
39
40		public function inOriginalFormat()
41		{
42		return file_get_contents($this->filepath);
43		}
44
45		/**
46		* @return \Generator\|string
		0 ignored issues – show Documentation introduced 2017-10-16 10:42 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `\Generator`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
47		*/
48		public function asTransported()
49		{
50		if($this->isChunked() === false)
51		{
52		return $this->inOriginalFormat();
		0 ignored issues – show Bug Best Practice introduced 2017-10-16 10:42 UTC by Report Bug Copy Issue Report The return type of `return $this->inOriginalFormat();` (`string`) is incompatible with the return type documented by `Puzzle\AMQP\Messages\Bod...amedFile::asTransported` of type `Generator`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
53		}
54
55		$offset = 0;
56		$playhead = 0;
57
58		$stream = fopen($this->filepath, 'r');
59
60	View Code Duplication	while(! feof($stream))
		0 ignored issues – show Duplication introduced 2017-09-22 16:36 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61		{
62		$content = fread($stream, $this->chunkSize->toBytes());
63		$playhead++;
64
65		$chunk = new Chunk($playhead, $offset, $content, $this->metadata);
66		yield $chunk;
67
68		$offset += $chunk->size();
69		unset($chunk, $content);
70		}
71
72		fclose($stream);
73		}
74
75		public function getContentType()
76		{
77		return ContentType::BINARY;
78		}
79
80		public function __toString()
81		{
82		return sprintf(
83		'<binary stream of %d bytes>',
84		filesize($this->filepath)
85		);
86		}
87
88		public function isChunked()
89		{
90		return $this->chunkSize instanceof ChunkSize;
91		}
92		}
93

puzzle-org / amqp

Pull Request — master (#42)

StreamedFile::__toString() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like