NewsHolder

Complexity

Total Complexity

6

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	17	2
A	getLumberjackTitle()	0	4	1
A	getLumberjackPagesForGridfield()	0	7	1
A	stageChildren()	0	4	1
A	init()	0	5	1

<?php

class NewsHolder extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $intro = null;

        $this->beforeUpdateCMSFields(function ($fields) {
            $fields->renameField("Content", "Intro Content");
      $fields->insertBefore(new Tab($this->getLumberjackTitle()), 'Main');
        });

        $fields = parent::getCMSFields();

        if ($intro) {
            $intro->setRightTitle("Appears at the top of the main ".$this->Title." page, above the list of articles.");
        }

        return $fields;
    }

    public function getLumberjackTitle()
    {
        return "News Articles";
    }
    
    public function getLumberjackPagesForGridfield($excluded = array())

The return type could not be reliably inferred; please add a @return annotation.

  	{
  			return NewsArticle::get()->filter(array(
  					'ParentID' => $this->ID,
  					'ClassName' => $excluded,
  			));
  	}

    // Only allows certain children to be created
    private static $allowed_children = array('NewsArticle');

The property $allowed_children is not used and could be removed.

    private static $description = 'Holds News Article pages';

The property $description is not used and could be removed.

    private static $icon = "basic-news/images/newspaper-page";

The property $icon is not used and could be removed.

    
    public function stageChildren($showAll = false)

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->__call('stageChildren', array($showAll))->sort(array('MenuTitle'=>'DESC', "Created"=>'DESC'));
    }

    public function init()
    {
        RSSFeed::linkToFeed($this->Link("rss"), "News RSS Feed");
        parent::init();
    }
}


class NewsHolder_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $allowed_actions = array(

The property $allowed_actions is not used and could be removed.

        "rss"
    );

    public function init()

This method seems to be duplicated in your project.

    {
        RSSFeed::linkToFeed($this->Link() . "rss");
        if (Director::fileExists(project() . "/css/news.css")) {
            Requirements::css(project() . "/css/news.css");
        } else {
            Requirements::css("basic-news/css/news.css");
        }

        parent::init();
    }
    
    public function rss()
    {
        $config = SiteConfig::current_site_config();
        // Creates a new RSS Feed list
        $rss = new RSSFeed(
            $list = NewsArticle::get(), // an SS_List containing your feed items
            $link = $this->Link("rss"), // a HTTP link to this feed
            $title = $config->Title . " News", // title for this feed, displayed in RSS readers
            $description = "All the latest news from ". $config->Title . "." // description
        );
        // Outputs the RSS feed to the user.
        return $rss->outputToBrowser();
    }
    
    // Provides Paginated List of NewsArticles
    public function PaginatedPages()
    {
        $list = new PaginatedList(NewsArticle::get()->filter("ParentID", $this->ID), $this->request);
        $list->setPageLength(10);
        return $list;
    }
}