CommonNameValidator::getAllowedNames() - Code Metrics - Inspection of "Add a validator for common names" - punkstar/ssl - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 21cab8...4aea99 )

by Nick

created 2017-10-17 00:09 UTC

CommonNameValidator::getAllowedNames() A

↳ Parent: CommonNameValidator

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	0
crap	2

<?php

namespace Punkstar\Ssl\Validator;

use Punkstar\Ssl\Certificate;

class CommonNameValidator
{
    /**
     * @var Certificate
     */
    private $certificate;
    
    public function __construct(Certificate $certificate)
    {
        $this->certificate = $certificate;
    }
    
    public function isValid($domain) : bool
    {
        foreach ($this->getNameVariations($domain) as $nameVariation) {
            if (in_array($nameVariation, $this->getAllowedNames(), true)) {
                return true;
            }
        }
        
        return false;
    }
    
    private function getAllowedNames() : array
    {
        // Add any SANS that might be on the certificate.
        $allowedNames = $this->certificate->sans();
    
        $sslCertSubject = $this->certificate->subject();
    
        // Add the common name from the certificate.
        if (isset($sslCertSubject['CN'])) {
            $allowedNames[] = $sslCertSubject['CN'];
        }
        
        return $allowedNames;
    }
    
    private function getNameVariations($domain) : array
    {
        $nameVariations = [$domain];
    
        // If we're looking at a subdomain then check for wildcards.
        if (substr_count($domain, '.') >= 2) {
            $nameVariations[] = '*' . substr($domain, strpos($domain, '.'));
        }
        
        return $nameVariations;
    }
}


1		<?php
2
3		namespace Punkstar\Ssl\Validator;
4
5		use Punkstar\Ssl\Certificate;
6
7		class CommonNameValidator
8		{
9		/**
10		* @var Certificate
11		*/
12		private $certificate;
13
14	2	public function __construct(Certificate $certificate)
15		{
16	2	$this->certificate = $certificate;
17	2	}
18
19	2	public function isValid($domain) : bool
20		{
21	2	foreach ($this->getNameVariations($domain) as $nameVariation) {
22	2	if (in_array($nameVariation, $this->getAllowedNames(), true)) {
23	2	return true;
24		}
25		}
26
27	2	return false;
28		}
29
30	2	private function getAllowedNames() : array
31		{
32		// Add any SANS that might be on the certificate.
33	2	$allowedNames = $this->certificate->sans();
34
35	2	$sslCertSubject = $this->certificate->subject();
36
37		// Add the common name from the certificate.
38	2	if (isset($sslCertSubject['CN'])) {
39	2	$allowedNames[] = $sslCertSubject['CN'];
40		}
41
42	2	return $allowedNames;
43		}
44
45	2	private function getNameVariations($domain) : array
46		{
47	2	$nameVariations = [$domain];
48
49		// If we're looking at a subdomain then check for wildcards.
50	2	if (substr_count($domain, '.') >= 2) {
51	2	$nameVariations[] = '*' . substr($domain, strpos($domain, '.'));
52		}
53
54	2	return $nameVariations;
55		}
56		}
57

punkstar / ssl

GitHub Access Token became invalid

Push — master ( 21cab8...4aea99 )

CommonNameValidator::getAllowedNames() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like