CommonNameValidator::isValid() - Code Metrics - punkstar/ssl - Measure and Improve Code Quality continuously with Scrutinizer

CommonNameValidator::isValid() A
last analyzed 2017-10-17 08:47 UTC

↳ Parent: CommonNameValidator

Complexity

Conditions	4
Paths	6

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	8
cts	8
cp	1
rs	9.2
c	0
b	0
f	0
cc	4
eloc	8
nc	6
nop	1
crap	4

<?php

namespace Punkstar\Ssl\Validator;

use Punkstar\Ssl\Certificate;

class CommonNameValidator
{
    /**
     * @var Certificate
     */
    private $certificate;
    
    public function __construct(Certificate $certificate)
    {
        $this->certificate = $certificate;
    }
    
    public function isValid($domain) : bool
    {
        $hostname = parse_url($domain, PHP_URL_HOST);
        
        if (!$hostname) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $hostname = $domain;
        }
        
        foreach ($this->getNameVariations($hostname) as $nameVariation) {
            if (in_array($nameVariation, $this->getAllowedNames(), true)) {
                return true;
            }
        }
        
        return false;
    }
    
    private function getAllowedNames() : array
    {
        // Add any SANS that might be on the certificate.
        $allowedNames = $this->certificate->sans();
    
        $sslCertSubject = $this->certificate->subject();
    
        // Add the common name from the certificate.
        if (isset($sslCertSubject['CN'])) {
            $allowedNames[] = $sslCertSubject['CN'];
        }
        
        return $allowedNames;
    }
    
    private function getNameVariations($domain) : array
    {
        $nameVariations = [$domain];
    
        // If we're looking at a subdomain then check for wildcards.
        if (substr_count($domain, '.') >= 2) {
            $nameVariations[] = '*' . substr($domain, strpos($domain, '.'));
        }
        
        return $nameVariations;
    }
}


1		<?php
2
3		namespace Punkstar\Ssl\Validator;
4
5		use Punkstar\Ssl\Certificate;
6
7		class CommonNameValidator
8		{
9		/**
10		* @var Certificate
11		*/
12		private $certificate;
13
14	3	public function __construct(Certificate $certificate)
15		{
16	3	$this->certificate = $certificate;
17	3	}
18
19	3	public function isValid($domain) : bool
20		{
21	3	$hostname = parse_url($domain, PHP_URL_HOST);
22
23	3	if (!$hostname) {
		0 ignored issues – show Bug Best Practice introduced 2017-10-17 08:47 UTC by Report Bug Copy Issue Report The expression `$hostname` of type `string\|false` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
24	2	$hostname = $domain;
25		}
26
27	3	foreach ($this->getNameVariations($hostname) as $nameVariation) {
28	3	if (in_array($nameVariation, $this->getAllowedNames(), true)) {
29	3	return true;
30		}
31		}
32
33	3	return false;
34		}
35
36	3	private function getAllowedNames() : array
37		{
38		// Add any SANS that might be on the certificate.
39	3	$allowedNames = $this->certificate->sans();
40
41	3	$sslCertSubject = $this->certificate->subject();
42
43		// Add the common name from the certificate.
44	3	if (isset($sslCertSubject['CN'])) {
45	3	$allowedNames[] = $sslCertSubject['CN'];
46		}
47
48	3	return $allowedNames;
49		}
50
51	3	private function getNameVariations($domain) : array
52		{
53	3	$nameVariations = [$domain];
54
55		// If we're looking at a subdomain then check for wildcards.
56	3	if (substr_count($domain, '.') >= 2) {
57	3	$nameVariations[] = '*' . substr($domain, strpos($domain, '.'));
58		}
59
60	3	return $nameVariations;
61		}
62		}
63

punkstar / ssl

GitHub Access Token became invalid

CommonNameValidator::isValid() A last analyzed 2017-10-17 08:47 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

CommonNameValidator::isValid() A
last analyzed 2017-10-17 08:47 UTC