puli / symfony-bundle

Tests/ContainerTest.php

<?php

/*
 * This file is part of the puli/symfony-bundle package.
 *
 * (c) Bernhard Schussek <bschussek@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Puli\SymfonyBundle\Tests;

use PHPUnit_Framework_TestCase;
use Puli\SymfonyBundle\PuliBundle;
use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
use Symfony\Bundle\TwigBundle\TwigBundle;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\ParameterBag\ParameterBag;
use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\HttpKernel\Bundle\BundleInterface;
use Twig_Environment;

/**
 * @since  1.0
 *
 * @author Bernhard Schussek <bschussek@gmail.com>
 */
class ContainerTest extends PHPUnit_Framework_TestCase
{
    private $tempDir;

    private $rootDir;

    private $cacheDir;

    protected function setUp()
    {
        while (false === @mkdir($this->tempDir = sys_get_temp_dir().'/puli-bundle/ContainerTest'.rand(10000, 99999), 0777, true)) {

This while loop is empty and can be removed.

        }

        $this->rootDir = $this->tempDir.'/root';
        $this->cacheDir = $this->tempDir.'/cache';

        mkdir($this->rootDir);
        mkdir($this->cacheDir);
    }

    protected function tearDown()
    {
        $filesystem = new Filesystem();
        $filesystem->remove($this->tempDir);
    }

    public function testContainer()
    {
        $container = $this->createContainer(false);

        $this->assertInstanceOf('Puli\Repository\Api\ResourceRepository', $container->get('puli.repository'));
        $this->assertInstanceOf('Puli\Discovery\Api\Discovery', $container->get('puli.discovery'));
        $this->assertInstanceOf('Puli\UrlGenerator\Api\UrlGenerator', $container->get('puli.url_generator'));
        $this->assertInstanceOf('Puli\SymfonyBridge\Config\FileLocatorChain', $container->get('file_locator'));
    }

    public function testTwigLoaded()
    {
        $container = $this->createContainer(true);

        $this->assertInstanceOf('Twig_Environment', $container->get('twig'));

        /** @var Twig_Environment $twig */
        $twig = $container->get('twig');

        $this->assertInstanceOf('Puli\TwigExtension\PuliExtension', $twig->getExtension('puli'));
        $this->assertInstanceOf('Twig_Loader_Chain', $twig->getLoader());

        $chainDefinition = $container->getDefinition('twig.loader');
        $methodCalls = $chainDefinition->getMethodCalls();

        $this->assertCount(3, $methodCalls);

        // Puli loader is inserted first
        $this->assertSame('addLoader', $methodCalls[0][0]);
        $this->assertSame('Puli\TwigExtension\PuliTemplateLoader', $methodCalls[0][1][0]->getClass());
        $this->assertSame('addLoader', $methodCalls[1][0]);
        $this->assertSame('Twig_Loader_Filesystem', $methodCalls[1][1][0]->getClass());
        $this->assertSame('addLoader', $methodCalls[2][0]);
        $this->assertSame('Twig_Loader_Filesystem', $methodCalls[2][1][0]->getClass());
    }

    public function testTwigDisabled()
    {
        $container = $this->createContainer(true, array('twig' => false));

        /** @var Twig_Environment $twig */
        $twig = $container->get('twig');

        $this->assertFalse($twig->hasExtension('puli'));

        $chainDefinition = $container->getDefinition('twig.loader');
        $methodCalls = $chainDefinition->getMethodCalls();

        $this->assertCount(2, $methodCalls);
    }

    private function createContainer($twig, array $config = array())
    {
        $bundles = array(
            'FrameworkBundle' => new FrameworkBundle(),
            'PuliBundle' => new PuliBundle(),
        );

        if ($twig) {
            $bundles['TwigBundle'] = new TwigBundle();
        }

        $container = new ContainerBuilder(new ParameterBag(array(
            'kernel.debug' => false,
            'kernel.bundles' => array_map(function ($bundle) {
                return get_class($bundle);
            }, $bundles),
            'kernel.cache_dir' => $this->rootDir,
            'kernel.root_dir' => $this->rootDir,
            'kernel.charset' => 'UTF-8',
            'kernel.secret' => '$ecret',
            'kernel.environment' => 'test',
        )));

        foreach ($bundles as $name => $bundle) {
            /* @var BundleInterface $bundle */
            $extension = $bundle->getContainerExtension();
            $container->registerExtension($extension);

It seems like $extension defined by $bundle->getContainerExtension() on line 132 can be null; however, Symfony\Component\DependencyInjection\ContainerBuilder::registerExtension() does not accept null, maybe add an additional type check?

            // Load bundle services
            $extension->load('PuliBundle' === $name ? array($config) : array(), $container);

            // Load compiler passes
            $bundle->build($container);
        }

        $container->addDefinitions(array(
            'kernel' => new Definition('Symfony\Component\HttpKernel\Tests\Fixtures\KernelForTest', array(
                'test', // environment
                false, // debug
            )),
        ));

        $container->compile();

        return $container;
    }
}