Issues in System.php (master) - Issues in master - puli/manager - Measure and Improve Code Quality continuously with Scrutinizer

Issues (201)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Util/System.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the puli/manager package.
 *
 * (c) Bernhard Schussek <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Puli\Manager\Util;

use Puli\Manager\Api\FileNotFoundException;
use Puli\Manager\Api\InvalidConfigException;
use Puli\Manager\Api\NoDirectoryException;
use Symfony\Component\Filesystem\Filesystem;

/**
 * Provides system utilities.
 *
 * @since  1.0
 *
 * @author Bernhard Schussek <[email protected]>
 */
class System

{
    /**
     * Parses context variables for Puli's home directory.
     *
     * This method scans the context variables "PULI_HOME", "HOME" and
     * "APPDATA" to determine Puli's home directory:
     *
     *  * If "PULI_HOME" is found, that directory is used.
     *  * If "HOME" is found, a directory ".puli" is created inside. This
     *    variable contains the path of the user's home directory by default
     *    on Unix based systems.
     *  * If "APPDATA" is found, a directory "Puli" is created inside. This
     *    variable contains the path of the application data by default on
     *    Windows.
     *
     * @return string The path to Puli's home directory.
     *
     * @throws InvalidConfigException If no context variable can be found to
     *                                determine the home directory.
     * @throws FileNotFoundException  If the home directory is not found.
     * @throws NoDirectoryException   If the home directory is not a directory.
     */
    public static function parseHomeDirectory()
    {
        if ($value = getenv('PULI_HOME')) {
            $homeDir = $value;
            $env = 'PULI_HOME';
        } elseif ($value = getenv('HOME')) {
            $homeDir = $value;
            $env = 'HOME';
        } elseif ($value = getenv('APPDATA')) {
            $homeDir = $value;
            $env = 'APPDATA';
        } else {
            throw new InvalidConfigException(sprintf(
                'Either the context variable PULI_HOME or %s must be set for '.
                'Puli to run.',
                defined('PHP_WINDOWS_VERSION_MAJOR') ? 'APPDATA' : 'HOME'
            ));
        }

        $homeDir = strtr($homeDir, array('\\' => '/'));

        if (!file_exists($homeDir)) {
            throw new FileNotFoundException(sprintf(
                'The home path %s defined in the context variable %s '.
                'does not exist.',
                $homeDir,
                $env
            ));
        }

        if (is_file($homeDir)) {
            throw new NoDirectoryException(sprintf(
                'The home path %s defined in the context variable %s '.
                'points to a file. Expected a directory path.',
                $homeDir,
                $env
            ));
        }

        switch ($env) {
            case 'PULI_HOME':
                return $homeDir; // user defined
            case 'HOME':
                return $homeDir.'/.puli'; // Linux/Mac
            default:
                return $homeDir.'/Puli'; // Windows
        }
    }

    /**
     * Denies web access to a directory path.
     *
     * A .htaccess file with the contents "Deny from all" is placed in the
     * directory, unless a .htaccess file exists already.
     *
     * @param string $directory The path to a directory.
     */
    public static function denyWebAccess($directory)
    {
        if (!file_exists($directory.'/.htaccess')) {
            if (!is_dir($directory)) {
                $filesystem = new Filesystem();
                $filesystem->mkdir($directory);
            }

            @file_put_contents($directory.'/.htaccess', 'Deny from all');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
    }

    private function __construct()
    {
    }
}


1		<?php
2
3		/*
4		* This file is part of the puli/manager package.
5		*
6		* (c) Bernhard Schussek <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Puli\Manager\Util;
13
14		use Puli\Manager\Api\FileNotFoundException;
15		use Puli\Manager\Api\InvalidConfigException;
16		use Puli\Manager\Api\NoDirectoryException;
17		use Symfony\Component\Filesystem\Filesystem;
18
19		/**
20		* Provides system utilities.
21		*
22		* @since 1.0
23		*
24		* @author Bernhard Schussek <[email protected]>
25		*/
26		class System
		0 ignored issues – show Coding Style introduced 2015-12-06 22:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since you have declared the constructor as private, maybe you should also declare the class as final. Loading history...
27		{
28		/**
29		* Parses context variables for Puli's home directory.
30		*
31		* This method scans the context variables "PULI_HOME", "HOME" and
32		* "APPDATA" to determine Puli's home directory:
33		*
34		* * If "PULI_HOME" is found, that directory is used.
35		* * If "HOME" is found, a directory ".puli" is created inside. This
36		* variable contains the path of the user's home directory by default
37		* on Unix based systems.
38		* * If "APPDATA" is found, a directory "Puli" is created inside. This
39		* variable contains the path of the application data by default on
40		* Windows.
41		*
42		* @return string The path to Puli's home directory.
43		*
44		* @throws InvalidConfigException If no context variable can be found to
45		* determine the home directory.
46		* @throws FileNotFoundException If the home directory is not found.
47		* @throws NoDirectoryException If the home directory is not a directory.
48		*/
49	65	public static function parseHomeDirectory()
50		{
51	65	if ($value = getenv('PULI_HOME')) {
52	54	$homeDir = $value;
53	54	$env = 'PULI_HOME';
54	11	} elseif ($value = getenv('HOME')) {
55	4	$homeDir = $value;
56	4	$env = 'HOME';
57	7	} elseif ($value = getenv('APPDATA')) {
58	4	$homeDir = $value;
59	4	$env = 'APPDATA';
60		} else {
61	3	throw new InvalidConfigException(sprintf(
62		'Either the context variable PULI_HOME or %s must be set for '.
63	3	'Puli to run.',
64	3	defined('PHP_WINDOWS_VERSION_MAJOR') ? 'APPDATA' : 'HOME'
65		));
66		}
67
68	62	$homeDir = strtr($homeDir, array('\\' => '/'));
69
70	62	if (!file_exists($homeDir)) {
71	3	throw new FileNotFoundException(sprintf(
72		'The home path %s defined in the context variable %s '.
73	3	'does not exist.',
74		$homeDir,
75		$env
76		));
77		}
78
79	59	if (is_file($homeDir)) {
80	4	throw new NoDirectoryException(sprintf(
81		'The home path %s defined in the context variable %s '.
82	4	'points to a file. Expected a directory path.',
83		$homeDir,
84		$env
85		));
86		}
87
88		switch ($env) {
89	55	case 'PULI_HOME':
90	51	return $homeDir; // user defined
91	4	case 'HOME':
92	2	return $homeDir.'/.puli'; // Linux/Mac
93		default:
94	2	return $homeDir.'/Puli'; // Windows
95		}
96		}
97
98		/**
99		* Denies web access to a directory path.
100		*
101		* A .htaccess file with the contents "Deny from all" is placed in the
102		* directory, unless a .htaccess file exists already.
103		*
104		* @param string $directory The path to a directory.
105		*/
106	48	public static function denyWebAccess($directory)
107		{
108	48	if (!file_exists($directory.'/.htaccess')) {
109	48	if (!is_dir($directory)) {
110		$filesystem = new Filesystem();
111		$filesystem->mkdir($directory);
112		}
113
114	48	@file_put_contents($directory.'/.htaccess', 'Deny from all');
		0 ignored issues – show Security Best Practice introduced 2015-12-06 22:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
115		}
116	48	}
117
118		private function __construct()
119		{
120		}
121		}
122

puli / manager

Issues (201)

Security Analysis no request data

src/Util/System.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like