Puli\Cli\Handler\PluginCommandHandler

Complexity

Total Complexity

8

Size/Duplication

Total Lines	88
Duplicated Lines	34.09 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	handleDelete()	15	15	2
A	__construct()	0	4	1
A	handleList()	0	16	3
A	handleInstall()	15	15	2

<?php

/*
 * This file is part of the puli/cli package.
 *
 * (c) Bernhard Schussek <bschussek@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Puli\Cli\Handler;

use Puli\Manager\Api\Module\RootModuleFileManager;
use RuntimeException;
use Webmozart\Console\Api\Args\Args;
use Webmozart\Console\Api\IO\IO;

/**
 * Handles the "plugin" command.
 *
 * @since  1.0
 *
 * @author Bernhard Schussek <bschussek@gmail.com>
 */
class PluginCommandHandler
{
    /**
     * @var RootModuleFileManager
     */
    private $manager;

    /**
     * Creates the handler.
     *
     * @param RootModuleFileManager $manager The root module file manager
     */
    public function __construct(RootModuleFileManager $manager)
    {
        $this->manager = $manager;
    }

    /**
     * Handles the "puli plugin --list" command.
     *
     * @param Args $args The console arguments
     * @param IO   $io   The I/O
     *
     * @return int The status code
     */
    public function handleList(Args $args, IO $io)

The parameter $args is not used and could be removed.

    {
        $pluginClasses = $this->manager->getPluginClasses();

        if (!$pluginClasses) {

The expression $pluginClasses of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            $io->writeLine('No plugin classes. Use "puli plugin --install <class>" to install a plugin class.');

            return 0;
        }

        foreach ($pluginClasses as $pluginClass) {
            $io->writeLine(sprintf('<c1>%s</c1>', $pluginClass));
        }

        return 0;
    }

    /**
     * Handles the "puli plugin --install" command.
     *
     * @param Args $args The console arguments
     *
     * @return int The status code
     */
    public function handleInstall(Args $args)

This method seems to be duplicated in your project.

    {
        $pluginClass = $args->getArgument('class');

        if ($this->manager->hasPluginClass($pluginClass)) {
            throw new RuntimeException(sprintf(
                'The plugin class "%s" is already installed.',
                $pluginClass
            ));
        }

        $this->manager->addPluginClass($pluginClass);

        return 0;
    }

    /**
     * Handles the "puli plugin --remove" command.
     *
     * @param Args $args The console arguments
     *
     * @return int The status code
     */
    public function handleDelete(Args $args)

This method seems to be duplicated in your project.

    {
        $pluginClass = $args->getArgument('class');

        if (!$this->manager->hasPluginClass($pluginClass)) {
            throw new RuntimeException(sprintf(
                'The plugin class "%s" is not installed.',
                $pluginClass
            ));
        }

        $this->manager->removePluginClass($pluginClass);

        return 0;
    }
}