puerari / cwp_api

src/Cronjob.php

<?php

namespace Puerari\Cwp;

/**
 * @trait Cronjob
 * @package Puerari\Cwp
 * @author Leandro Puerari <leandro@puerari.com.br>
 */
trait Cronjob
{
    /**
     * @param string $user : User owners of the scheduled tasks
     * @param string $execute : Frequency with which to execute the cron Example: * * * * * *
     * @param string $command : Command to execute, Example: /usr/bin/php test.php
     * @return string|bool: false on failure, result on success (JSON / XML)
     * status -> OK
     * status -> Error -> user does not exist
     */
    public function createCronJob(string $user, string $execute, string $command)
    {
        $this->data = compact('user', 'execute', 'command');

The property data does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->data['debug'] = $this->debug;
        $this->data['action'] = 'add';
        $this->cwpuri = 'cronjobsusers';

The property cwpuri does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->execCurl();

It seems like execCurl() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param string $user : User owners of the scheduled tasks
     * @param string $execute : Frequency with which to execute the cron Example: * * * * * *
     * @param string $command : Command to execute, Example: /usr/bin/php test.php
     * @return string|bool: false on failure, result on success (JSON / XML)
     * status -> OK
     * status -> Error -> user does not exist
     * status -> Error -> domain does not exist
     */
    public function deleteCronJob(string $user, string $execute, string $command)
    {
        $this->data = compact('user', 'execute', 'command');

The property data does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->data['debug'] = $this->debug;
        $this->data['action'] = 'del';
        $this->cwpuri = 'cronjobsusers';

The property cwpuri does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->execCurl();
    }

    /**
     * @param string $user : Account user name
     * @return string|bool: false on failure, result on success (JSON / XML)
     * status -> OK
     * status -> Error -> user does not exist
     */
    public function listCronJobs(string $user)
    {
        $this->data = compact('user');

The property data does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->data['debug'] = $this->debug;
        $this->data['action'] = 'list';
        $this->cwpuri = 'cronjobsusers';

The property cwpuri does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->execCurl();
    }
}