Puerari\Cwp\Server

Complexity

Total Complexity

1

Size/Duplication

Total Lines	12
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	listServerType()	0	6	1

<?php

namespace Puerari\Cwp;

/**
 * @trait Server
 * @package Puerari\Cwp
 * @author Leandro Puerari <leandro@puerari.com.br>
 */
trait Server
{
    /**
     * @return string|bool: false on failure, result on success (JSON / XML)
     * status -> OK, mjs -> openvz
     */
    public function listServerType()
    {
        $this->data['debug'] = $this->debug;

The property data does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->data['action'] = 'list';
        $this->cwpuri = 'typeserver';

The property cwpuri does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->execCurl();

It seems like execCurl() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}