Psr6Store::has() - Code Metrics - Inspection of "Extended interface to add a has() method" - publishing-kit/http-proxy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b3736d...e8cb60 )

by Matthew

created 2019-12-08 20:22 UTC

Psr6Store::has() A

↳ Parent: Psr6Store

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	3
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	5
ccs	4
cts	4
cp	1
crap	1
rs	10

<?php

declare(strict_types=1);

namespace PublishingKit\HttpProxy\Store;

use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\ResponseInterface;
use PublishingKit\HttpProxy\Contracts\StoreInterface;
use Psr\Cache\CacheItemPoolInterface;
filter:
    dependency_paths: ["lib/*"]

final class Psr6Store implements StoreInterface
{
    /**
     * @var CacheItemPoolInterface
     */
    private $cache;

    public function __construct(CacheItemPoolInterface $cache)
    {
        $this->cache = $cache;
    }

    public function has(ServerRequestInterface $request): bool
    {
        $key = $this->getCacheKey($request);
        $item = $this->cache->getItem($key);
        return $item->isHit();
    }

    public function get(ServerRequestInterface $request): ?string
    {
        $key = $this->getCacheKey($request);
        $item = $this->cache->getItem($key);
        if ($item->isHit()) {
            return $item->get();
        }
        return null;
    }

    public function put(ServerRequestInterface $request, ResponseInterface $response): void
    {
        $key = $this->getCacheKey($request);
        $item = $this->cache->getItem($key);
        $item->set($response->getBody()->__toString());
        $this->cache->save($item);
    }

    private function getCacheKey(ServerRequestInterface $request): string
    {
        $uri = $request->getUri();
        return 'cached-'
            . trim($uri->getPath(), '/')
            . ($uri->getQuery() ? '?' . $uri->getQuery() : '')
            . '.html';
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace PublishingKit\HttpProxy\Store;
6
7		use Psr\Http\Message\ServerRequestInterface;
8		use Psr\Http\Message\ResponseInterface;
9		use PublishingKit\HttpProxy\Contracts\StoreInterface;
10		use Psr\Cache\CacheItemPoolInterface;
		0 ignored issues – show Bug introduced 2019-12-08 20:23 UTC by Report Bug Copy Issue Report The type `Psr\Cache\CacheItemPoolInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11
12		final class Psr6Store implements StoreInterface
13		{
14		/**
15		* @var CacheItemPoolInterface
16		*/
17		private $cache;
18
19	15	public function __construct(CacheItemPoolInterface $cache)
20		{
21	15	$this->cache = $cache;
22	15	}
23
24	6	public function has(ServerRequestInterface $request): bool
25		{
26	6	$key = $this->getCacheKey($request);
27	6	$item = $this->cache->getItem($key);
28	6	return $item->isHit();
29		}
30
31	6	public function get(ServerRequestInterface $request): ?string
32		{
33	6	$key = $this->getCacheKey($request);
34	6	$item = $this->cache->getItem($key);
35	6	if ($item->isHit()) {
36	3	return $item->get();
37		}
38	3	return null;
39		}
40
41	3	public function put(ServerRequestInterface $request, ResponseInterface $response): void
42		{
43	3	$key = $this->getCacheKey($request);
44	3	$item = $this->cache->getItem($key);
45	3	$item->set($response->getBody()->__toString());
46	3	$this->cache->save($item);
47	3	}
48
49	15	private function getCacheKey(ServerRequestInterface $request): string
50		{
51	15	$uri = $request->getUri();
52		return 'cached-'
53	15	. trim($uri->getPath(), '/')
54	15	. ($uri->getQuery() ? '?' . $uri->getQuery() : '')
55	15	. '.html';
56		}
57		}
58

publishing-kit / http-proxy

Push — master ( b3736d...e8cb60 )

Psr6Store::has() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like