VersionBuilder::buildFromTokens() - Code Metrics - Inspection of "Add tests for VersionBuilder" - ptlis/semantic-version - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f35f34...1d2321 )

by brian

created 2017-02-04 20:32 UTC

VersionBuilder::buildFromTokens() B

↳ Parent: VersionBuilder

Complexity

Conditions	4
Paths	4

Size

Total Lines	37
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	20
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	37
ccs	20
cts	20
cp	1
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	24
nc	4
nop	2
crap	4

<?php

/**
 * @copyright   (c) 2014-2017 brian ridley
 * @author      brian ridley <[email protected]>
 * @license     http://opensource.org/licenses/MIT MIT
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ptlis\SemanticVersion\Version;

use ptlis\SemanticVersion\Parse\Token;
use ptlis\SemanticVersion\Version\Label\LabelBuilder;

/**
 * Immutable builder for version instances.
 */
final class VersionBuilder
{
    /**
     * @var LabelBuilder
     */
    private $labelBuilder;


    /**
     * Constructor.
     *
     * @param LabelBuilder $labelBuilder
     */
    public function __construct(LabelBuilder $labelBuilder)
    {
        $this->labelBuilder = $labelBuilder;
    }

    /**
     * Build a label from a token list.
     *
     * @param Token[] $versionTokenList
     * @param Token[] $labelTokenList
     *
     * @return VersionInterface|null
     */
    public function buildFromTokens(array $versionTokenList, array $labelTokenList)
    {
        $minor = 0;
        $patch = 0;
        $label = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        switch (count($versionTokenList)) {


            // Major Only
            case 1:
                $major = $versionTokenList[0]->getValue();
                break;

            // Major, minor
            case 3:
                $major = $versionTokenList[0]->getValue();
                $minor = $versionTokenList[2]->getValue();
                break;

            // Major, minor, patch
            case 5:
                $major = $versionTokenList[0]->getValue();
                $minor = $versionTokenList[2]->getValue();
                $patch = $versionTokenList[4]->getValue();
                break;

            default:
                throw new \RuntimeException('Invalid version');
        }

        return new Version(
            $major,
            $minor,
            $patch,
            $this->labelBuilder->buildFromTokens($labelTokenList)
        );
    }
}


1		<?php
2
3		/**
4		* @copyright (c) 2014-2017 brian ridley
5		* @author brian ridley <[email protected]>
6		* @license http://opensource.org/licenses/MIT MIT
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace ptlis\SemanticVersion\Version;
13
14		use ptlis\SemanticVersion\Parse\Token;
15		use ptlis\SemanticVersion\Version\Label\LabelBuilder;
16
17		/**
18		* Immutable builder for version instances.
19		*/
20		final class VersionBuilder
21		{
22		/**
23		* @var LabelBuilder
24		*/
25		private $labelBuilder;
26
27
28		/**
29		* Constructor.
30		*
31		* @param LabelBuilder $labelBuilder
32		*/
33	5	public function __construct(LabelBuilder $labelBuilder)
34		{
35	5	$this->labelBuilder = $labelBuilder;
36	5	}
37
38		/**
39		* Build a label from a token list.
40		*
41		* @param Token[] $versionTokenList
42		* @param Token[] $labelTokenList
43		*
44		* @return VersionInterface\|null
45		*/
46	5	public function buildFromTokens(array $versionTokenList, array $labelTokenList)
47		{
48	5	$minor = 0;
49	5	$patch = 0;
50	5	$label = null;
		0 ignored issues – show Unused Code introduced 2017-01-30 21:43 UTC by Report Bug Copy Issue Report `$label` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
51
52	5	switch (count($versionTokenList)) {
		1 ignored issue – show Coding Style introduced 2017-01-30 21:43 UTC by Report Bug Copy Issue Report Blank line found at start of control structure Loading history...
53
54		// Major Only
55	5	case 1:
56	1	$major = $versionTokenList[0]->getValue();
57	1	break;
58
59		// Major, minor
60	4	case 3:
61	1	$major = $versionTokenList[0]->getValue();
62	1	$minor = $versionTokenList[2]->getValue();
63	1	break;
64
65		// Major, minor, patch
66	3	case 5:
67	2	$major = $versionTokenList[0]->getValue();
68	2	$minor = $versionTokenList[2]->getValue();
69	2	$patch = $versionTokenList[4]->getValue();
70	2	break;
71
72		default:
73	1	throw new \RuntimeException('Invalid version');
74		}
75
76	4	return new Version(
77		$major,
78		$minor,
79		$patch,
80	4	$this->labelBuilder->buildFromTokens($labelTokenList)
81		);
82		}
83		}
84

ptlis / semantic-version

Push — master ( f35f34...1d2321 )

VersionBuilder::buildFromTokens() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like