ptlis / semantic-version

src/Parse/RangeMatcher/ChunkByDash.php

<?php

/**
 * @copyright   (c) 2014-2017 brian ridley
 * @author      brian ridley <ptlis@ptlis.net>
 * @license     http://opensource.org/licenses/MIT MIT
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ptlis\SemanticVersion\Parse\RangeMatcher;

use ptlis\SemanticVersion\Parse\Token;

/**
 * Trait implementing method to chunk tokens by dash seperator.
 */
trait ChunkByDash
{
    /**
     * Chuck the tokens, splitting on hyphen.
     *
     * @param Token[] $tokenList
     * @param string $separator One of Token class constants
     *
     * @return Token[][]
     */
    private function chunk(array $tokenList, $separator = Token::DASH_SEPARATOR)
    {
        $chunkList = [];
        $accumulator = [];

        // Split token stream by dash separators
        for ($i = 0; $i < count($tokenList); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            if ($separator !== $tokenList[$i]->getType()) {
                $accumulator[] = $tokenList[$i];
            } else {
                $chunkList[] = $accumulator;
                $accumulator = [];
            }
        }

        if (count($accumulator)) {
            $chunkList[] = $accumulator;
        }

        return $chunkList;
    }
}