Issues in LazySession.php (master) - Issues in master - psr7-sessions/storageless - Measure and Improve Code Quality continuously with Scrutinizer

Issues (37)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Storageless/Session/LazySession.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the MIT license.
 */

declare(strict_types=1);

namespace PSR7Sessions\Storageless\Session;

final class LazySession implements SessionInterface
{
    /** @internal do not access directly: use {@see LazySession::getRealSession} instead */
    private ?SessionInterface $realSession = null;


    /** @var callable */
    private $sessionLoader;

    /**
     * Instantiation via __construct is not allowed, use {@see LazySession::fromContainerBuildingCallback} instead
     */
    private function __construct()
    {
    }

    public static function fromContainerBuildingCallback(callable $sessionLoader) : self
    {
        $instance = new self();

        $instance->sessionLoader = $sessionLoader;

        return $instance;
    }

    /**
     * {@inheritDoc}
     */
    public function set(string $key, $value) : void
    {
        $this->getRealSession()->set($key, $value);
    }

    /**
     * {@inheritDoc}
     */
    public function get(string $key, $default = null)
    {
        return $this->getRealSession()->get($key, $default);
    }

    public function remove(string $key) : void
    {
        $this->getRealSession()->remove($key);
    }

    public function clear() : void
    {
        $this->getRealSession()->clear();
    }

    public function has(string $key) : bool
    {
        return $this->getRealSession()->has($key);
    }

    public function hasChanged() : bool
    {
        return $this->realSession && $this->realSession->hasChanged();
    }

    public function isEmpty() : bool
    {
        return $this->getRealSession()->isEmpty();
    }

    public function jsonSerialize() : object
    {
        return $this->getRealSession()->jsonSerialize();
    }

    /**
     * Get or initialize the session
     */
    private function getRealSession() : SessionInterface
    {
        return $this->realSession ?? $this->realSession = $this->loadSession();
    }

    /**
     * Type-safe wrapper that ensures that the given callback returns the expected type of object, when called
     */
    private function loadSession() : SessionInterface
    {
        $sessionLoader = $this->sessionLoader;

        return $sessionLoader();
    }
}


1		<?php
2		/*
3		* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
4		* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
5		* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
6		* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
7		* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
8		* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
9		* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
10		* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
11		* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
12		* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
13		* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
14		*
15		* This software consists of voluntary contributions made by many individuals
16		* and is licensed under the MIT license.
17		*/
18
19		declare(strict_types=1);
20
21		namespace PSR7Sessions\Storageless\Session;
22
23		final class LazySession implements SessionInterface
24		{
25		/** @internal do not access directly: use {@see LazySession::getRealSession} instead */
26		private ?SessionInterface $realSession = null;
		0 ignored issues – show Bug introduced 2020-01-15 10:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected '?', expecting T_FUNCTION or T_CONST Loading history...
27
28		/** @var callable */
29		private $sessionLoader;
30
31		/**
32		* Instantiation via __construct is not allowed, use {@see LazySession::fromContainerBuildingCallback} instead
33		*/
34	58	private function __construct()
35		{
36	58	}
37
38	58	public static function fromContainerBuildingCallback(callable $sessionLoader) : self
39		{
40	58	$instance = new self();
41
42	58	$instance->sessionLoader = $sessionLoader;
43
44	58	return $instance;
45		}
46
47		/**
48		* {@inheritDoc}
49		*/
50	22	public function set(string $key, $value) : void
51		{
52	22	$this->getRealSession()->set($key, $value);
53	22	}
54
55		/**
56		* {@inheritDoc}
57		*/
58	7	public function get(string $key, $default = null)
59		{
60	7	return $this->getRealSession()->get($key, $default);
61		}
62
63	2	public function remove(string $key) : void
64		{
65	2	$this->getRealSession()->remove($key);
66	2	}
67
68	4	public function clear() : void
69		{
70	4	$this->getRealSession()->clear();
71	4	}
72
73	1	public function has(string $key) : bool
74		{
75	1	return $this->getRealSession()->has($key);
76		}
77
78	51	public function hasChanged() : bool
79		{
80	51	return $this->realSession && $this->realSession->hasChanged();
81		}
82
83	45	public function isEmpty() : bool
84		{
85	45	return $this->getRealSession()->isEmpty();
86		}
87
88	27	public function jsonSerialize() : object
89		{
90	27	return $this->getRealSession()->jsonSerialize();
91		}
92
93		/**
94		* Get or initialize the session
95		*/
96	52	private function getRealSession() : SessionInterface
97		{
98	52	return $this->realSession ?? $this->realSession = $this->loadSession();
99		}
100
101		/**
102		* Type-safe wrapper that ensures that the given callback returns the expected type of object, when called
103		*/
104	52	private function loadSession() : SessionInterface
105		{
106	52	$sessionLoader = $this->sessionLoader;
107
108	52	return $sessionLoader();
109		}
110		}
111

psr7-sessions / storageless

Issues (37)

Security Analysis no request data

src/Storageless/Session/LazySession.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like