Psi\Component\ObjectAgent\Query\Comparison

Complexity

Total Complexity

5

Size/Duplication

Total Lines	54
Duplicated Lines	25.93 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	14	14	2
A	getComparator()	0	4	1
A	getField()	0	4	1
A	getValue()	0	4	1

<?php

declare(strict_types=1);

namespace Psi\Component\ObjectAgent\Query;

class Comparison implements Expression
{
    const EQUALS = 'eq';
    const NOT_EQUALS = 'neq';
    const GREATER_THAN = 'gt';
    const GREATER_THAN_EQUAL = 'gte';
    const LESS_THAN = 'lt';
    const LESS_THAN_EQUAL = 'lte';

    // TODO: Contains (like), NULL, NOT NULL, IN

37% of this comment could be valid code. Did you maybe forget this after debugging?

    private static $validTypes = [
        self::EQUALS,
        self::NOT_EQUALS,
        self::GREATER_THAN,
        self::GREATER_THAN_EQUAL,
        self::LESS_THAN,
        self::LESS_THAN_EQUAL,
    ];

    private $comparator;
    private $field;
    private $value;

    public function __construct(string $comparator, $field, $value)

This method seems to be duplicated in your project.

    {
        if (!in_array($comparator, self::$validTypes)) {
            throw new \InvalidArgumentException(sprintf(
                'Unknown comparator "%s". Known comparators: "%s"',
                $comparator,
                implode('", "', self::$validTypes)
            ));
        }

        $this->comparator = $comparator;
        $this->field = $field;
        $this->value = $value;
    }

    public function getComparator()
    {
        return $this->comparator;
    }

    public function getField()
    {
        return $this->field;
    }

    public function getValue()
    {
        return $this->value;
    }
}