ExpressionVisitorTest - Code Metrics - psiphp/object-agent - Measure and Improve Code Quality continuously with Scrutinizer

ExpressionVisitorTest A
last analyzed 2017-06-03 11:53 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	211
Duplicated Lines	40.76 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	9
lcom	1
cbo	4
dl	86
loc	211
rs	10
c	0
b	0
f	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	testComparator()	8	8	1
B	provideComparator()	33	33	1
A	testComplexComparator()	0	8	1
A	provideComplexComparator()	12	55	1
A	testVisitEmptyComposite()	11	11	1
A	testVisitCompositeAnd()	11	11	1
A	testVisitCompositeOr()	11	11	1
B	testNestedComposites()	0	31	1
A	setUp()	0	8	1

How to fix Duplicated Code

<?php

declare(strict_types=1);

namespace Psi\Bridge\ObjectAgent\Doctrine\PhpcrOdm\Tests\Functional;

use Doctrine\ODM\PHPCR\Query\Builder\AbstractNode;
use Doctrine\ODM\PHPCR\Query\Builder\ConstraintAndx;
use Doctrine\ODM\PHPCR\Query\Builder\ConstraintComparison;
use Doctrine\ODM\PHPCR\Query\Builder\ConstraintFieldIsset;
use Doctrine\ODM\PHPCR\Query\Builder\ConstraintNot;
use Doctrine\ODM\PHPCR\Query\Builder\ConstraintOrx;
use Psi\Bridge\ObjectAgent\Doctrine\PhpcrOdm\ExpressionVisitor;
use Psi\Component\ObjectAgent\Query\Query;
use Psi\Component\ObjectAgent\Tests\Functional\Model\Page;

class ExpressionVisitorTest extends PhpcrOdmTestCase
{
    private $queryBuilder;

    public function setUp()
    {
        $container = $this->getContainer();
        $this->queryBuilder = $container->get('phpcr_odm')
            ->getRepository(Page::class)->createQueryBuilder('a');

        $this->visitor = new ExpressionVisitor($this->queryBuilder, 'a');
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * It should visit all comparators.
     *
     * @dataProvider provideComparator
     */
    public function testComparator(string $type, string $expectedOperator)

    {
        $this->visitor->dispatch(Query::comparison($type, 'title', 42));
        $query = $this->queryBuilder;
        $children = $query->getChildrenOfType(AbstractNode::NT_WHERE);
        $children = $children[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
        $this->assertEquals($expectedOperator, $children[0]->getOperator());
    }

    public function provideComparator()

    {
        return [
            [
                'eq',
                'jcr.operator.equal.to',
            ],
            [
                'neq',
                'jcr.operator.not.equal.to',
            ],
            [
                'gt',
                'jcr.operator.greater.than',
            ],
            [
                'gte',
                'jcr.operator.greater.than.or.equal.to',
            ],
            [
                'lte',
                'jcr.operator.less.than.or.equal.to',
            ],
            [
                'lt',
                'jcr.operator.less.than',
            ],
            [
                'contains',
                'jcr.operator.like',
            ],
        ];
    }

    /**
     * It should visit complex comparators.
     *
     * @dataProvider provideComplexComparator
     */
    public function testComplexComparator(string $type, $value, \Closure $assertion)
    {
        $this->visitor->dispatch(Query::comparison($type, 'title', $value));
        $query = $this->queryBuilder;
        $children = $query->getChildrenOfType(AbstractNode::NT_WHERE);
        $children = $children[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
        $assertion($children);
    }

    public function provideComplexComparator()
    {
        return [
            [
                'in',
                [10, 20, 30],
                function ($nodes) {
                    $this->assertInstanceOf(ConstraintOrx::class, $nodes[0]);
                    $nodes = $nodes[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
                    $this->assertInstanceOf(ConstraintComparison::class, $nodes[0]);
                    $this->assertInstanceOf(ConstraintComparison::class, $nodes[1]);
                    $this->assertInstanceOf(ConstraintComparison::class, $nodes[2]);
                    $nodes = $nodes[0]->getChildrenOfType(AbstractNode::NT_OPERAND_STATIC);
                    $this->assertEquals(10, $nodes[0]->getValue());
                },
            ],
            [
                'nin',
                [10, 20, 30],
                function ($nodes) {
                    $this->assertInstanceOf(ConstraintNot::class, $nodes[0]);
                    $nodes = $nodes[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
                    $this->assertInstanceOf(ConstraintOrx::class, $nodes[0]);
                    $nodes = $nodes[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
                    $this->assertInstanceOf(ConstraintComparison::class, $nodes[1]);
                    $this->assertInstanceOf(ConstraintComparison::class, $nodes[2]);
                },
            ],
            [
                'not_contains',
                'hello',
                function ($nodes) {

                    $this->assertInstanceOf(ConstraintNot::class, $nodes[0]);
                    $nodes = $nodes[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
                    $this->assertEquals('jcr.operator.like', $nodes[0]->getOperator());
                },
            ],
            [
                'null',
                null,
                function ($nodes) {

                    $this->assertInstanceOf(ConstraintNot::class, $nodes[0]);
                    $nodes = $nodes[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
                    $this->assertInstanceOf(ConstraintFieldIsset::class, $nodes[0]);
                },
            ],
            [
                'not_null',
                null,
                function ($nodes) {
                    $this->assertInstanceOf(ConstraintFieldIsset::class, $nodes[0]);
                },
            ],
        ];
    }

    /**
     * It should process "empty" composites.
     */
    public function testVisitEmptyComposite()

    {
        $this->visitor->dispatch(
            Query::composite('and')
        );

        $query = $this->queryBuilder;
        $children = $query->getChildrenOfType(AbstractNode::NT_WHERE);
        $children = $children[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
        $this->assertInstanceOf(ConstraintAndx::class, $children[0]);
    }

    /**
     * It should visit and composites.
     */
    public function testVisitCompositeAnd()

    {
        $this->visitor->dispatch(
            Query::composite('and', Query::comparison('eq', 'title', 42))
        );

        $query = $this->queryBuilder;
        $children = $query->getChildrenOfType(AbstractNode::NT_WHERE);
        $children = $children[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
        $this->assertInstanceOf(ConstraintAndx::class, $children[0]);
    }

    /**
     * It should visit or composites.
     */
    public function testVisitCompositeOr()

    {
        $this->visitor->dispatch(
            Query::composite('or', Query::comparison('eq', 'title', 42))
        );

        $query = $this->queryBuilder;
        $children = $query->getChildrenOfType(AbstractNode::NT_WHERE);
        $children = $children[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
        $this->assertInstanceOf(ConstraintOrx::class, $children[0]);
    }

    /**
     * Test nested composites.
     */
    public function testNestedComposites()
    {
        $this->visitor->dispatch(
            Query::composite(
                'or',
                Query::comparison('eq', 'title', 42),
                QUery::composite(
                    'and',
                    Query::comparison('eq', 'title', 'boobar'),
                    Query::composite(
                        'or',
                        Query::comparison('eq', 'title', 67)
                    )
                )
            )
        );

        $query = $this->queryBuilder;
        $children = $query->getChildrenOfType(AbstractNode::NT_WHERE);
        $children = $children[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
        $this->assertInstanceOf(ConstraintOrx::class, $children[0]);
        $children = $children[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
        $this->assertInstanceOf(ConstraintAndx::class, $children[1]);
        $children = $children[1]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
        $this->assertInstanceOf(ConstraintComparison::class, $children[0]);
        $this->assertInstanceOf(ConstraintOrx::class, $children[1]);
        $children = $children[1]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
        $this->assertInstanceOf(ConstraintComparison::class, $children[0]);
        $children = $children[0]->getChildrenOfType(AbstractNode::NT_OPERAND_STATIC);
        $this->assertEquals(67, $children[0]->getValue());
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Psi\Bridge\ObjectAgent\Doctrine\PhpcrOdm\Tests\Functional;
6
7		use Doctrine\ODM\PHPCR\Query\Builder\AbstractNode;
8		use Doctrine\ODM\PHPCR\Query\Builder\ConstraintAndx;
9		use Doctrine\ODM\PHPCR\Query\Builder\ConstraintComparison;
10		use Doctrine\ODM\PHPCR\Query\Builder\ConstraintFieldIsset;
11		use Doctrine\ODM\PHPCR\Query\Builder\ConstraintNot;
12		use Doctrine\ODM\PHPCR\Query\Builder\ConstraintOrx;
13		use Psi\Bridge\ObjectAgent\Doctrine\PhpcrOdm\ExpressionVisitor;
14		use Psi\Component\ObjectAgent\Query\Query;
15		use Psi\Component\ObjectAgent\Tests\Functional\Model\Page;
16
17		class ExpressionVisitorTest extends PhpcrOdmTestCase
18		{
19		private $queryBuilder;
20
21		public function setUp()
22		{
23		$container = $this->getContainer();
24		$this->queryBuilder = $container->get('phpcr_odm')
25		->getRepository(Page::class)->createQueryBuilder('a');
26
27		$this->visitor = new ExpressionVisitor($this->queryBuilder, 'a');
		0 ignored issues – show Bug introduced 2016-11-03 15:46 UTC by Report Bug Copy Issue Report The property `visitor` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28		}
29
30		/**
31		* It should visit all comparators.
32		*
33		* @dataProvider provideComparator
34		*/
35	View Code Duplication	public function testComparator(string $type, string $expectedOperator)
		0 ignored issues – show Duplication introduced 2016-11-10 10:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		$this->visitor->dispatch(Query::comparison($type, 'title', 42));
38		$query = $this->queryBuilder;
39		$children = $query->getChildrenOfType(AbstractNode::NT_WHERE);
40		$children = $children[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
41		$this->assertEquals($expectedOperator, $children[0]->getOperator());
42		}
43
44	View Code Duplication	public function provideComparator()
		0 ignored issues – show Duplication introduced 2016-11-05 17:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		{
46		return [
47		[
48		'eq',
49		'jcr.operator.equal.to',
50		],
51		[
52		'neq',
53		'jcr.operator.not.equal.to',
54		],
55		[
56		'gt',
57		'jcr.operator.greater.than',
58		],
59		[
60		'gte',
61		'jcr.operator.greater.than.or.equal.to',
62		],
63		[
64		'lte',
65		'jcr.operator.less.than.or.equal.to',
66		],
67		[
68		'lt',
69		'jcr.operator.less.than',
70		],
71		[
72		'contains',
73		'jcr.operator.like',
74		],
75		];
76		}
77
78		/**
79		* It should visit complex comparators.
80		*
81		* @dataProvider provideComplexComparator
82		*/
83		public function testComplexComparator(string $type, $value, \Closure $assertion)
84		{
85		$this->visitor->dispatch(Query::comparison($type, 'title', $value));
86		$query = $this->queryBuilder;
87		$children = $query->getChildrenOfType(AbstractNode::NT_WHERE);
88		$children = $children[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
89		$assertion($children);
90		}
91
92		public function provideComplexComparator()
93		{
94		return [
95		[
96		'in',
97		[10, 20, 30],
98		function ($nodes) {
99		$this->assertInstanceOf(ConstraintOrx::class, $nodes[0]);
100		$nodes = $nodes[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
101		$this->assertInstanceOf(ConstraintComparison::class, $nodes[0]);
102		$this->assertInstanceOf(ConstraintComparison::class, $nodes[1]);
103		$this->assertInstanceOf(ConstraintComparison::class, $nodes[2]);
104		$nodes = $nodes[0]->getChildrenOfType(AbstractNode::NT_OPERAND_STATIC);
105		$this->assertEquals(10, $nodes[0]->getValue());
106		},
107		],
108		[
109		'nin',
110		[10, 20, 30],
111		function ($nodes) {
112		$this->assertInstanceOf(ConstraintNot::class, $nodes[0]);
113		$nodes = $nodes[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
114		$this->assertInstanceOf(ConstraintOrx::class, $nodes[0]);
115		$nodes = $nodes[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
116		$this->assertInstanceOf(ConstraintComparison::class, $nodes[1]);
117		$this->assertInstanceOf(ConstraintComparison::class, $nodes[2]);
118		},
119		],
120		[
121		'not_contains',
122		'hello',
123	View Code Duplication	function ($nodes) {
		0 ignored issues – show Duplication introduced 2016-12-11 16:06 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
124		$this->assertInstanceOf(ConstraintNot::class, $nodes[0]);
125		$nodes = $nodes[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
126		$this->assertEquals('jcr.operator.like', $nodes[0]->getOperator());
127		},
128		],
129		[
130		'null',
131		null,
132	View Code Duplication	function ($nodes) {
		0 ignored issues – show Duplication introduced 2016-11-04 11:30 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
133		$this->assertInstanceOf(ConstraintNot::class, $nodes[0]);
134		$nodes = $nodes[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
135		$this->assertInstanceOf(ConstraintFieldIsset::class, $nodes[0]);
136		},
137		],
138		[
139		'not_null',
140		null,
141		function ($nodes) {
142		$this->assertInstanceOf(ConstraintFieldIsset::class, $nodes[0]);
143		},
144		],
145		];
146		}
147
148		/**
149		* It should process "empty" composites.
150		*/
151	View Code Duplication	public function testVisitEmptyComposite()
		0 ignored issues – show Duplication introduced 2016-11-10 10:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
152		{
153		$this->visitor->dispatch(
154		Query::composite('and')
155		);
156
157		$query = $this->queryBuilder;
158		$children = $query->getChildrenOfType(AbstractNode::NT_WHERE);
159		$children = $children[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
160		$this->assertInstanceOf(ConstraintAndx::class, $children[0]);
161		}
162
163		/**
164		* It should visit and composites.
165		*/
166	View Code Duplication	public function testVisitCompositeAnd()
		0 ignored issues – show Duplication introduced 2016-11-03 15:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
167		{
168		$this->visitor->dispatch(
169		Query::composite('and', Query::comparison('eq', 'title', 42))
170		);
171
172		$query = $this->queryBuilder;
173		$children = $query->getChildrenOfType(AbstractNode::NT_WHERE);
174		$children = $children[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
175		$this->assertInstanceOf(ConstraintAndx::class, $children[0]);
176		}
177
178		/**
179		* It should visit or composites.
180		*/
181	View Code Duplication	public function testVisitCompositeOr()
		0 ignored issues – show Duplication introduced 2016-11-03 15:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
182		{
183		$this->visitor->dispatch(
184		Query::composite('or', Query::comparison('eq', 'title', 42))
185		);
186
187		$query = $this->queryBuilder;
188		$children = $query->getChildrenOfType(AbstractNode::NT_WHERE);
189		$children = $children[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
190		$this->assertInstanceOf(ConstraintOrx::class, $children[0]);
191		}
192
193		/**
194		* Test nested composites.
195		*/
196		public function testNestedComposites()
197		{
198		$this->visitor->dispatch(
199		Query::composite(
200		'or',
201		Query::comparison('eq', 'title', 42),
202		QUery::composite(
203		'and',
204		Query::comparison('eq', 'title', 'boobar'),
205		Query::composite(
206		'or',
207		Query::comparison('eq', 'title', 67)
208		)
209		)
210		)
211		);
212
213		$query = $this->queryBuilder;
214		$children = $query->getChildrenOfType(AbstractNode::NT_WHERE);
215		$children = $children[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
216		$this->assertInstanceOf(ConstraintOrx::class, $children[0]);
217		$children = $children[0]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
218		$this->assertInstanceOf(ConstraintAndx::class, $children[1]);
219		$children = $children[1]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
220		$this->assertInstanceOf(ConstraintComparison::class, $children[0]);
221		$this->assertInstanceOf(ConstraintOrx::class, $children[1]);
222		$children = $children[1]->getChildrenOfType(AbstractNode::NT_CONSTRAINT);
223		$this->assertInstanceOf(ConstraintComparison::class, $children[0]);
224		$children = $children[0]->getChildrenOfType(AbstractNode::NT_OPERAND_STATIC);
225		$this->assertEquals(67, $children[0]->getValue());
226		}
227		}
228

psiphp / object-agent

ExpressionVisitorTest A last analyzed 2017-06-03 11:53 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

ExpressionVisitorTest A
last analyzed 2017-06-03 11:53 UTC