ArrayDriver::loadMetadataForClass() - Code Metrics - Inspection of "Views" - psiphp/grid - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#42)

by Daniel

created 2016-12-11 17:05 UTC

ArrayDriver::loadMetadataForClass() C

↳ Parent: ArrayDriver

Complexity

Conditions	7
Paths	19

Size

Total Lines	94
Code Lines	68

Duplication

Lines	24
Ratio	25.53 %

Importance

Changes

Metric	Value
dl	24
loc	94
rs	6.4883
c	0
b	0
f	0
cc	7
eloc	68
nc	19
nop	1

How to fix Long Method

<?php

declare(strict_types=1);

namespace Psi\Component\Grid\Metadata\Driver;

use Metadata\Driver\AdvancedDriverInterface;
use Psi\Component\Grid\Metadata\ActionMetadata;
use Psi\Component\Grid\Metadata\ClassMetadata;
use Psi\Component\Grid\Metadata\ColumnMetadata;
use Psi\Component\Grid\Metadata\FilterMetadata;
use Psi\Component\Grid\Metadata\GridMetadata;
use Psi\Component\Grid\Metadata\QueryMetadata;

class ArrayDriver implements AdvancedDriverInterface
{
    /**
     * @var array
     */
    private $config;

    /**
     * @param array $config
     */
    public function __construct(array $config)
    {
        $this->config = $config;
    }

    /**
     * {@inheritdoc}
     */
    public function loadMetadataForClass(\ReflectionClass $class)
    {
        if (!isset($this->config[$class->getName()])) {

            return;
        }

        $config = $this->resolveConfig([
            'grids' => [],
            'queries' => [],
        ], $this->config[$class->getName()]);


        $queries = [];
        foreach ($config['queries'] as $queryName => $queryConfig) {
            $queryConfig = $this->resolveConfig([
                'name' => null,
                'selects' => [],
                'joins' => [],
                'criteria' => [],
            ], $queryConfig);
            $queries[$queryName] = new QueryMetadata(
                $queryName, $queryConfig['selects'], $queryConfig['joins'], $queryConfig['criteria']
            );
        }


        $grids = [];
        foreach ($config['grids'] as $gridName => $gridConfig) {
            $gridConfig = $this->resolveConfig([
                'name' => null,
                'query' => null,
                'columns' => [],
                'filters' => [],
                'actions' => [],
                'page_size' => 50,
            ], $gridConfig);

            $columns = [];
            foreach ($gridConfig['columns'] as $columnName => $columnConfig) {

                $columnConfig = $this->resolveConfig([
                    'type' => null,
                    'options' => [],
                ], $columnConfig);

                $columns[$columnName] = new ColumnMetadata(
                    $columnName,
                    $columnConfig['type'],
                    $columnConfig['options']
                );
            }

            $filters = [];
            foreach ($gridConfig['filters'] as $filterName => $filterConfig) {
                $filterConfig = $this->resolveConfig([
                    'type' => null,
                    'field' => null,
                    'options' => [],
                ], $filterConfig);

                $filters[$filterName] = new FilterMetadata(
                    $filterName,
                    $filterConfig['type'],
                    $filterConfig['field'],
                    $filterConfig['options']
                );
            }

            $actions = [];
            foreach ($gridConfig['actions'] as $actionName => $actionConfig) {

                $actionConfig = $this->resolveConfig([
                    'type' => null,
                    'options' => [],
                ], $actionConfig);

                $actions[$actionName] = new ActionMetadata(
                    $actionName,
                    $actionConfig['type'],
                    $actionConfig['options']
                );
            }

            $grids[$gridName] = new GridMetadata(
                $gridName,
                $columns,
                $filters,
                $actions,
                $gridConfig['page_size'],
                $gridConfig['query']
            );
        }

        $classMetadata = new ClassMetadata($class->getName(), $grids, $queries);


        return $classMetadata;
    }

    /**
     * {@inheritdoc}
     */
    public function getAllClassNames()
    {
        return array_keys($this->config);
    }

    private function resolveConfig(array $defaultConfig, array $config)
    {
        if ($diff = array_diff(array_keys($config), array_keys($defaultConfig))) {

            throw new \InvalidArgumentException(sprintf(
                'Invalid configuration keys "%s" for grid, valid keys: "%s"',
                implode('", "', $diff), implode('", "', array_keys($defaultConfig))
            ));
        }

        return array_merge($defaultConfig, $config);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Psi\Component\Grid\Metadata\Driver;
6
7		use Metadata\Driver\AdvancedDriverInterface;
8		use Psi\Component\Grid\Metadata\ActionMetadata;
9		use Psi\Component\Grid\Metadata\ClassMetadata;
10		use Psi\Component\Grid\Metadata\ColumnMetadata;
11		use Psi\Component\Grid\Metadata\FilterMetadata;
12		use Psi\Component\Grid\Metadata\GridMetadata;
13		use Psi\Component\Grid\Metadata\QueryMetadata;
14
15		class ArrayDriver implements AdvancedDriverInterface
16		{
17		/**
18		* @var array
19		*/
20		private $config;
21
22		/**
23		* @param array $config
24		*/
25		public function __construct(array $config)
26		{
27		$this->config = $config;
28		}
29
30		/**
31		* {@inheritdoc}
32		*/
33		public function loadMetadataForClass(\ReflectionClass $class)
34		{
35		if (!isset($this->config[$class->getName()])) {
		0 ignored issues – show Bug introduced 2016-11-06 14:07 UTC by Report Bug Copy Issue Report Consider using `$class->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
36		return;
37		}
38
39		$config = $this->resolveConfig([
40		'grids' => [],
41		'queries' => [],
42		], $this->config[$class->getName()]);
		0 ignored issues – show Bug introduced 2016-11-06 14:07 UTC by Report Bug Copy Issue Report Consider using `$class->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
43
44		$queries = [];
45		foreach ($config['queries'] as $queryName => $queryConfig) {
46		$queryConfig = $this->resolveConfig([
47		'name' => null,
48		'selects' => [],
49		'joins' => [],
50		'criteria' => [],
51		], $queryConfig);
52		$queries[$queryName] = new QueryMetadata(
53		$queryName, $queryConfig['selects'], $queryConfig['joins'], $queryConfig['criteria']
54		);
55		}
56
57
58		$grids = [];
59		foreach ($config['grids'] as $gridName => $gridConfig) {
60		$gridConfig = $this->resolveConfig([
61		'name' => null,
62		'query' => null,
63		'columns' => [],
64		'filters' => [],
65		'actions' => [],
66		'page_size' => 50,
67		], $gridConfig);
68
69		$columns = [];
70	View Code Duplication	foreach ($gridConfig['columns'] as $columnName => $columnConfig) {
		0 ignored issues – show Duplication introduced 2016-11-15 13:38 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		$columnConfig = $this->resolveConfig([
72		'type' => null,
73		'options' => [],
74		], $columnConfig);
75
76		$columns[$columnName] = new ColumnMetadata(
77		$columnName,
78		$columnConfig['type'],
79		$columnConfig['options']
80		);
81		}
82
83		$filters = [];
84		foreach ($gridConfig['filters'] as $filterName => $filterConfig) {
85		$filterConfig = $this->resolveConfig([
86		'type' => null,
87		'field' => null,
88		'options' => [],
89		], $filterConfig);
90
91		$filters[$filterName] = new FilterMetadata(
92		$filterName,
93		$filterConfig['type'],
94		$filterConfig['field'],
95		$filterConfig['options']
96		);
97		}
98
99		$actions = [];
100	View Code Duplication	foreach ($gridConfig['actions'] as $actionName => $actionConfig) {
		0 ignored issues – show Duplication introduced 2016-11-15 13:38 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
101		$actionConfig = $this->resolveConfig([
102		'type' => null,
103		'options' => [],
104		], $actionConfig);
105
106		$actions[$actionName] = new ActionMetadata(
107		$actionName,
108		$actionConfig['type'],
109		$actionConfig['options']
110		);
111		}
112
113		$grids[$gridName] = new GridMetadata(
114		$gridName,
115		$columns,
116		$filters,
117		$actions,
118		$gridConfig['page_size'],
119		$gridConfig['query']
120		);
121		}
122
123		$classMetadata = new ClassMetadata($class->getName(), $grids, $queries);
		0 ignored issues – show Bug introduced 2016-12-10 18:16 UTC by Report Bug Copy Issue Report Consider using `$class->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
124
125		return $classMetadata;
126		}
127
128		/**
129		* {@inheritdoc}
130		*/
131		public function getAllClassNames()
132		{
133		return array_keys($this->config);
134		}
135
136		private function resolveConfig(array $defaultConfig, array $config)
137		{
138	View Code Duplication	if ($diff = array_diff(array_keys($config), array_keys($defaultConfig))) {
		0 ignored issues – show Duplication introduced 2016-11-06 16:25 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
139		throw new \InvalidArgumentException(sprintf(
140		'Invalid configuration keys "%s" for grid, valid keys: "%s"',
141		implode('", "', $diff), implode('", "', array_keys($defaultConfig))
142		));
143		}
144
145		return array_merge($defaultConfig, $config);
146		}
147		}
148

psiphp / grid

Pull Request — master (#42)

ArrayDriver::loadMetadataForClass() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like