PropertyColumn::createCell() - Code Metrics - Inspection of "Cell builder" - psiphp/grid - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#49)

by Daniel

created 2016-12-15 09:16 UTC

PropertyColumn::createCell() A

↳ Parent: PropertyColumn

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	2

<?php

declare(strict_types=1);

namespace Psi\Component\Grid\Column;

use Psi\Component\Grid\ColumnInterface;
use Psi\Component\Grid\View\Cell;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Symfony\Component\PropertyAccess\PropertyAccess;
use Symfony\Component\PropertyAccess\PropertyAccessorInterface;

class PropertyColumn implements ColumnInterface
{
    /**
     * @var PropertyAccessor
     */
    private $accessor;

    public function __construct(PropertyAccessorInterface $propertyAccessor = null)
    {
        $this->accessor = $propertyAccessor ?: PropertyAccess::createPropertyAccessor();

    }

    public function buildCell(Cell $cell, array $options)
    {
        $property = $options['property'];
        $cell->template = 'Property';
        $cell->value = $this->accessor->getValue($cell->context, $property);
    }

    public function configureOptions(OptionsResolver $options)
    {
        $options->setDefault('property', null);
        $options->setAllowedTypes('property', ['string', 'null']);
        $options->setNormalizer('property', function (OptionsResolver $options, $value) {
            if (null !== $value) {
                return $value;
            }

            return $options['column_name'];
        });
        $options->setNormalizer('sort_field', function (OptionsResolver $options, $value) {
            if (null !== $value) {
                return $value;
            }

            return $options['column_name'];
        });
    }

    public function getParent()
    {
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Psi\Component\Grid\Column;
6
7			use Psi\Component\Grid\ColumnInterface;
8			use Psi\Component\Grid\View\Cell;
9			use Symfony\Component\OptionsResolver\OptionsResolver;
10			use Symfony\Component\PropertyAccess\PropertyAccess;
11			use Symfony\Component\PropertyAccess\PropertyAccessorInterface;
12
13			class PropertyColumn implements ColumnInterface
14			{
15			/**
16			* @var PropertyAccessor
17			*/
18			private $accessor;
19
20			public function __construct(PropertyAccessorInterface $propertyAccessor = null)
21			{
22			$this->accessor = $propertyAccessor ?: PropertyAccess::createPropertyAccessor();
			0 ignored issues – show Documentation Bug introduced 2016-12-11 11:07 UTC by Report Bug Copy Issue Report It seems like `$propertyAccessor ?: \Sy...reatePropertyAccessor()` of type `object<Symfony\Component...pertyAccessorInterface>` or `object<Symfony\Component...ccess\PropertyAccessor>` is incompatible with the declared type `object<Psi\Component\Gri...olumn\PropertyAccessor>` of property `$accessor`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
23			}
24
25			public function buildCell(Cell $cell, array $options)
26			{
27			$property = $options['property'];
28			$cell->template = 'Property';
29			$cell->value = $this->accessor->getValue($cell->context, $property);
30			}
31
32			public function configureOptions(OptionsResolver $options)
33			{
34			$options->setDefault('property', null);
35			$options->setAllowedTypes('property', ['string', 'null']);
36			$options->setNormalizer('property', function (OptionsResolver $options, $value) {
37			if (null !== $value) {
38			return $value;
39			}
40
41			return $options['column_name'];
42			});
43			$options->setNormalizer('sort_field', function (OptionsResolver $options, $value) {
44			if (null !== $value) {
45			return $value;
46			}
47
48			return $options['column_name'];
49			});
50			}
51
52			public function getParent()
53			{
54			}
55			}
56

psiphp / grid

Pull Request — master (#49)

PropertyColumn::createCell() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like