StringFilter::getValue() - Code Metrics - Inspection of "Merge pull request #68 from psiphp/date_filter" - psiphp/grid - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02db1d...96e327 )

by Daniel

created 2016-12-19 09:28 UTC

StringFilter::getValue() D

↳ Parent: StringFilter

Complexity

Conditions	10
Paths	10

Size

Total Lines	25
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	25
rs	4.8196
c	0
b	0
f	0
cc	10
eloc	21
nc	10
nop	2

How to fix Complexity

<?php

declare(strict_types=1);

namespace Psi\Component\Grid\Filter;

use Psi\Component\ObjectAgent\Query\Comparison;
use Psi\Component\ObjectAgent\Query\Expression;
use Psi\Component\ObjectAgent\Query\Query;
use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class StringFilter extends AbstractComparatorFilter
{
    const TYPE_EQUAL = 'equal';
    const TYPE_EMPTY = 'empty';
    const TYPE_NOT_EMPTY = 'not_empty';
    const TYPE_CONTAINS = 'contains';
    const TYPE_NOT_CONTAINS = 'not_contains';
    const TYPE_STARTS_WITH = 'starts_with';
    const TYPE_ENDS_WITH = 'ends_with';
    const TYPE_IN = 'in';
    const TYPE_NOT_IN = 'not_in';

    private static $comparatorMap = [
        self::TYPE_EQUAL => Comparison::EQUALS,
        self::TYPE_EMPTY => Comparison::NULL,
        self::TYPE_NOT_EMPTY => Comparison::NOT_NULL,
        self::TYPE_CONTAINS => Comparison::CONTAINS,
        self::TYPE_NOT_CONTAINS => Comparison::NOT_CONTAINS,
        self::TYPE_STARTS_WITH => Comparison::CONTAINS,
        self::TYPE_ENDS_WITH => Comparison::CONTAINS,
        self::TYPE_IN => Comparison::IN,
        self::TYPE_NOT_IN => Comparison::NOT_IN,
    ];

    /**
     * {@inheritdoc}
     */
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $this->addComparatorChoice($builder, $options);

        $builder->add('value', TextType::class, [
            'required' => false,
        ]);
    }

    /**
     * {@inheritdoc}
     */
    public function getExpression(string $fieldName, array $data): Expression
    {
        $comparator = $data['comparator'] ?: self::TYPE_EQUAL;

        return Query::comparison(
            self::$comparatorMap[$comparator],
            $fieldName,
            $this->getValue($comparator, $data['value'])
        );
    }

    /**
     * {@inheritdoc}
     */
    public function configureOptions(OptionsResolver $options)
    {
        $options->setDefault('comparators', array_keys(self::$comparatorMap));
    }

    /**
     * {@inheritdoc}
     */
    public function isApplicable(array $filterData): bool
    {
        return isset($filterData['value']);
    }

    protected function getComparatorMap(): array
    {
        return self::$comparatorMap;
    }

    private function getValue($comparator, $value)
    {
        switch ($comparator) {
            case self::TYPE_EQUAL:
                return $value;
            case self::TYPE_EMPTY:
                return;
            case self::TYPE_NOT_EMPTY:
                return;
            case self::TYPE_CONTAINS:
                return '%' . $value . '%';
            case self::TYPE_NOT_CONTAINS:
                return '%' . $value . '%';
            case self::TYPE_STARTS_WITH:
                return $value . '%';
            case self::TYPE_ENDS_WITH:
                return '%' . $value;
            case self::TYPE_IN:
                return array_map('trim', explode(',', $value));
            case self::TYPE_NOT_IN:
                return array_map('trim', explode(',', $value));
        }

        throw new \InvalidArgumentException(sprintf('Could not determine value for comparator "%s"', $comparator));
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Psi\Component\Grid\Filter;
6
7			use Psi\Component\ObjectAgent\Query\Comparison;
8			use Psi\Component\ObjectAgent\Query\Expression;
9			use Psi\Component\ObjectAgent\Query\Query;
10			use Symfony\Component\Form\Extension\Core\Type\TextType;
11			use Symfony\Component\Form\FormBuilderInterface;
12			use Symfony\Component\OptionsResolver\OptionsResolver;
13
14			class StringFilter extends AbstractComparatorFilter
15			{
16			const TYPE_EQUAL = 'equal';
17			const TYPE_EMPTY = 'empty';
18			const TYPE_NOT_EMPTY = 'not_empty';
19			const TYPE_CONTAINS = 'contains';
20			const TYPE_NOT_CONTAINS = 'not_contains';
21			const TYPE_STARTS_WITH = 'starts_with';
22			const TYPE_ENDS_WITH = 'ends_with';
23			const TYPE_IN = 'in';
24			const TYPE_NOT_IN = 'not_in';
25
26			private static $comparatorMap = [
27			self::TYPE_EQUAL => Comparison::EQUALS,
28			self::TYPE_EMPTY => Comparison::NULL,
29			self::TYPE_NOT_EMPTY => Comparison::NOT_NULL,
30			self::TYPE_CONTAINS => Comparison::CONTAINS,
31			self::TYPE_NOT_CONTAINS => Comparison::NOT_CONTAINS,
32			self::TYPE_STARTS_WITH => Comparison::CONTAINS,
33			self::TYPE_ENDS_WITH => Comparison::CONTAINS,
34			self::TYPE_IN => Comparison::IN,
35			self::TYPE_NOT_IN => Comparison::NOT_IN,
36			];
37
38			/**
39			* {@inheritdoc}
40			*/
41			public function buildForm(FormBuilderInterface $builder, array $options)
42			{
43			$this->addComparatorChoice($builder, $options);
44
45			$builder->add('value', TextType::class, [
46			'required' => false,
47			]);
48			}
49
50			/**
51			* {@inheritdoc}
52			*/
53			public function getExpression(string $fieldName, array $data): Expression
54			{
55			$comparator = $data['comparator'] ?: self::TYPE_EQUAL;
56
57			return Query::comparison(
58			self::$comparatorMap[$comparator],
59			$fieldName,
60			$this->getValue($comparator, $data['value'])
61			);
62			}
63
64			/**
65			* {@inheritdoc}
66			*/
67			public function configureOptions(OptionsResolver $options)
68			{
69			$options->setDefault('comparators', array_keys(self::$comparatorMap));
70			}
71
72			/**
73			* {@inheritdoc}
74			*/
75			public function isApplicable(array $filterData): bool
76			{
77			return isset($filterData['value']);
78			}
79
80			protected function getComparatorMap(): array
81			{
82			return self::$comparatorMap;
83			}
84
85			private function getValue($comparator, $value)
86			{
87			switch ($comparator) {
88			case self::TYPE_EQUAL:
89			return $value;
90			case self::TYPE_EMPTY:
91			return;
92			case self::TYPE_NOT_EMPTY:
93			return;
94			case self::TYPE_CONTAINS:
95			return '%' . $value . '%';
96			case self::TYPE_NOT_CONTAINS:
97			return '%' . $value . '%';
98			case self::TYPE_STARTS_WITH:
99			return $value . '%';
100			case self::TYPE_ENDS_WITH:
101			return '%' . $value;
102			case self::TYPE_IN:
103			return array_map('trim', explode(',', $value));
104			case self::TYPE_NOT_IN:
105			return array_map('trim', explode(',', $value));
106			}
107
108			throw new \InvalidArgumentException(sprintf('Could not determine value for comparator "%s"', $comparator));
109			}
110			}
111

psiphp / grid

Push — master ( 02db1d...96e327 )

StringFilter::getValue() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like