StringFilter::getValue() - Code Metrics - Inspection of "Date filter" - psiphp/grid - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#68)

by Daniel

created 2016-12-16 14:48 UTC

StringFilter::getValue() D

↳ Parent: StringFilter

Complexity

Conditions	10
Paths	10

Size

Total Lines	25
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	25
rs	4.8196
c	0
b	0
f	0
cc	10
eloc	21
nc	10
nop	2

How to fix Complexity

<?php

declare(strict_types=1);

namespace Psi\Component\Grid\Filter;

use Psi\Component\Grid\FilterDataInterface;
use Psi\Component\Grid\FilterInterface;
use Psi\Component\ObjectAgent\Capabilities;
use Psi\Component\ObjectAgent\Query\Comparison;
use Psi\Component\ObjectAgent\Query\Expression;
use Psi\Component\ObjectAgent\Query\Query;
use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
use Symfony\Component\Form\Extension\Core\Type\HiddenType;
use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class StringFilter extends AbstractComparatorFilter
{
    const TYPE_EQUAL = 'equal';
    const TYPE_EMPTY = 'empty';
    const TYPE_NOT_EMPTY = 'not_empty';
    const TYPE_CONTAINS = 'contains';
    const TYPE_NOT_CONTAINS = 'not_contains';
    const TYPE_STARTS_WITH = 'starts_with';
    const TYPE_ENDS_WITH = 'ends_with';
    const TYPE_IN = 'in';
    const TYPE_NOT_IN = 'not_in';

    private static $comparatorMap = [
        self::TYPE_EQUAL => Comparison::EQUALS,
        self::TYPE_EMPTY => Comparison::NULL,
        self::TYPE_NOT_EMPTY => Comparison::NOT_NULL,
        self::TYPE_CONTAINS => Comparison::CONTAINS,
        self::TYPE_NOT_CONTAINS => Comparison::NOT_CONTAINS,
        self::TYPE_STARTS_WITH => Comparison::CONTAINS,
        self::TYPE_ENDS_WITH => Comparison::CONTAINS,
        self::TYPE_IN => Comparison::IN,
        self::TYPE_NOT_IN => Comparison::NOT_IN,
    ];

    /**
     * {@inheritdoc}
     */
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $this->addComparatorChoice($builder, $options);

        $builder->add('value', TextType::class, [
            'required' => false,
        ]);
    }

    /**
     * {@inheritdoc}
     */
    public function getExpression(string $fieldName, FilterDataInterface $data): Expression

    {
        $comparator = $data->getComparator() ?: self::TYPE_EQUAL;
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return Query::comparison(
            self::$comparatorMap[$comparator],
            $fieldName,
            $this->getValue($comparator, $data->getValue())
        );
    }

    /**
     * {@inheritdoc}
     */
    public function configureOptions(OptionsResolver $options)

    {
        $options->setDefault('comparators', array_keys(self::$comparatorMap));
        $options->setDefault('data_class', StringFilterData::class);
        $options->setDefault('empty_data', function (FormInterface $form) {
            return new StringFilterData(
                $form->get('comparator')->getData(),
                $form->get('value')->getData()
            );
        });
    }

    protected function getComparatorMap(): array
    {
        return self::$comparatorMap;
    }

    private function getValue($comparator, $value)
    {
        switch ($comparator) {
            case self::TYPE_EQUAL:
                return $value;
            case self::TYPE_EMPTY:
                return;
            case self::TYPE_NOT_EMPTY:
                return;
            case self::TYPE_CONTAINS:
                return '%' . $value . '%';
            case self::TYPE_NOT_CONTAINS:
                return '%' . $value . '%';
            case self::TYPE_STARTS_WITH:
                return $value . '%';
            case self::TYPE_ENDS_WITH:
                return '%' . $value;
            case self::TYPE_IN:
                return array_map('trim', explode(',', $value));
            case self::TYPE_NOT_IN:
                return array_map('trim', explode(',', $value));
        }

        throw new \InvalidArgumentException(sprintf('Could not determine value for comparator "%s"', $comparator));
    }
}


Pull Request — master (#68)

StringFilter::getValue() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Available Fixes

1		<?php
2
3		declare(strict_types=1);
4
5		namespace Psi\Component\Grid\Filter;
6
7		use Psi\Component\Grid\FilterDataInterface;
8		use Psi\Component\Grid\FilterInterface;
9		use Psi\Component\ObjectAgent\Capabilities;
10		use Psi\Component\ObjectAgent\Query\Comparison;
11		use Psi\Component\ObjectAgent\Query\Expression;
12		use Psi\Component\ObjectAgent\Query\Query;
13		use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
14		use Symfony\Component\Form\Extension\Core\Type\HiddenType;
15		use Symfony\Component\Form\Extension\Core\Type\TextType;
16		use Symfony\Component\Form\FormBuilderInterface;
17		use Symfony\Component\Form\FormInterface;
18		use Symfony\Component\OptionsResolver\OptionsResolver;
19
20		class StringFilter extends AbstractComparatorFilter
21		{
22		const TYPE_EQUAL = 'equal';
23		const TYPE_EMPTY = 'empty';
24		const TYPE_NOT_EMPTY = 'not_empty';
25		const TYPE_CONTAINS = 'contains';
26		const TYPE_NOT_CONTAINS = 'not_contains';
27		const TYPE_STARTS_WITH = 'starts_with';
28		const TYPE_ENDS_WITH = 'ends_with';
29		const TYPE_IN = 'in';
30		const TYPE_NOT_IN = 'not_in';
31
32		private static $comparatorMap = [
33		self::TYPE_EQUAL => Comparison::EQUALS,
34		self::TYPE_EMPTY => Comparison::NULL,
35		self::TYPE_NOT_EMPTY => Comparison::NOT_NULL,
36		self::TYPE_CONTAINS => Comparison::CONTAINS,
37		self::TYPE_NOT_CONTAINS => Comparison::NOT_CONTAINS,
38		self::TYPE_STARTS_WITH => Comparison::CONTAINS,
39		self::TYPE_ENDS_WITH => Comparison::CONTAINS,
40		self::TYPE_IN => Comparison::IN,
41		self::TYPE_NOT_IN => Comparison::NOT_IN,
42		];
43
44		/**
45		* {@inheritdoc}
46		*/
47		public function buildForm(FormBuilderInterface $builder, array $options)
48		{
49		$this->addComparatorChoice($builder, $options);
50
51		$builder->add('value', TextType::class, [
52		'required' => false,
53		]);
54		}
55
56		/**
57		* {@inheritdoc}
58		*/
59	View Code Duplication	public function getExpression(string $fieldName, FilterDataInterface $data): Expression
		0 ignored issues – show Duplication introduced 2016-11-15 13:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60		{
61		$comparator = $data->getComparator() ?: self::TYPE_EQUAL;
		0 ignored issues – show Bug introduced 2016-12-16 14:50 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psi\Component\Grid\FilterDataInterface` as the method `getComparator()` does only exist in the following implementations of said interface: `Psi\Component\Grid\Filter\DateFilterData`, `Psi\Component\Grid\Filter\NumberFilterData`, `Psi\Component\Grid\Filter\StringFilterData`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
62
63		return Query::comparison(
64		self::$comparatorMap[$comparator],
65		$fieldName,
66		$this->getValue($comparator, $data->getValue())
67		);
68		}
69
70		/**
71		* {@inheritdoc}
72		*/
73	View Code Duplication	public function configureOptions(OptionsResolver $options)
		0 ignored issues – show Duplication introduced 2016-11-08 13:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
74		{
75		$options->setDefault('comparators', array_keys(self::$comparatorMap));
76		$options->setDefault('data_class', StringFilterData::class);
77		$options->setDefault('empty_data', function (FormInterface $form) {
78		return new StringFilterData(
79		$form->get('comparator')->getData(),
80		$form->get('value')->getData()
81		);
82		});
83		}
84
85		protected function getComparatorMap(): array
86		{
87		return self::$comparatorMap;
88		}
89
90		private function getValue($comparator, $value)
91		{
92		switch ($comparator) {
93		case self::TYPE_EQUAL:
94		return $value;
95		case self::TYPE_EMPTY:
96		return;
97		case self::TYPE_NOT_EMPTY:
98		return;
99		case self::TYPE_CONTAINS:
100		return '%' . $value . '%';
101		case self::TYPE_NOT_CONTAINS:
102		return '%' . $value . '%';
103		case self::TYPE_STARTS_WITH:
104		return $value . '%';
105		case self::TYPE_ENDS_WITH:
106		return '%' . $value;
107		case self::TYPE_IN:
108		return array_map('trim', explode(',', $value));
109		case self::TYPE_NOT_IN:
110		return array_map('trim', explode(',', $value));
111		}
112
113		throw new \InvalidArgumentException(sprintf('Could not determine value for comparator "%s"', $comparator));
114		}
115		}
116

psiphp / grid

Pull Request — master (#68)

StringFilter::getValue() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like