GridFactoryBuilder::createGridFactory() - Code Metrics - Inspection of "Hotfix" - psiphp/grid - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#57)

by Daniel

created 2016-12-15 16:23 UTC

GridFactoryBuilder::createGridFactory() B

↳ Parent: Project

Complexity

Conditions	5
Paths	9

Size

Total Lines	53
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	53
rs	8.7155
c	0
b	0
f	0
cc	5
eloc	35
nc	9
nop	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace Psi\Component\Grid;

use Metadata\Driver\DriverChain;
use Metadata\MetadataFactory;
use Psi\Component\Grid\Action\DeleteAction;
use Psi\Component\Grid\Column\BooleanColumn;
use Psi\Component\Grid\Column\DateTimeColumn;
use Psi\Component\Grid\Column\MoneyColumn;
use Psi\Component\Grid\Column\PropertyColumn;
use Psi\Component\Grid\Column\SelectColumn;
use Psi\Component\Grid\Filter\BooleanFilter;
use Psi\Component\Grid\Filter\NumberFilter;
use Psi\Component\Grid\Filter\StringFilter;
use Psi\Component\Grid\Form\GridExtension;
use Psi\Component\Grid\Metadata\Driver\AnnotationDriver;
use Psi\Component\Grid\Metadata\Driver\ArrayDriver;
use Psi\Component\ObjectAgent\AgentFinder;
use Symfony\Component\Form\Extension\Validator\ValidatorExtension;
use Symfony\Component\Form\FormFactoryBuilderInterface;
use Symfony\Component\Form\Forms;
use Symfony\Component\Validator\Validation;
use Psi\Component\Grid\Column\BooleanColumn;

use Psi\Component\Grid\Column\MoneyColumn;

final class GridFactoryBuilder
{
    private $agentFinder;
    private $formFactoryBuilder;

    private $actions = [];
    private $columns = [];
    private $filters = [];
    private $metadataDrivers = [];

    public static function create(
        AgentFinder $agentFinder,
        FormFactoryBuilderInterface $formFactoryBuilder = null
    ) {
        $instance = new self();
        $instance->agentFinder = $agentFinder;
        $instance->formFactoryBuilder = $formFactoryBuilder ?: Forms::createFormFactoryBuilder();

        return $instance;
    }

    public static function createWithDefaults(AgentFinder $agentFinder, FormFactoryBuilderInterface $formFactoryBuilder = null)
    {
        return self::create($agentFinder, $formFactoryBuilder)
            ->addAction(new DeleteAction(), 'delete')
            ->addColumn(new PropertyColumn(), 'property')
            ->addColumn(new SelectColumn($agentFinder), 'select')
            ->addColumn(new DateTimeColumn(), 'datetime')
            ->addColumn(new MoneyColumn(), 'money')
            ->addColumn(new BooleanColumn(), 'boolean')
            ->addFilter(new StringFilter(), 'string')
            ->addFilter(new BooleanFilter(), 'boolean')
            ->addFilter(new NumberFilter(), 'number');
    }

    public function addArrayDriver(array $mapping)
    {
        $this->metadataDrivers[] = new ArrayDriver($mapping);

        return $this;
    }

    public function addAnnotationDriver()
    {
        $this->metadataDrivers[] = new AnnotationDriver();

        return $this;
    }

    public function addAction(ActionInterface $action, $alias = null): self
    {
        $this->actions[$alias] = $action;

        return $this;
    }

    public function addFilter(FilterInterface $filter, $alias = null)
    {
        $this->filters[$alias] = $filter;

        return $this;
    }

    public function addColumn(ColumnInterface $column, $alias = null)
    {
        $this->columns[$alias] = $column;

        return $this;
    }

    public function createGridFactory()
    {
        if (empty($this->metadataDrivers)) {
            throw new \InvalidArgumentException(
                'You must add at least one metadata driver (e.g. ->addArrayDriver, ->addAnnotationDriver, ->addXmlDriver)'
            );
        }

        $actionRegistry = new ActionRegistry();
        foreach ($this->actions as $alias => $action) {
            $actionRegistry->register($action, $alias);
        }
        $columnRegistry = new ColumnRegistry();
        foreach ($this->columns as $alias => $column) {
            $columnRegistry->register($column, $alias);
        }
        $filterRegistry = new FilterRegistry();
        foreach ($this->filters as $alias => $filter) {
            $filterRegistry->register($filter, $alias);
        }

        $metadataDriver = new DriverChain($this->metadataDrivers);
        $columnFactory = new ColumnFactory($columnRegistry);
        $metadataFactory = new MetadataFactory($metadataDriver);

        $validator = Validation::createValidator();

        $formFactory = $this->formFactoryBuilder
            ->addExtension(new ValidatorExtension($validator))
            ->addExtension(new GridExtension(
                $columnRegistry,
                $filterRegistry
            ))
            ->getFormFactory();

        $filterFactory = new FilterBarFactory($formFactory, $filterRegistry);
        $queryFactory = new QueryFactory($metadataFactory);

        $gridViewFactory = new GridViewFactory(
            $columnFactory,
            $filterFactory,
            $queryFactory
        );

        $actionPerformer = new ActionPerformer($actionRegistry);

        return new GridFactory(
            $this->agentFinder,
            $metadataFactory,
            $gridViewFactory,
            $actionPerformer
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Psi\Component\Grid;
6
7			use Metadata\Driver\DriverChain;
8			use Metadata\MetadataFactory;
9			use Psi\Component\Grid\Action\DeleteAction;
10			use Psi\Component\Grid\Column\BooleanColumn;
11			use Psi\Component\Grid\Column\DateTimeColumn;
12			use Psi\Component\Grid\Column\MoneyColumn;
13			use Psi\Component\Grid\Column\PropertyColumn;
14			use Psi\Component\Grid\Column\SelectColumn;
15			use Psi\Component\Grid\Filter\BooleanFilter;
16			use Psi\Component\Grid\Filter\NumberFilter;
17			use Psi\Component\Grid\Filter\StringFilter;
18			use Psi\Component\Grid\Form\GridExtension;
19			use Psi\Component\Grid\Metadata\Driver\AnnotationDriver;
20			use Psi\Component\Grid\Metadata\Driver\ArrayDriver;
21			use Psi\Component\ObjectAgent\AgentFinder;
22			use Symfony\Component\Form\Extension\Validator\ValidatorExtension;
23			use Symfony\Component\Form\FormFactoryBuilderInterface;
24			use Symfony\Component\Form\Forms;
25			use Symfony\Component\Validator\Validation;
26			use Psi\Component\Grid\Column\BooleanColumn;
			0 ignored issues – show Bug introduced 2016-12-15 16:27 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Cannot use Psi\Component\Grid\Column\BooleanColumn as BooleanColumn because the name is already in use Loading history...
27			use Psi\Component\Grid\Column\MoneyColumn;
28
29			final class GridFactoryBuilder
30			{
31			private $agentFinder;
32			private $formFactoryBuilder;
33
34			private $actions = [];
35			private $columns = [];
36			private $filters = [];
37			private $metadataDrivers = [];
38
39			public static function create(
40			AgentFinder $agentFinder,
41			FormFactoryBuilderInterface $formFactoryBuilder = null
42			) {
43			$instance = new self();
44			$instance->agentFinder = $agentFinder;
45			$instance->formFactoryBuilder = $formFactoryBuilder ?: Forms::createFormFactoryBuilder();
46
47			return $instance;
48			}
49
50			public static function createWithDefaults(AgentFinder $agentFinder, FormFactoryBuilderInterface $formFactoryBuilder = null)
51			{
52			return self::create($agentFinder, $formFactoryBuilder)
53			->addAction(new DeleteAction(), 'delete')
54			->addColumn(new PropertyColumn(), 'property')
55			->addColumn(new SelectColumn($agentFinder), 'select')
56			->addColumn(new DateTimeColumn(), 'datetime')
57			->addColumn(new MoneyColumn(), 'money')
58			->addColumn(new BooleanColumn(), 'boolean')
59			->addFilter(new StringFilter(), 'string')
60			->addFilter(new BooleanFilter(), 'boolean')
61			->addFilter(new NumberFilter(), 'number');
62			}
63
64			public function addArrayDriver(array $mapping)
65			{
66			$this->metadataDrivers[] = new ArrayDriver($mapping);
67
68			return $this;
69			}
70
71			public function addAnnotationDriver()
72			{
73			$this->metadataDrivers[] = new AnnotationDriver();
74
75			return $this;
76			}
77
78			public function addAction(ActionInterface $action, $alias = null): self
79			{
80			$this->actions[$alias] = $action;
81
82			return $this;
83			}
84
85			public function addFilter(FilterInterface $filter, $alias = null)
86			{
87			$this->filters[$alias] = $filter;
88
89			return $this;
90			}
91
92			public function addColumn(ColumnInterface $column, $alias = null)
93			{
94			$this->columns[$alias] = $column;
95
96			return $this;
97			}
98
99			public function createGridFactory()
100			{
101			if (empty($this->metadataDrivers)) {
102			throw new \InvalidArgumentException(
103			'You must add at least one metadata driver (e.g. ->addArrayDriver, ->addAnnotationDriver, ->addXmlDriver)'
104			);
105			}
106
107			$actionRegistry = new ActionRegistry();
108			foreach ($this->actions as $alias => $action) {
109			$actionRegistry->register($action, $alias);
110			}
111			$columnRegistry = new ColumnRegistry();
112			foreach ($this->columns as $alias => $column) {
113			$columnRegistry->register($column, $alias);
114			}
115			$filterRegistry = new FilterRegistry();
116			foreach ($this->filters as $alias => $filter) {
117			$filterRegistry->register($filter, $alias);
118			}
119
120			$metadataDriver = new DriverChain($this->metadataDrivers);
121			$columnFactory = new ColumnFactory($columnRegistry);
122			$metadataFactory = new MetadataFactory($metadataDriver);
123
124			$validator = Validation::createValidator();
125
126			$formFactory = $this->formFactoryBuilder
127			->addExtension(new ValidatorExtension($validator))
128			->addExtension(new GridExtension(
129			$columnRegistry,
130			$filterRegistry
131			))
132			->getFormFactory();
133
134			$filterFactory = new FilterBarFactory($formFactory, $filterRegistry);
135			$queryFactory = new QueryFactory($metadataFactory);
136
137			$gridViewFactory = new GridViewFactory(
138			$columnFactory,
139			$filterFactory,
140			$queryFactory
141			);
142
143			$actionPerformer = new ActionPerformer($actionRegistry);
144
145			return new GridFactory(
146			$this->agentFinder,
147			$metadataFactory,
148			$gridViewFactory,
149			$actionPerformer
150			);
151			}
152			}
153

psiphp / grid

Pull Request — master (#57)

GridFactoryBuilder::createGridFactory() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like