GridOptions::__construct() - Code Metrics - Inspection of "Filters + Annotation" - psiphp/grid - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

by Daniel

created 2016-11-08 13:11 UTC

GridOptions::__construct() A

↳ Parent: GridOptions

Complexity

Conditions	2
Paths	2

Size

Total Lines	23
Code Lines	15

Duplication

Lines	6
Ratio	26.09 %

Importance

Changes

Metric	Value
dl	6
loc	23
rs	9.0856
c	0
b	0
f	0
cc	2
eloc	15
nc	2
nop	1

<?php

namespace Psi\Component\Grid;

final class GridOptions
{
    private $variant;
    private $page;

    private $pageSize;
    private $orderings;

    public function __construct(array $options)
    {
        $defaults = [
            'page_size' => 50,
            'current_page' => 0,
            'orderings' => [],
            'variant' => null,
        ];

        if ($diff = array_diff(array_keys($options), array_keys($defaults))) {

            throw new \InvalidArgumentException(sprintf(
                'Invalid grid options "%s". Valid options: "%s"',
                implode('", "', $diff), implode('", "', array_keys($defaults))
            ));
        }

        $options = array_merge($defaults, $options);

        $this->currentPage = $options['current_page'];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->pageSize = $options['page_size'];
        $this->orderings = $options['orderings'];
        $this->variant = $options['variant'];
    }

    public function getCurrentPage()
    {
        return $this->currentPage;
    }

    public function getPageSize()
    {
        return $this->pageSize;
    }

    public function getPageOffset()
    {
        return $this->currentPage * $this->pageSize;
    }

    public function getOrderings()
    {
        return $this->orderings;
    }

    public function getVariant()
    {
        return $this->variant;
    }
}


1		<?php
2
3		namespace Psi\Component\Grid;
4
5		final class GridOptions
6		{
7		private $variant;
8		private $page;
		0 ignored issues – show Unused Code introduced 2016-11-08 13:18 UTC by Report Bug Copy Issue Report The property `$page` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
9		private $pageSize;
10		private $orderings;
11
12		public function __construct(array $options)
13		{
14		$defaults = [
15		'page_size' => 50,
16		'current_page' => 0,
17		'orderings' => [],
18		'variant' => null,
19		];
20
21	View Code Duplication	if ($diff = array_diff(array_keys($options), array_keys($defaults))) {
		0 ignored issues – show Duplication introduced 2016-11-06 16:25 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		throw new \InvalidArgumentException(sprintf(
23		'Invalid grid options "%s". Valid options: "%s"',
24		implode('", "', $diff), implode('", "', array_keys($defaults))
25		));
26		}
27
28		$options = array_merge($defaults, $options);
29
30		$this->currentPage = $options['current_page'];
		0 ignored issues – show Bug introduced 2016-11-08 13:18 UTC by Report Bug Copy Issue Report The property `currentPage` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
31		$this->pageSize = $options['page_size'];
32		$this->orderings = $options['orderings'];
33		$this->variant = $options['variant'];
34		}
35
36		public function getCurrentPage()
37		{
38		return $this->currentPage;
39		}
40
41		public function getPageSize()
42		{
43		return $this->pageSize;
44		}
45
46		public function getPageOffset()
47		{
48		return $this->currentPage * $this->pageSize;
49		}
50
51		public function getOrderings()
52		{
53		return $this->orderings;
54		}
55
56		public function getVariant()
57		{
58		return $this->variant;
59		}
60		}
61

psiphp / grid

Pull Request — master (#5)

GridOptions::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like