GridBench::setUp() - Code Metrics - Inspection of "Form" - psiphp/grid - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#21)

by Daniel

created 2016-11-12 18:07 UTC

GridBench::setUp() B

↳ Parent: GridBench

Complexity

Conditions	2
Paths	2

Size

Total Lines	36
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	36
rs	8.8571
cc	2
eloc	20
nc	2
nop	0

<?php

namespace Psi\Component\Grid\Benchmarks;

use Psi\Component\Grid\Tests\Functional\GridTestCase;
use Psi\Component\Grid\Tests\Model\Article;

/**
 * @BeforeMethods({"setUp"})
 * @Revs(100)
 * @Iterations(10)
 * @OutputTimeUnit("milliseconds")
 */
class GridBench extends GridTestCase
{
    private $factory;

    public function setUp()
    {
        $nbObjects = 100;
        for ($i = 0; $i < $nbObjects; $i++) {
            $objects[] = new Article('hello', $i);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        $container = $this->createContainer([
            'mapping' => [
                Article::class => [
                    'grids' => [
                        'main' => [
                            'columns' => [
                                'title' => [
                                    'type' => 'property',
                                ],
                                'number' => [
                                    'type' => 'property',
                                ],
                            ],
                            'filters' => [
                                'title' => [
                                    'type' => 'string',
                                ],
                            ],
                        ],
                    ],
                ],
            ],
            'collections' => [
                Article::class => $objects,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            ],
        ]);

        $this->factory = $container->get('grid.factory');
    }

    /**
     * @Subject()
     */
    public function grid_loading()
    {
        $this->factory->loadGrid(Article::class, []);
    }
}


1			<?php
2
3			namespace Psi\Component\Grid\Benchmarks;
4
5			use Psi\Component\Grid\Tests\Functional\GridTestCase;
6			use Psi\Component\Grid\Tests\Model\Article;
7
8			/**
9			* @BeforeMethods({"setUp"})
10			* @Revs(100)
11			* @Iterations(10)
12			* @OutputTimeUnit("milliseconds")
13			*/
14			class GridBench extends GridTestCase
15			{
16			private $factory;
17
18			public function setUp()
19			{
20			$nbObjects = 100;
21			for ($i = 0; $i < $nbObjects; $i++) {
22			$objects[] = new Article('hello', $i);
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-11-12 17:23 UTC by Report Bug Copy Issue Report `$objects` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$objects = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
23			}
24
25			$container = $this->createContainer([
26			'mapping' => [
27			Article::class => [
28			'grids' => [
29			'main' => [
30			'columns' => [
31			'title' => [
32			'type' => 'property',
33			],
34			'number' => [
35			'type' => 'property',
36			],
37			],
38			'filters' => [
39			'title' => [
40			'type' => 'string',
41			],
42			],
43			],
44			],
45			],
46			],
47			'collections' => [
48			Article::class => $objects,
			0 ignored issues – show Bug introduced 2016-11-12 17:23 UTC by Report Bug Copy Issue Report The variable `$objects` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
49			],
50			]);
51
52			$this->factory = $container->get('grid.factory');
53			}
54
55			/**
56			* @Subject()
57			*/
58			public function grid_loading()
59			{
60			$this->factory->loadGrid(Article::class, []);
61			}
62			}
63

psiphp / grid

Pull Request — master (#21)

GridBench::setUp() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like