| Conditions | 7 |
| Paths | 19 |
| Total Lines | 101 |
| Code Lines | 76 |
| Lines | 32 |
| Ratio | 31.68 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 33 | public function loadMetadataForClass(\ReflectionClass $class) |
||
| 34 | { |
||
| 35 | if (!isset($this->config[$class->getName()])) { |
||
|
|
|||
| 36 | return; |
||
| 37 | } |
||
| 38 | |||
| 39 | $config = $this->resolveConfig([ |
||
| 40 | 'grids' => [], |
||
| 41 | 'queries' => [], |
||
| 42 | ], $this->config[$class->getName()]); |
||
| 43 | |||
| 44 | $queries = []; |
||
| 45 | foreach ($config['queries'] as $queryName => $queryConfig) { |
||
| 46 | $queryConfig = $this->resolveConfig([ |
||
| 47 | 'name' => null, |
||
| 48 | 'selects' => [], |
||
| 49 | 'joins' => [], |
||
| 50 | 'criteria' => [], |
||
| 51 | ], $queryConfig); |
||
| 52 | $queries[$queryName] = new QueryMetadata( |
||
| 53 | $queryName, $queryConfig['selects'], $queryConfig['joins'], $queryConfig['criteria'] |
||
| 54 | ); |
||
| 55 | } |
||
| 56 | |||
| 57 | $grids = []; |
||
| 58 | foreach ($config['grids'] as $gridName => $gridConfig) { |
||
| 59 | $gridConfig = $this->resolveConfig([ |
||
| 60 | 'name' => null, |
||
| 61 | 'query' => null, |
||
| 62 | 'columns' => [], |
||
| 63 | 'filters' => [], |
||
| 64 | 'actions' => [], |
||
| 65 | 'page_size' => 50, |
||
| 66 | ], $gridConfig); |
||
| 67 | |||
| 68 | $columns = []; |
||
| 69 | View Code Duplication | foreach ($gridConfig['columns'] as $columnName => $columnConfig) { |
|
| 70 | $columnConfig = $this->resolveConfig([ |
||
| 71 | 'type' => null, |
||
| 72 | 'tags' => [], |
||
| 73 | 'groups' => [], |
||
| 74 | 'options' => [], |
||
| 75 | ], $columnConfig); |
||
| 76 | |||
| 77 | $columns[$columnName] = new ColumnMetadata( |
||
| 78 | $columnName, |
||
| 79 | $columnConfig['type'], |
||
| 80 | $columnConfig['groups'], |
||
| 81 | $columnConfig['options'], |
||
| 82 | $columnConfig['tags'] |
||
| 83 | ); |
||
| 84 | } |
||
| 85 | |||
| 86 | $filters = []; |
||
| 87 | View Code Duplication | foreach ($gridConfig['filters'] as $filterName => $filterConfig) { |
|
| 88 | $filterConfig = $this->resolveConfig([ |
||
| 89 | 'type' => null, |
||
| 90 | 'field' => null, |
||
| 91 | 'options' => [], |
||
| 92 | 'tags' => [], |
||
| 93 | ], $filterConfig); |
||
| 94 | |||
| 95 | $filters[$filterName] = new FilterMetadata( |
||
| 96 | $filterName, |
||
| 97 | $filterConfig['type'], |
||
| 98 | $filterConfig['field'], |
||
| 99 | $filterConfig['options'], |
||
| 100 | $filterConfig['tags'] |
||
| 101 | ); |
||
| 102 | } |
||
| 103 | |||
| 104 | $actions = []; |
||
| 105 | foreach ($gridConfig['actions'] as $actionName => $actionConfig) { |
||
| 106 | $actionConfig = $this->resolveConfig([ |
||
| 107 | 'type' => null, |
||
| 108 | 'options' => [], |
||
| 109 | 'tags' => [], |
||
| 110 | ], $actionConfig); |
||
| 111 | |||
| 112 | $actions[$actionName] = new ActionMetadata( |
||
| 113 | $actionName, |
||
| 114 | $actionConfig['type'], |
||
| 115 | $actionConfig['options'], |
||
| 116 | $actionConfig['tags'] |
||
| 117 | ); |
||
| 118 | } |
||
| 119 | |||
| 120 | $grids[$gridName] = new GridMetadata( |
||
| 121 | $gridName, |
||
| 122 | $columns, |
||
| 123 | $filters, |
||
| 124 | $actions, |
||
| 125 | $gridConfig['page_size'], |
||
| 126 | $gridConfig['query'] |
||
| 127 | ); |
||
| 128 | } |
||
| 129 | |||
| 130 | $classMetadata = new ClassMetadata($class->getName(), $grids, $queries); |
||
| 131 | |||
| 132 | return $classMetadata; |
||
| 133 | } |
||
| 134 | |||
| 155 |