Psi\Component\Grid\EventDispatchingFilterBarFactory

Complexity

Total Complexity

3

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	createForm()	0	4	1
A	createExpression()	0	9	1

<?php

declare(strict_types=1);

namespace Psi\Component\Grid;

use Psi\Component\Grid\Event\ExpressionEvent;
use Psi\Component\Grid\Metadata\GridMetadata;
use Psi\Component\ObjectAgent\Capabilities;
use Psi\Component\ObjectAgent\Query\Expression;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\Form\FormInterface;

class EventDispatchingFilterBarFactory implements FilterBarFactoryInterface
{
    const FORM_NAME = 'filter';

    private $innerFactory;
    private $dispatcher;

    public function __construct(
        FilterBarFactoryInterface $factory,
        EventDispatcherInterface $dispatcher
    ) {
        $this->innerFactory = $factory;
        $this->dispatcher = $dispatcher;
    }

    public function createForm(GridMetadata $gridMetadata, Capabilities $capabilities): FormInterface
    {
        return $this->innerFactory->createForm($gridMetadata, $capabilities);
    }

    public function createExpression(GridMetadata $gridMetadata, array $data): Expression
    {
        $expression = $this->innerFactory->createExpression($gridMetadata, $data);

        $event = new ExpressionEvent($gridMetadata, $expression);

It seems like $expression defined by $this->innerFactory->createExpression($gridMetadata, $data) on line 36 can be null; however, Psi\Component\Grid\Event\ExpressionEvent::__construct() does not accept null, maybe add an additional type check?

        $this->dispatcher->dispatch(Events::EXPRESSION_CREATED, $event);

        return $event->getExpression();
    }
}