Psi\Bundle\Description\DependencyInjection\Compiler\ExtensionPass::process()

Complexity

Conditions	5
Paths	6

Size

Total Lines	37
Code Lines	21

Duplication

Lines	14
Ratio	37.84 %

Importance

Changes

0

<?php
    public function process(ContainerBuilder $container)
    {
        if (!$container->hasDefinition('psi_description.schema')) {
            return;
        }

        $schemaDef = $container->getDefinition('psi_description.schema');
        $extensionIds = $container->findTaggedServiceIds('psi_description.schema_extension');

        $extensionRefs = [];
        foreach ($extensionIds as $extensionId => $attributes) {

This code seems to be duplicated across your project.

            $attributes = $attributes[0];

            if (!isset($attributes['alias'])) {
                throw new \InvalidArgumentException(sprintf(
                    'Description schema extension "%s" has no "alias" attribute in its tag',
                    $extensionId
                ));
            }

            $alias = $attributes['alias'];

            $extensionRefs[$alias] = new Reference($extensionId);
        }

        $enabledEnhancers = $container->getParameter('psi_description.schema.extensions');
        $diff = array_diff($enabledEnhancers, array_keys($extensionRefs));

        if ($diff) {

The expression $diff of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            throw new \InvalidArgumentException(sprintf(
                'Unknown schema extension(s) "%s" specified. Known extensions: "%s"',
                implode('", "', $diff), implode('", "', array_keys($extensionRefs))
            ));
        }

        $schemaDef->replaceArgument(0, array_values($extensionRefs));
    }
}