Psi\Bundle\Description\DependencyInjection\Compiler\DescriptionFactoryPass::process()

Complexity

Conditions	7
Paths	9

Size

Total Lines	61
Code Lines	38

Duplication

Lines	15
Ratio	24.59 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function process(ContainerBuilder $container)
    {
        if (!$container->hasDefinition('psi_description.factory')) {
            return;
        }

        $factoryDef = $container->getDefinition('psi_description.factory');
        $enhancerIds = $container->findTaggedServiceIds('psi_description.enhancer');
        $resolverIds = $container->findTaggedServiceIds('psi_description.subject_resolver');

        $refs = [
            'enhancer' => [],
            'subject_resolver' => [],
        ];

        foreach ([
            'enhancer' => $enhancerIds,
            'subject_resolver' => $resolverIds,
        ] as $key => $serviceIds) {
            $humanKey = str_replace('_', ' ', $key);
            foreach ($serviceIds as $serviceId => $attributes) {

This code seems to be duplicated across your project.

                $attributes = $attributes[0];

                if (!isset($attributes['alias'])) {
                    throw new \InvalidArgumentException(sprintf(
                        'Description %s "%s" has no "alias" attribute in its tag',
                        $humanKey,
                        $serviceId
                    ));
                }

                $alias = $attributes['alias'];

                $refs[$key][$alias] = new Reference($serviceId);
            }

            $enabled = $container->getParameter(sprintf('psi_description.%ss', $key));
            $diff = array_diff($enabled, array_keys($refs[$key]));

            if ($diff) {

The expression $diff of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                throw new \InvalidArgumentException(sprintf(
                    'Unknown %s(s) "%s" specified. Known %s(s): "%s"',
                    $humanKey,
                    implode('", "', $diff),
                    $humanKey,
                    implode('", "', array_keys($refs[$key]))
                ));
            }

            $orderedRefs = [];

            foreach ($enabled as $enabledAlias) {
                $orderedRefs[$enabledAlias] = $refs[$key][$enabledAlias];
            }

            $refs[$key] = $orderedRefs;
        }

        $factoryDef->replaceArgument(0, array_values($refs['enhancer']));
        $factoryDef->replaceArgument(2, array_values($refs['subject_resolver']));
    }
}